[webkit-qt] libxslt / xml support

[laszlo.1.gombos at nokia.com]

On 11/25/11 6:19 AM, "ext Simon Hausmann" <simon.hausmann at nokia.com> wrote:

>On Friday, November 25, 2011 02:40:08 PM ext Konstantin Tokarev wrote:
>> 25.11.2011, 14:09, "Simon Hausmann" <simon.hausmann at nokia.com>:
>> > Hi,
>> > 
>> > While we're at the topic of third-party libraries (ICU...), there's
>>one
>> > other thing that I discussed with Andreas yesterday that might make
>> > sense for us regarding XSLT support:
>> > 
>> > I'd like to propose that we remove the code that uses QtXmlPatterns to
>> > implement XSLT support in WebKit. Instead I'd like to make libxslt a
>> > dependency (now that we have configure tests) for anyone who wants to
>> > build QtWebKit with XSLT support.
>> > 
>> > If XSLT support is enabled - and therefore libxslt available - we also
>> > get an implicit availability of libxml. I suggest that in that case we
>> > also use libxml for XML parsing.
>> > 
>> > If XSLT support is _not_ enabled, we don't have libxslt and therefore
>> > also no libxml available and should continue to use QXmlStreamReader
>> > for XML parsing.
>> > 
>> > Does that sound reasonable?
>> 
>> But it will bring two extra dependencies at once - libxslt and libxml2.
>>Does
>> anybody here care about embedded systems?
>
>Well, it's optional.
>
>If you want XSLT support, you need libxslt, which in turn needs libxml2.
>
>If you don't want XSLT support, then that's fine and we'll fall back to
>using
>Qt's built-in XML parser.
>
>But as it stands today, Qt's support for XSLT is not up to the task and
>there 
>haven't been any efforts in the recent years to significantly close the
>gap 
>between libxslt and QtXmlPatterns in terms of completeless of XSLT
>support.


One more strong +1 to this.

I like the direction that we started with HTML5 video support and I think
this proposal is a logical continuation of that direction. Using
Gstreamer, ICU, libxml, libxslt, etc enables QtWebKit to share more code
with other WebKit ports and have better quality (less bugs, more feature
completeness) for those platforms where these libraries are available.

Using these libraries should also be the configuration that we use in the
buildbot to maximize the number of LayoutTests tests that QtWebKit can
pass (unskip tests that QtWebKit was failing because of relying on Qt
libraries).

Laszlo