[webkit-qt] Build errors
Morten Sylvest Olsen
Morten.s.Olsen at kapowsoftware.com
Tue Dec 13 04:46:23 PST 2011
Hi Joe,
I've succeeded in building trunk with qt5 and v8, with minor modifications (patch following). Obviously not a correct solution, but it builds and seem to work :-)
Regards, Morten
--- a/Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp
+++ b/Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp
@@ -163,11 +163,11 @@ v8::Handle<v8::Value> V8InjectedScriptHost::functionLocationCallback(const v8::A
return v8::Undefined();
v8::Handle<v8::Function> function = v8::Handle<v8::Function>::Cast(value);
int lineNumber = function->GetScriptLineNumber();
- int columnNumber = function->GetScriptColumnNumber();
+ // int columnNumber = function->GetScriptColumnNumber();
v8::Local<v8::Object> result = v8::Object::New();
result->Set(v8::String::New("lineNumber"), v8::Integer::New(lineNumber));
- result->Set(v8::String::New("columnNumber"), v8::Integer::New(columnNumber));
- result->Set(v8::String::New("scriptId"), function->GetScriptId()->ToString());
+ // result->Set(v8::String::New("columnNumber"), v8::Integer::New(columnNumber));
+ // result->Set(v8::String::New("scriptId"), function->GetScriptId()->ToString());
return result;
}
diff --git a/Source/WebCore/platform/qt/PlatformSupportQt.cpp b/Source/WebCore/platform/qt/PlatformSupportQt.cpp
index 4e33a9f..fc8d2db 100644
--- a/Source/WebCore/platform/qt/PlatformSupportQt.cpp
+++ b/Source/WebCore/platform/qt/PlatformSupportQt.cpp
@@ -31,8 +31,9 @@ namespace WebCore {
bool PlatformSupport::popupsAllowed(NPP npp)
{
- if (npp && npp->ndata)
- return static_cast<PluginView*>(npp->ndata)->arePopupsAllowed();
+ // FIXME(mso)
+ // if (npp && npp->ndata)
+ // return static_cast<PluginView*>(npp->ndata)->arePopupsAllowed();
return false;
}
diff --git a/Tools/DumpRenderTree/qt/EventSenderQt.cpp b/Tools/DumpRenderTree/qt/EventSenderQt.cpp
index 1ecb739..dd11738 100644
--- a/Tools/DumpRenderTree/qt/EventSenderQt.cpp
+++ b/Tools/DumpRenderTree/qt/EventSenderQt.cpp
@@ -479,8 +479,11 @@ void EventSender::releaseTouchPoint(int index)
}
void EventSender::sendTouchEvent(QEvent::Type type)
-{
- QTouchEvent event(type, QTouchEvent::TouchScreen, m_touchModifiers);
+{
+ QTouchDevice touchDev;
+ touchDev.setType(QTouchDevice::TouchScreen);
+
+ QTouchEvent event(type, &touchDev, m_touchModifiers);
event.setTouchPoints(m_touchPoints);
sendEvent(m_page, &event);
QList<QTouchEvent::TouchPoint>::Iterator it = m_touchPoints.begin();
diff --git a/Tools/QtTestBrowser/QtTestBrowser.pro b/Tools/QtTestBrowser/QtTestBrowser.pro
index 4e36c4d..469d673 100644
--- a/Tools/QtTestBrowser/QtTestBrowser.pro
+++ b/Tools/QtTestBrowser/QtTestBrowser.pro
@@ -35,7 +35,7 @@ CONFIG += uitools
load(webcore)
-CONFIG += qtwebkit
+CONFIG += qtwebkit qtwidgets
DESTDIR = $$ROOT_BUILD_DIR/bin
diff --git a/Tools/QtTestBrowser/launcherwindow.h b/Tools/QtTestBrowser/launcherwindow.h
index 0678f1d..82b86fa 100644
--- a/Tools/QtTestBrowser/launcherwindow.h
+++ b/Tools/QtTestBrowser/launcherwindow.h
@@ -65,6 +65,7 @@
#include "webview.h"
class QPropertyAnimation;
+class QLineEdit;
class WindowOptions {
public:
________________________________________
From: webkit-qt-bounces at lists.webkit.org [webkit-qt-bounces at lists.webkit.org] on behalf of Joe Yu [Joe.Yu at arm.com]
Sent: Tuesday, December 13, 2011 12:54 PM
To: Simon Hausmann; webkit-qt at lists.webkit.org
Subject: Re: [webkit-qt] Build errors
Hi Simon,
I actually tried the trunk, but got new build problem, for example:
../../../../Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp:166:34: error: ‘class v8::Function’ has no member named ‘GetScriptColumnNumber’
../../../../Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp:170:56: error: ‘class v8::Function’ has no member named ‘GetScriptId’
These two symbols for Function methods are not defined in the my qt5/qtbase/src/3rdparty/v8/include/v8.h. I think it is asking for a quite newer version of V8 at google's trunk, but there is no way to easily upgrade the qt5/qtbase conceived V8 to the new version, as a number of modifications are needed to fit into their QML.
Another interesting thing is the revision r102596 I was building is proved to pass building by WebKit's buildbot:
http://build.webkit.org/builders/Qt%20Linux%20Release/builds/40903
What environment did they base on? and what configuration were they using (whether they enabled --V8)?
Thanks,
Joe
-----Original Message-----
From: Simon Hausmann [mailto:simon.hausmann at nokia.com]
Sent: 2011年12月13日 PM 05:59
To: webkit-qt at lists.webkit.org
Cc: Joe Yu
Subject: Re: [webkit-qt] Build errors
On Tuesday, December 13, 2011 03:13:51 PM ext Joe Yu wrote:
> Hi,
>
> I tried to build qtwebkit with qt5, but it always failed with
> incompatible with the latest Qt5, I tried to fixed a lot of build
> errors (see attached) and finally get them resovled and gets a
> successful build with V8 and
> WebKit2 disabled.
> When I began to enable V8, the following error appears
>
> ../../../Source/WebCore/bindings/v8/ScriptDebugServer.cpp:36:34:
> fatal
> error: DebuggerScriptSource.h: No such file or directory
> But I search my source tree but couldn’t find file DebuggerScriptSource.h!
>
>
> I began to doubt I'm using a wrong branch, is there anybody can help?
Yeah, it looks like you're using the wrong branch of WebKit. You should try WebKit trunk instead of the Qt port's release branch :)
Simon
> My environment is:
> Qtwebkit branch: git://gitorious.org/webkit/gtwebkit -b
> qtwebkit-2.2
Qt5: git://gitorious.org/qt/qt5.git -b master
>
> Joe Yu
>
>
>
> -- IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose the
> contents to any other person, use it for any purpose, or store or copy the
> information in any medium. Thank you.
-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
_______________________________________________
webkit-qt mailing list
webkit-qt at lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-qt
More information about the webkit-qt
mailing list