[webkit-qt] Procedure for bug fix ?

[Ademar Reis]

Hi Lindsay.

I see that you've solved your problem already, but just for the record
(in case someone goes through the list archives):

If a bug is found in code that has been already landed but it's not
causing test to fail or breaking the build, the best alternative is to
open a new bug and attach the patch there, just like you would do with
any other bug or change.

If it's causing tests to fail or broke the build and the fix is not
trivial, then it's reverted and the original bug is reopened.

Details on how to submit contributions are in the wiki:
http://trac.webkit.org/wiki/QtWebKitContrib

Cheers,
   - Ademar

On Sat, Aug 20, 2011 at 11:35 PM, Lindsay Mathieson
<lindsay.mathieson at gmail.com> wrote:
> I've submitted a patch to the original bug
>
> On 21 August 2011 12:06, Lindsay Mathieson <lindsay.mathieson at gmail.com> wrote:
>> My patch for adding inline spell checking has a honking big bug, due
>> to my misunderstaning of QtPlatformPlugin behaviour, didn't realise it
>> unloaded the plugins in its destructor, so the following:
>>
>> bool TextCheckerClientQt::loadSpellChecker()
>> {
>>    if (m_spellChecker)
>>        return true;
>>
>>    QtPlatformPlugin platformPlugin;
>>
>>    if ((m_spellChecker = platformPlugin.createSpellChecker()))
>>        return true;
>>
>>    return false;
>> }
>>
>> crashes really badly :) It didn't show up in my testing as I used a
>> static plugin.
>>
>> Fixed it - should I just submit my patch for review against the first review?
>>
>>  https://bugs.webkit.org/show_bug.cgi?id=44114
>>
>>
>> --
>> Lindsay
>>
>
>
>
> --
> Lindsay
> _______________________________________________
> webkit-qt mailing list
> webkit-qt at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-qt
>



-- 
Ademar de Souza Reis Jr. <ademar.reis at openbossa.org>
Nokia Institute of Technology