[webkit-qt] QNetworkReplyHandler forces Network response to be buffered for uploads

[markus.goetz at nokia.com]

The code looks good to me :-)
Any special reason you need fileSize and dataSize and not only totalSiize?

If this is the way we want to do it the QtWebKit team (Simon?) needs to decide. It will mean that we cannot properly re-post if authentication from HTTP was requested.

Another solution (additionally to computeSize) would be to make the QIODevice non-sequential (random access). Then you can avoid setting DoNotBufferUploadDataAttribute and the HTTP code can rewind the upload device and re-POST it.

Markus
________________________________________
From: webkit-qt-bounces at lists.webkit.org [webkit-qt-bounces at lists.webkit.org] On Behalf Of ext Sriram Neelakandan [sriram.neelakandan at gmail.com]
Sent: Wednesday, September 22, 2010 1:30 PM
To: webkit-qt
Subject: Re: [webkit-qt] QNetworkReplyHandler forces Network response to be     buffered for uploads

Re-sending .. did not realize the list would  scrub my patch

http://pastebin.com/w8Q5yXn4


On 9/22/10, Sriram Neelakandan <sriram.neelakandan at gmail.com> wrote:
> Dear list,
>
> Webkit's QNRHandler.cpp does not set up
> ContentLength and  QNetworkRequest::DoNotBufferUploadDataAttribute
> and eventually forces QNetworkReplyImpl to buffer up the data;
>
> This is not fine for uploading large files, since eventually systems
> it will run out of memory
> Here is a small patch that works around it.
> I will shortly report a bug at webkit.org
> But just wanted to check on the qt list if the changes look good ?
>
>
> --
> Sriram Neelakandan
> Author - Embedded Linux System Design And Development
> (http://tinyurl.com/2doosu)
>


--
Sriram Neelakandan
Author - Embedded Linux System Design And Development
(http://tinyurl.com/2doosu)
_______________________________________________
webkit-qt mailing list
webkit-qt at lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-qt