[webkit-qt] Problem with PluginStrategy::getPluginInfo()

[Ademar de Souza Reis Jr.]

On Sun, Sep 19, 2010 at 03:57:47AM +0200, Andreas Kling wrote:
> Hey folks,
> 
> Since PlatformStrategies were enabled for Qt with
> http://trac.webkit.org/changeset/67787 we've got a little problem.
> 
> The global PlatformStrategies object is bound to the most recently
> created QWebPage (happens in QWebPagePrivate constructor.) This is
> problematic for PluginData::initPlugins() which calls our
> PluginStrategy::getPluginInfo() _without page context_.
> 
> This is currently causing http://ie.microsoft.com/testdrive/Performance/BrowserHunt/Default.xhtml
> to crash.

Mine doesn't crash, but I belive you. :)

> 
> And regardless, we can't tie getPluginInfo() to a specific QWebPage
> since that breaks reimplementation of QWebPage::pluginFactory().
> 
> Ademar, Kenneth, everyone else, thoughts?

My changes were relatively simple and I didn't think about the
factory case. I just made the changes and tested the
browser/plugins (sorry).

Anyway, I believe the correct solution is the one proposed by
Balazs on his reply to this thread (bug 45857). Please let me know if
there's anything I can help.

Cheers,
  - Ademar

-- 
Ademar de Souza Reis Jr.
OpenBossa Labs - Instituto Nokia de Tecnologia (INdT)

^[:wq!