[webkit-qt] WebKit coding style on Qt files

Ademar de Souza Reis Jr. ademar.reis at openbossa.org
Mon Oct 25 12:18:59 PDT 2010

On Wed, Oct 20, 2010 at 05:01:19PM -0300, Ademar de Souza Reis Jr. wrote:
> Hi there.
> from http://trac.webkit.org/wiki/QtWebKitContrib:
> "Effective immediately all commits to QtWebKit should use the
> WebKit coding style for all files  in the project. That includes
> qwebview(.h|cpp), qwebpage(.h|.cpp) and all others. Repeat: the
> Qt style should not be used. Thank you."
> I'm about to submit a patch changing check-webkit-style to
> enforce webkit coding style on Qt files. Since that is going to
> affect everybody, I just wanted to confirm you're all happy with
> such a change. :-)

I've run check-webkit-style on WebKit/qt/Api and the most common
conflicts with the Qt coding style are:

 - include guards should be bla_h instead of BLA_H
 - the infamous :) "declaration has space between type name and */&"
 - should be "class QWhatever {" instead of "class QWhatever\n{"
 - code inside a namespace should not be indented
 - headers not in alphabetic order

Besides these conflicts, there are inumerous errors which
will be caught once we start using check-webkit-style.

We could also add exceptions to check-webkit-style when checking
Qt files.

I'm about to submit the patch for review, speak now or... :-)

Ademar de Souza Reis Jr.
OpenBossa Labs - Instituto Nokia de Tecnologia (INdT)


More information about the webkit-qt mailing list