[webkit-help] running check-webkit-style on webkit-gtk

[Denis Nomiyama]

Hi Mahesh,

Please try installing Subversion. It doesn't come by default in some Linux
distro (e.g. Ubuntu 12.10, etc).

I'm not sure if you can apply it to a specific directory, but the option
--diff-files is very useful to avoid checking code that isn't related to
your changes.

Cheers,
Denis

> -----Original Message-----
> From: webkit-help-bounces at lists.webkit.org [mailto:webkit-help-
> bounces at lists.webkit.org] On Behalf Of Brian Holt
> Sent: 17 September 2013 13:28
> To: 'mahesh gawali'; webkit-help at lists.webkit.org
> Subject: Re: [webkit-help] running check-webkit-style on webkit-gtk
> 
> Hi Mahesh,
> 
> With most unix scripts there is a "--help" optional flag implemented
> that will give you a clue how use the tool in question.  Check-webkit-
> style is no different.
> 
> $ Tools/Scripts/check-webkit-style --help
> Usage: check-webkit-style [--help] [options] [path1] [path2] ...
> 
> Overview:
>   Check coding style according to WebKit style guidelines:
> 
>       http://webkit.org/coding/coding-style.html
> 
>   Path arguments can be files and directories.  If neither a git commit
> nor
>   paths are passed, then all changes in your source control working
> directory
>   are checked.
> 
> 
> This ^ is the clue to your error.  Since you didn't pass an argument,
> it attempted to check all the changes in your source control working
> directory, but it failed because it could not determine what SCM
> (Source Control
> Management) system you are using.
> 
> Where did you get the code from? Git, SVN, a tarball or somewhere else?
> 
> Regards
> Brian
> 
> > -----Original Message-----
> > From: webkit-help-bounces at lists.webkit.org [mailto:webkit-help-
> > bounces at lists.webkit.org] On Behalf Of mahesh gawali
> > Sent: 17 September 2013 12:54
> > To: webkit-help at lists.webkit.org
> > Subject: [webkit-help] running check-webkit-style on webkit-gtk
> >
> > Hi All,
> >
> >
> > I am trying to run check-webkit-style on webkit-gtk build for coding
> > guideline conformance.
> >
> >
> > I am getting following error:
> >
> >
> > [root at localhost Scripts]# ./check-webkit-style Traceback (most recent
> > call last):
> >   File "./check-webkit-style", line 48, in <module>
> >     sys.exit(CheckWebKitStyle().main())
> >   File "/home/Webkit-GTK/Tools/Scripts/webkitpy/style/main.py", line
> > 127, in main
> >     host._initialize_scm()
> >   File "/home/Webkit-GTK/Tools/Scripts/webkitpy/common/host.py", line
> > 112, in _initialize_scm
> >     self._scm = detector.default_scm(patch_directories)
> >   File "/home/Webkit-
> > GTK/Tools/Scripts/webkitpy/common/checkout/scm/detection.py", line 60,
> > in default_scm
> >     raise Exception("FATAL: Failed to determine the SCM system for
> > either %s or %s" % (cwd, script_directory))
> > Exception: FATAL: Failed to determine the SCM system for either
> > /home/Webkit-GTK/Tools/Scripts or /home/Webkit-
> > GTK/Tools/Scripts/webkitpy/common/checkout/scm
> >
> >
> >
> >
> > Also, Is it possible to point the script to a specific directory for
> > coding style checks
> >
> 
> 
> 
> _______________________________________________
> webkit-help mailing list
> webkit-help at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-help