[webkit-help] Platform specific expected files for layout test cases

Ryosuke Niwa rniwa at webkit.org
Wed Mar 28 10:46:59 PDT 2012

In most cases, you rebaseline one platform locally to verify the
correctness of the behavior change and let reviewers know of the change,
then just land the patch.

Once the patch is landed, you can pick up new results out of bots on
build.webkit.org, and land them without reviews if you're a committer. If
not, then ask your reviewer or some other committer to assist you.

- Ryosuke
On Mar 28, 2012 3:53 AM, "Arpita Bahuguna" <arpitabahuguna at gmail.com> wrote:

> Dear Webkit team,
> In case the fix for some issue is changing the expected output of an
> existing Layout Test case which is platform specific; while submitting
> patch for such an issue do we generate new expected files for all platforms
> (which might not be possible) or do we submit the patch with the new
> expected file for one specific platform alone?
> The issue which I am currently working on is related to the rendering of
> replaced elements within a table-cell (with auto/percent height) [
> https://bugs.webkit.org/show_bug.cgi?id=81084]
> The fix for the above issue changes the expected output (png image) for
> the WebKit\LayoutTests\fast\replaced\width100percent-image.html test case.
> This test case is platform dependent.
> I now wish to submit a patch for the above issue. The patch should
> therefore contain the new expected output for the aforementioned test case.
> How do I get the expected file (xxxxx.png) for different platforms?
> Thanks in advance.
> Regards,
> Arpita
> _______________________________________________
> webkit-help mailing list
> webkit-help at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-help
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-help/attachments/20120328/ca43aebf/attachment.html>

More information about the webkit-help mailing list