[webkit-help] Doubt regarding placement of -expected.txt for a new layout test.

[SravanKumar Sandela]

I thought we do not need a pixel test as render tree is sufficient enough
to check the behavior(and i also avoided text).
Can you please let me know if i am missing some thing, on how to figure out
if a pixel dump is also needed?

-Sravan.


On Thu, Feb 23, 2012 at 7:24 AM, Dirk Pranke <dpranke at chromium.org> wrote:

> Argh... my dog made me hit "send" too soon. Diagnosis on the bug :).
>
> On Wed, Feb 22, 2012 at 5:53 PM, Dirk Pranke <dpranke at chromium.org> wrote:
> > I replied on the bug - it looks like
> >
> > On Wed, Feb 22, 2012 at 5:34 PM, Sravan <sra1sandela at gmail.com> wrote:
> >> Hi
> >>
> >> The patch is in https://bugs.webkit.org/show_bug.cgi?id=78684 .
> >> Its output is
> >>
> >> http://queues.webkit.org/results/11520393
> >>
> >>
> >>
> >> Thanks for the quick reply.
> >>
> >> -Sravan.
> >>
> >> On Thu, Feb 23, 2012 at 6:53 AM, Dirk Pranke <dpranke at chromium.org>
> wrote:
> >>>
> >>> It should be looking in platform/win, as you say. Can you point me at
> >>> your patch?
> >>>
> >>> It may be that the bot isn't applying the patch correctly and the
> >>> baseline isn't actually making it on to the bot.
> >>>
> >>> -- Dirk
> >>>
> >>> On Wed, Feb 22, 2012 at 5:17 PM, SravanKumar Sandela
> >>> <ssandela at innominds.com> wrote:
> >>> > Hi,
> >>> >
> >>> > I have submitted a patch along with a new layout test. Cr-linux bot
> is
> >>> > failing with a regression result as
> >>> >
> >>> > Regressions: Unexpected no expected results found : (1)
> >>> >   fast/forms/fieldset-legend-padding-unclipped-fieldset-border.html =
> >>> > MISSING
> >>> >
> >>> > Failed to run "['xvfb-run', 'Tools/Scripts/new-run-webkit-tests',
> >>> > '--chromium', '--skip-failing-tests', '--no-ne..." exit_code: 1
> >>> > Using port 'chromium-linux-x86_64'
> >>> > Test configuration: <lucid, x86_64, release, cpu>
> >>> > Placing test results in /tmp/layout-test-results
> >>> > Baseline search path: chromium-linux -> chromium-win -> chromium ->
> win
> >>> > ->
> >>> > mac -> generic
> >>> >
> >>> >
> >>> > I have uploaded the patch with -expected.txt file which is sitting in
> >>> > /platform/win/fast/forms/. From the last line which i have pasted
> above,
> >>> > i thought it will look for -expected file in /platform/win/ path
> also,
> >>> > but
> >>> > still i see the error, can u please suggest what am i missing,
> should i
> >>> > be
> >>> > keeping the -expected.txt near the test case itself as its output is
> >>> > independent of platform, or should i keep it in /platform/chromium/
> or
> >>> > /platform/chromium-linux/ and then again re-submit the patch.
> >>> >
> >>> > -Sravan.
> >>> >
> >>> >
> >>> >
> >>> > _______________________________________________
> >>> > webkit-help mailing list
> >>> > webkit-help at lists.webkit.org
> >>> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-help
> >>> >
> >>> _______________________________________________
> >>> webkit-help mailing list
> >>> webkit-help at lists.webkit.org
> >>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-help
> >>
> >>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-help/attachments/20120223/273d939b/attachment.html>