[webkit-help] Creating tests in LayoutTests/fast/

[Razvan Caliman]

Thank you, Sravan and Adam.

I had a feeling that the naming refers to the speed of the test run, but I wanted to make sure.

Thank you!

From: Sravan <sravan.ken at gmail.com<mailto:sravan.ken at gmail.com>>
Date: Wed, 1 Jun 2011 07:22:05 +0100
To: Adam Roben <aroben at apple.com<mailto:aroben at apple.com>>, Razvan Caliman <rcaliman at adobe.com<mailto:rcaliman at adobe.com>>
Cc: "webkit-help at lists.webkit.org<mailto:webkit-help at lists.webkit.org>" <webkit-help at lists.webkit.org<mailto:webkit-help at lists.webkit.org>>
Subject: Re: [webkit-help] Creating tests in LayoutTests/fast/

Hi Adam /Razvan,

Based on my experience, I have a little different understanding. What I had seen is that all the tests inside fast folder run real fast compared to other tests. When I used to run layout tests, it used to take approx 20seconds for running 1 test in other folders, whereas the tests in fast folder would take only 1-2 seconds. So, if you feel your test is taking anything more than 5-10 seconds please include it in the appropriate test directory as Adam mentioned. otherwise you can include it in fast directory in the appropriate test directory inside fast folder.

That is the reason I believe we have category of tests (e.g. css) inside fast whereas same category of tests also exist outside (css1, css2 etc).
End of the day, your tests would run where ever you keep them inside LayoutTests folder. The only difference comes when we start running the tests w.r.t a particular directory like,

./run-webkit-tests fast

or

./run-webkit-tests css2.1 etc.

Please let me know if you have any other thoughts.


-Sravan



From: Adam Roben <aroben at apple.com<mailto:aroben at apple.com>>
Date: Mon, May 30, 2011 at 7:21 PM
Subject: Re: [webkit-help] Creating tests in LayoutTests/fast/
To: Razvan Caliman <rcaliman at adobe.com<mailto:rcaliman at adobe.com>>
Cc: "webkit-help at lists.webkit.org<mailto:webkit-help at lists.webkit.org>" <webkit-help at lists.webkit.org<mailto:webkit-help at lists.webkit.org>>


On May 30, 2011, at 8:13 AM, Razvan Caliman wrote:

> I am new to WebKit, but I'd like to contribute tests.
>
> I did reading on the wiki but I'm a bit confused by the /LayoutTests/fast/ folder.
> What kind of tests go in there?  When is it appropriate to create tests under LayoutTests/fast/  ?

There's no real criteria that a test has to meet in order to be put inside "fast". (The name "fast" is definitely not about speed at this point, if it ever was.) Some of the other directories have criteria (e.g., "http" is where tests that need to be loaded from a webserver go), but "fast" doesn't. At least that's my understanding. My basic strategy is to put a new test next to other similar tests.

-Adam

_______________________________________________
webkit-help mailing list
webkit-help at lists.webkit.org<mailto:webkit-help at lists.webkit.org>
http://lists.webkit.org/mailman/listinfo.cgi/webkit-help




--
Living for the unseen and undone....



--
Living for the unseen and undone....
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-help/attachments/20110601/d067dd2d/attachment.html>