<div dir="ltr">I&#39;m afraid the FFTFrame changes were right (or at least needed) after all; without that patch, I got:<div><br></div><div><div>   Source/WebCore/platform/audio/gstreamer/FFTFrameGStreamer.cpp:46:38: error: use of undeclared identifier &#39;GstFFTF32Complex&#39;</div><div>       , m_complexData(std::make_unique&lt;GstFFTF32Complex[]&gt;(unpackedFFTDataSize(m_FFTSize)))</div><div>                                        ^</div><div><br></div><div>however, your comment on gstreamermm not being required, was indeed correct — I instead needed to depend_on gst-plugins-base.</div><div><br></div><div>-----</div><div><br></div><div>All in all, the Homebrew formula finally builds successfully, and t<span style="color:rgb(51,51,51);font-family:&#39;Helvetica Neue&#39;,Helvetica,&#39;Segoe UI&#39;,Arial,freesans,sans-serif,&#39;Apple Color Emoji&#39;,&#39;Segoe UI Emoji&#39;,&#39;Segoe UI Symbol&#39;;font-size:13.888888359069824px">here is now an open pull request for adding the</span><span style="color:rgb(51,51,51);font-family:&#39;Helvetica Neue&#39;,Helvetica,&#39;Segoe UI&#39;,Arial,freesans,sans-serif,&#39;Apple Color Emoji&#39;,&#39;Segoe UI Emoji&#39;,&#39;Segoe UI Symbol&#39;;font-size:13.888888359069824px"> </span><code style="color:rgb(51,51,51);font-family:Consolas,&#39;Liberation Mono&#39;,Menlo,Courier,monospace;font-size:11.80555534362793px;padding:0.2em 0px;margin:0px;background-color:rgba(0,0,0,0.0392157);border-top-left-radius:3px;border-top-right-radius:3px;border-bottom-right-radius:3px;border-bottom-left-radius:3px">webkitgtk-2.4.9</code><span style="color:rgb(51,51,51);font-family:&#39;Helvetica Neue&#39;,Helvetica,&#39;Segoe UI&#39;,Arial,freesans,sans-serif,&#39;Apple Color Emoji&#39;,&#39;Segoe UI Emoji&#39;,&#39;Segoe UI Symbol&#39;;font-size:13.888888359069824px"> </span><span style="color:rgb(51,51,51);font-family:&#39;Helvetica Neue&#39;,Helvetica,&#39;Segoe UI&#39;,Arial,freesans,sans-serif,&#39;Apple Color Emoji&#39;,&#39;Segoe UI Emoji&#39;,&#39;Segoe UI Symbol&#39;;font-size:13.888888359069824px">formula in</span><span style="color:rgb(51,51,51);font-family:&#39;Helvetica Neue&#39;,Helvetica,&#39;Segoe UI&#39;,Arial,freesans,sans-serif,&#39;Apple Color Emoji&#39;,&#39;Segoe UI Emoji&#39;,&#39;Segoe UI Symbol&#39;;font-size:13.888888359069824px"> </span><a href="https://github.com/Homebrew/homebrew-versions" style="font-family:&#39;Helvetica Neue&#39;,Helvetica,&#39;Segoe UI&#39;,Arial,freesans,sans-serif,&#39;Apple Color Emoji&#39;,&#39;Segoe UI Emoji&#39;,&#39;Segoe UI Symbol&#39;;font-size:13.888888359069824px;background-color:transparent;color:rgb(64,120,192);text-decoration:none">homebrew/versions</a><span style="color:rgb(51,51,51);font-family:&#39;Helvetica Neue&#39;,Helvetica,&#39;Segoe UI&#39;,Arial,freesans,sans-serif,&#39;Apple Color Emoji&#39;,&#39;Segoe UI Emoji&#39;,&#39;Segoe UI Symbol&#39;;font-size:13.888888359069824px">, if anyone is interested.</span></div><div><font color="#333333" face="Helvetica Neue, Helvetica, Segoe UI, Arial, freesans, sans-serif, Apple Color Emoji, Segoe UI Emoji, Segoe UI Symbol"><span style="font-size:14px"><br></span></font></div><div><font color="#333333" face="Helvetica Neue, Helvetica, Segoe UI, Arial, freesans, sans-serif, Apple Color Emoji, Segoe UI Emoji, Segoe UI Symbol"><span style="font-size:14px"><a href="https://github.com/Homebrew/homebrew-versions/pull/1077" class="issue-link" title="webkitgtk 2.4.9 (new formula)" style="color:rgb(64,120,192);font-family:&#39;Helvetica Neue&#39;,Helvetica,&#39;Segoe UI&#39;,Arial,freesans,sans-serif,&#39;Apple Color Emoji&#39;,&#39;Segoe UI Emoji&#39;,&#39;Segoe UI Symbol&#39;;font-size:14px;background-color:transparent;text-decoration:none">Homebrew/homebrew-versions#1077</a><br></span></font></div><div><font color="#333333" face="Helvetica Neue, Helvetica, Segoe UI, Arial, freesans, sans-serif, Apple Color Emoji, Segoe UI Emoji, Segoe UI Symbol"><span style="font-size:14px"><br></span></font><span><p style="margin-top:0px;margin-bottom:16px;color:rgb(51,51,51);font-family:&#39;Helvetica Neue&#39;,Helvetica,&#39;Segoe UI&#39;,Arial,freesans,sans-serif,&#39;Apple Color Emoji&#39;,&#39;Segoe UI Emoji&#39;,&#39;Segoe UI Symbol&#39;;font-size:13.888888359069824px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">It compiles functionally equivalently to <a href="https://svn.macports.org/repository/macports/trunk/dports/www/webkit-gtk/Portfile" style="background-color:transparent;color:rgb(64,120,192);text-decoration:none">the MacPorts port it was based on</a>.</p><p style="margin-top:0px;margin-bottom:16px;color:rgb(51,51,51);font-family:&#39;Helvetica Neue&#39;,Helvetica,&#39;Segoe UI&#39;,Arial,freesans,sans-serif,&#39;Apple Color Emoji&#39;,&#39;Segoe UI Emoji&#39;,&#39;Segoe UI Symbol&#39;;font-size:13.888888359069824px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">I would also love it if anyone more deeply involved with how <code style="font-family:Consolas,&#39;Liberation Mono&#39;,Menlo,Courier,monospace;font-size:11.80555534362793px;padding:0.2em 0px;margin:0px;background-color:rgba(0,0,0,0.0392157);border-top-left-radius:3px;border-top-right-radius:3px;border-bottom-right-radius:3px;border-bottom-left-radius:3px">webkitgtk</code> works, to <a href="https://github.com/eallik/homebrew-versions/commit/2cb7318b60ca5c7d067a2081fc59c95d03c517e0" style="background-color:transparent;color:rgb(64,120,192);text-decoration:none">take a look at the formula</a> and perhaps offer some constructive criticism in the form of GitHub commit review, or even new commits!</p></span></div><div><br></div><div>Erik</div><div><br></div><br><div class="gmail_quote"></div></div><div dir="ltr"><div><div class="gmail_quote"><div dir="ltr">On Wed, Dec 9, 2015 at 1:24 PM Philippe Normand &lt;<a href="mailto:philn@igalia.com" target="_blank">philn@igalia.com</a>&gt; wrote:<br></div></div></div></div><div dir="ltr"><div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">I haven’t checked the formula thoroughly but I can already report that:<div><br></div><div>- there is no need to depend on gstreamermm to enable video/webaudio support because WebKit doesn’t rely on gstreamermm but directly depends on streamer (C API) for these features</div><div>- the FFTFrame changes are wrong</div><div><br></div><div>I suggest you to either try a recent snapshot of current SVN trunk or to wait the next unstable release because quite a few patches improving (I hope) the OSX build situation have recently landed in SVN trunk.</div><div><br></div><div>Philippe</div><div><br></div><div><div><blockquote type="cite"></blockquote></div></div></div><div style="word-wrap:break-word"><div><div><blockquote type="cite"><div>On 09 Dec 2015, at 12:13, Erik Allik &lt;<a href="mailto:eallik@gmail.com" target="_blank">eallik@gmail.com</a>&gt; wrote:</div><br></blockquote></div></div></div><div style="word-wrap:break-word"><div><div><blockquote type="cite"><div><div dir="ltr">Hi!<div><br></div><div>I recently stumbled upon the need to build webkitgtk-2.4.9 on OS X (as that is the last version with which the Cabal package webkitgtk3 seems to build with). There was only 2.10.4 in Homebrew, however there was a working 2.4.9 in MacPorts. The MacPorts version however uses a version of iconv which prevents me from compiling Homebrew stuff against the that webkitgtk-2.4.9, so I ended up developing a Homebrew webkitgtk-2.4.9 formula.</div><div><br></div><div>I&#39;ve gotten past most obstacles; I&#39;m applying all but one (seemingly irrelevant) patch from the port, and using the same or almost the same flags for configuring and building, but I&#39;m not entirely sure everything&#39;s as it&#39;s supposed to be. In any case, when calling `make install` or `make V=1` (the macport seems to call `gmake V=1`, but the `make` on my system already seems to be GNU&#39;s), after quite a bit of waiting I get:</div><div><br></div><div><span><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(255,255,255);background-color:rgb(7,24,6)"><span style="color:#9c9aff">==&gt;</span> Downloading <a href="http://webkitgtk.org/releases/webkitgtk-2.4.9.tar.xz" target="_blank">http://webkitgtk.org/releases/webkitgtk-2.4.9.tar.xz</a></div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">Already downloaded: /Library/Caches/Homebrew/webkitgtk249-2.4.9.tar.xz</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(255,255,255);background-color:rgb(7,24,6)"><span style="color:#9c9aff">==&gt;</span> Patching</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">patching file Source/WebCore/platform/text/TextCodecUTF8.h</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">patching file Source/WTF/wtf/Assertions.h</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">patching file Source/WebCore/platform/audio/FFTFrame.h</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">patching file Source/WTF/wtf/FastMalloc.cpp</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">patching file Source/WTF/wtf/Platform.h</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">patching file Source/JavaScriptCore/GNUmakefile.am</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">patching file Source/autotools/FindDependencies.m4</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">Hunk #1 succeeded at 104 with fuzz 2 (offset -4 lines).</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">patching file Source/WebCore/plugins/PluginView.cpp</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">patching file Source/WebCore/plugins/PluginView.h</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">patching file Source/WebCore/<a href="http://gnumakefile.list.am/" target="_blank">GNUmakefile.list.am</a></div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">patching file Source/JavaScriptCore/API/JSBasePrivate.h</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">patching file Source/JavaScriptCore/API/JSContextRef.h</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">patching file Source/JavaScriptCore/API/JSContextRefPrivate.h</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">patching file Source/JavaScriptCore/API/JSObjectRef.h</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">patching file Source/JavaScriptCore/API/JSValueRef.h</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">patching file Source/JavaScriptCore/offlineasm/offsets.rb</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">Hunk #1 succeeded at 108 with fuzz 1 (offset -1 lines).</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">-ftemplate-depth=256</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">-ftemplate-depth=256 -Wno-c++11-extensions</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(255,255,255);background-color:rgb(7,24,6)"><span style="color:#9c9aff">==&gt;</span> ./configure --enable-dependency-tracking --disable-webkit2 --enable-svg --disable-geolocation --disable-jit --enable-x11-target=no --enable-quartz-target=yes --enable-wayland-target=no --enable-introspection --prefix=/usr/local/Cellar/webkitgtk249/2.4.9 --disable-webgl --disable-web-audio --disable-video</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(255,255,255);background-color:rgb(7,24,6)"><span style="color:#9c9aff">==&gt;</span> make V=1</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">Last 15 lines from /Users/erik/Library/Logs/Homebrew/webkitgtk249/02.make:</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextGL.cpp:103:44: error: cannot initialize a parameter of type &#39;WebCore::GraphicsLayerClient *&#39; with an rvalue of type &#39;WebKit::AcceleratedCompositingContext *&#39;</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">    m_rootLayer = GraphicsLayer::create(0, this);</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">                                           ^~~~</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">./Source/WebCore/platform/graphics/GraphicsLayer.h:231:93: note: passing argument to parameter here</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">    static std::unique_ptr&lt;GraphicsLayer&gt; create(GraphicsLayerFactory*, GraphicsLayerClient*);</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">                                                                                            ^</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextGL.cpp:108:60: error: cannot initialize a parameter of type &#39;WebCore::GraphicsLayerClient *&#39; with an rvalue of type &#39;WebKit::AcceleratedCompositingContext *&#39;</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">    m_nonCompositedContentLayer = GraphicsLayer::create(0, this);</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">                                                           ^~~~</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">./Source/WebCore/platform/graphics/GraphicsLayer.h:231:93: note: passing argument to parameter here</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">    static std::unique_ptr&lt;GraphicsLayer&gt; create(GraphicsLayerFactory*, GraphicsLayerClient*);</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">                                                                                            ^</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">4 errors generated.</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">make[1]: *** [Source/WebKit/gtk/WebCoreSupport/libwebkitgtk_3_0_la-AcceleratedCompositingContextGL.lo] Error 1</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">make: *** [all] Error 2</div><div><br></div></span></div><div>If there&#39;s anyone on this mailing list that could potentially help me diagnose and solve the issue, that would be really appreciated!</div><div><br></div><div>The Homebrew formula I&#39;m developing can be seen here; the code should be self-explanatory:</div><div>* <a href="http://lpaste.net/8783617611091935232" target="_blank">http://lpaste.net/8783617611091935232</a></div><div><br></div><div>The MacPorts port I&#39;m basing off of is here; the Tcl code is slightly hard to read for anyone not used to Tcl (incl. myself) but it should give an idea of a successful compilation of webkitgtk-2.4.9 can be achieved on OS X:</div><div>* <a href="https://svn.macports.org/repository/macports/trunk/dports/www/webkit-gtk/Portfile" target="_blank">https://svn.macports.org/repository/macports/trunk/dports/www/webkit-gtk/Portfile</a></div><div><br></div><div>— I&#39;m really not seeing what I&#39;m missing; there must be something in the Portfile that is causing the compilation to succeed there, and not in my formula, but it&#39;s not something obvious to me.</div><div><br></div><div>Best regards,</div><div>Erik Allik</div></div></div></blockquote></div></div></div><div style="word-wrap:break-word"><div><div><blockquote type="cite"><div>
_______________________________________________<br>webkit-gtk mailing list<br><a href="mailto:webkit-gtk@lists.webkit.org" target="_blank">webkit-gtk@lists.webkit.org</a><br><a href="https://lists.webkit.org/mailman/listinfo/webkit-gtk" target="_blank">https://lists.webkit.org/mailman/listinfo/webkit-gtk</a><br></div></blockquote></div><br></div></div></blockquote></div></div></div></div>