<div dir="ltr">Hi Philippe and thanks for pointing out the 2 issues! <div><br></div><div>Last I checked it appeared audio/video did not compile without gstreamermm; the gstreamer package didn't provide any `.pc` files; as soon as I added `gstreamermm`, it started compiling. But audio/video had other issues, so as you can see, they are enabled conditionally, and in the run whose log I pasted, were not enabled anyway.</div><div><br></div><div>I also disabled the FFTFrame patch, which you said was wrong, however the same compilation error still occurs. I'm now trying to monitor how the MacPorts port does the compilation, using `--verbose`, and possibly extract the right way and put that in the Homebrew formula.</div><div><br></div><div>However, as pointed out in the initial e-mail, I cannot use anything newer than 2.4.9 as that's what's needed by the `webkitgtk3` Cabal package — it imports header files not present in any version newer than 2.4.9. In fact, there's already a working brew formula for 2.10.4, as I said, but, again, it doesn't fit the needs of the `webkitgtk3` cabal pacakage...</div><div><br></div><div>Any help and hints are still appreciated!</div><div dir="ltr"><div><br></div><div>Erik</div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Dec 9, 2015 at 1:24 PM Philippe Normand <<a href="mailto:philn@igalia.com" target="_blank">philn@igalia.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">I haven’t checked the formula thoroughly but I can already report that:<div><br></div><div>- there is no need to depend on gstreamermm to enable video/webaudio support because WebKit doesn’t rely on gstreamermm but directly depends on streamer (C API) for these features</div><div>- the FFTFrame changes are wrong</div><div><br></div><div>I suggest you to either try a recent snapshot of current SVN trunk or to wait the next unstable release because quite a few patches improving (I hope) the OSX build situation have recently landed in SVN trunk.</div><div><br></div><div>Philippe</div><div><br></div><div><div><blockquote type="cite"></blockquote></div></div></div><div style="word-wrap:break-word"><div><div><blockquote type="cite"><div>On 09 Dec 2015, at 12:13, Erik Allik <<a href="mailto:eallik@gmail.com" target="_blank">eallik@gmail.com</a>> wrote:</div><br></blockquote></div></div></div><div style="word-wrap:break-word"><div><div><blockquote type="cite"><div><div dir="ltr">Hi!<div><br></div><div>I recently stumbled upon the need to build webkitgtk-2.4.9 on OS X (as that is the last version with which the Cabal package webkitgtk3 seems to build with). There was only 2.10.4 in Homebrew, however there was a working 2.4.9 in MacPorts. The MacPorts version however uses a version of iconv which prevents me from compiling Homebrew stuff against the that webkitgtk-2.4.9, so I ended up developing a Homebrew webkitgtk-2.4.9 formula.</div><div><br></div><div>I've gotten past most obstacles; I'm applying all but one (seemingly irrelevant) patch from the port, and using the same or almost the same flags for configuring and building, but I'm not entirely sure everything's as it's supposed to be. In any case, when calling `make install` or `make V=1` (the macport seems to call `gmake V=1`, but the `make` on my system already seems to be GNU's), after quite a bit of waiting I get:</div><div><br></div><div><span><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(255,255,255);background-color:rgb(7,24,6)"><span style="color:#9c9aff">==></span> Downloading <a href="http://webkitgtk.org/releases/webkitgtk-2.4.9.tar.xz" target="_blank">http://webkitgtk.org/releases/webkitgtk-2.4.9.tar.xz</a></div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">Already downloaded: /Library/Caches/Homebrew/webkitgtk249-2.4.9.tar.xz</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(255,255,255);background-color:rgb(7,24,6)"><span style="color:#9c9aff">==></span> Patching</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">patching file Source/WebCore/platform/text/TextCodecUTF8.h</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">patching file Source/WTF/wtf/Assertions.h</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">patching file Source/WebCore/platform/audio/FFTFrame.h</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">patching file Source/WTF/wtf/FastMalloc.cpp</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">patching file Source/WTF/wtf/Platform.h</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">patching file Source/JavaScriptCore/GNUmakefile.am</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">patching file Source/autotools/FindDependencies.m4</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">Hunk #1 succeeded at 104 with fuzz 2 (offset -4 lines).</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">patching file Source/WebCore/plugins/PluginView.cpp</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">patching file Source/WebCore/plugins/PluginView.h</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">patching file Source/WebCore/<a href="http://gnumakefile.list.am/" target="_blank">GNUmakefile.list.am</a></div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">patching file Source/JavaScriptCore/API/JSBasePrivate.h</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">patching file Source/JavaScriptCore/API/JSContextRef.h</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">patching file Source/JavaScriptCore/API/JSContextRefPrivate.h</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">patching file Source/JavaScriptCore/API/JSObjectRef.h</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">patching file Source/JavaScriptCore/API/JSValueRef.h</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">patching file Source/JavaScriptCore/offlineasm/offsets.rb</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">Hunk #1 succeeded at 108 with fuzz 1 (offset -1 lines).</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">-ftemplate-depth=256</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">-ftemplate-depth=256 -Wno-c++11-extensions</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(255,255,255);background-color:rgb(7,24,6)"><span style="color:#9c9aff">==></span> ./configure --enable-dependency-tracking --disable-webkit2 --enable-svg --disable-geolocation --disable-jit --enable-x11-target=no --enable-quartz-target=yes --enable-wayland-target=no --enable-introspection --prefix=/usr/local/Cellar/webkitgtk249/2.4.9 --disable-webgl --disable-web-audio --disable-video</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(255,255,255);background-color:rgb(7,24,6)"><span style="color:#9c9aff">==></span> make V=1</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">Last 15 lines from /Users/erik/Library/Logs/Homebrew/webkitgtk249/02.make:</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextGL.cpp:103:44: error: cannot initialize a parameter of type 'WebCore::GraphicsLayerClient *' with an rvalue of type 'WebKit::AcceleratedCompositingContext *'</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)"> m_rootLayer = GraphicsLayer::create(0, this);</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)"> ^~~~</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">./Source/WebCore/platform/graphics/GraphicsLayer.h:231:93: note: passing argument to parameter here</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)"> static std::unique_ptr<GraphicsLayer> create(GraphicsLayerFactory*, GraphicsLayerClient*);</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)"> ^</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextGL.cpp:108:60: error: cannot initialize a parameter of type 'WebCore::GraphicsLayerClient *' with an rvalue of type 'WebKit::AcceleratedCompositingContext *'</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)"> m_nonCompositedContentLayer = GraphicsLayer::create(0, this);</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)"> ^~~~</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">./Source/WebCore/platform/graphics/GraphicsLayer.h:231:93: note: passing argument to parameter here</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)"> static std::unique_ptr<GraphicsLayer> create(GraphicsLayerFactory*, GraphicsLayerClient*);</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)"> ^</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">4 errors generated.</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">make[1]: *** [Source/WebKit/gtk/WebCoreSupport/libwebkitgtk_3_0_la-AcceleratedCompositingContextGL.lo] Error 1</div><div style="margin:0px;font-size:8px;line-height:normal;font-family:Monaco;color:rgb(245,245,245);background-color:rgb(7,24,6)">make: *** [all] Error 2</div><div><br></div></span></div><div>If there's anyone on this mailing list that could potentially help me diagnose and solve the issue, that would be really appreciated!</div><div><br></div><div>The Homebrew formula I'm developing can be seen here; the code should be self-explanatory:</div><div>* <a href="http://lpaste.net/8783617611091935232" target="_blank">http://lpaste.net/8783617611091935232</a></div><div><br></div><div>The MacPorts port I'm basing off of is here; the Tcl code is slightly hard to read for anyone not used to Tcl (incl. myself) but it should give an idea of a successful compilation of webkitgtk-2.4.9 can be achieved on OS X:</div><div>* <a href="https://svn.macports.org/repository/macports/trunk/dports/www/webkit-gtk/Portfile" target="_blank">https://svn.macports.org/repository/macports/trunk/dports/www/webkit-gtk/Portfile</a></div><div><br></div><div>— I'm really not seeing what I'm missing; there must be something in the Portfile that is causing the compilation to succeed there, and not in my formula, but it's not something obvious to me.</div><div><br></div><div>Best regards,</div><div>Erik Allik</div></div></div></blockquote></div></div></div><div style="word-wrap:break-word"><div><div><blockquote type="cite"><div>
_______________________________________________<br>webkit-gtk mailing list<br><a href="mailto:webkit-gtk@lists.webkit.org" target="_blank">webkit-gtk@lists.webkit.org</a><br><a href="https://lists.webkit.org/mailman/listinfo/webkit-gtk" target="_blank">https://lists.webkit.org/mailman/listinfo/webkit-gtk</a><br></div></blockquote></div><br></div></div></blockquote></div></div>