[webkit-gtk] webkit-gtk-2.10.8 fails to compile with clang-3.8

[Franz Fellner]

On Tue, 15 Mar 2016 15:22:26 +0100, Carlos Alberto Lopez Perez <clopez at igalia.com> wrote:
> On 15/03/16 13:45, Franz Fellner wrote:
> > /var/tmp/portage/net-libs/webkit-gtk-2.10.8/work/webkitgtk-2.10.8/Source/JavaScriptCore/runtime/Options.cpp:613:67: error: use of undeclared identifier 'isnan'
> >         return (m_entry.doubleVal == other.m_entry.doubleVal) || (isnan(m_entry.doubleVal) && isnan(other.m_entry.doubleVal));
> >                                                                   ^
> > /var/tmp/portage/net-libs/webkit-gtk-2.10.8/work/webkitgtk-2.10.8/Source/JavaScriptCore/runtime/Options.cpp:613:95: error: use of undeclared identifier 'isnan'
> >         return (m_entry.doubleVal == other.m_entry.doubleVal) || (isnan(m_entry.doubleVal) && isnan(other.m_entry.doubleVal));
> > 
> > 
> > The following patch makes webkit-gtk compile fine:
> > 
> > 
> > --- Source/JavaScriptCore/runtime/Options.cpp 2016-03-15 13:35:20.559319789 +0100
> > +++ Source/JavaScriptCore/runtime/Options.cpp.new     2016-03-15 13:35:08.988320570 +0100
> > @@ -610,7 +610,7 @@
> >      case Options::Type::unsignedType:
> >          return m_entry.unsignedVal == other.m_entry.unsignedVal;
> >      case Options::Type::doubleType:
> > -        return (m_entry.doubleVal == other.m_entry.doubleVal) || (isnan(m_entry.doubleVal) && isnan(other.m_entry.doubleVal));
> > +        return (m_entry.doubleVal == other.m_entry.doubleVal) || (std::isnan(m_entry.doubleVal) && std::isnan(other.m_entry.doubleVal));
> >      case Options::Type::int32Type:
> >          return m_entry.int32Val == other.m_entry.int32Val;
> >      case Options::Type::optionRangeType:
> > 
> 
> This was already fixed in trunk by http://trac.webkit.org/changeset/194518
> 
> I already proposed this changeset for 2.10.9
> <https://trac.webkit.org/wiki/WebKitGTK/2.10.x>

Thx for the pointer!
Franz