[webkit-gtk] WebsiteDataStore API proposal for handling data

[Carlos Garcia Campos]

El lun, 22-06-2015 a las 12:41 +0200, Sergio Villar Senin escribió:
> On 22/06/15 12:29, Carlos Garcia Campos wrote:
> > So, in summary, I think we have at least the following options:
> > 
> >  a) Use a single API for all with flags like the internal API
> >  b) Use a different method for every data type
> >  c) Use different method for every group of data types
> >  d) Use a manager class for every group of data types and move
> > WebKitCookieManager too.
> > 
> > Any other option? Any other thing I haven't considered? Which one 
> > you
> > think is better?
> 
> I think a) and b) are too fine grained, not sure which use cases 
> might
> require such a level of detail. That's why I lean towards 
> implementing
> c) (option d) seems a bit overkill)
> 

From the user point of view there isn't much difference between b) and
c), it's a function call + finish for every data type. From the
implementation point of view, b) requires a bit more boilerplate, but
it makes the API more flexible in case of adding new methods for
individual data types in the future. Deciding what goes in every group
might be tricky too. So, b) is what I've done in the end, see bug 
https://bugs.webkit.org/show_bug.cgi?id=146589



> BR
> _______________________________________________
> webkit-gtk mailing list
> webkit-gtk at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-gtk
> 
-- 
Carlos Garcia Campos
http://pgp.rediris.es:11371/pks/lookup?op=get&search=0xF3D322D0EC4582C3
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: This is a digitally signed message part
URL: <https://lists.webkit.org/pipermail/webkit-gtk/attachments/20150703/7f323a2d/attachment.sig>