[webkit-gtk] File chooser signal backported to WebKit1

Mario Sanchez Prada msanchez at igalia.com
Wed May 23 14:08:34 PDT 2012


Hi Daniel,

On Wed, 2012-05-23 at 11:43 -0600, Daniel Drake wrote:
> [...]
> Thanks so much for helping out here!

You're welcome.

> I've filed https://bugs.webkit.org/show_bug.cgi?id=87283 with your
> work rolled into my initial backport.
>
> Adding the unit tests looks a bit tricky indeed. I'm also a bit
> overloaded right now but I'll do my best to find some time soon. Any
> help or advice here would be very welcome.

Great. I added a comment there with some information that I hope you
will find useful. In a nutshell, you need to implement a new unit test
in Source/WebKit/gtk/tests/testwebview.c checking all the new API with
different HTML codes. 

See https://bugs.webkit.org/show_bug.cgi?id=87283#c2 for more details on
how to do it and where to check code to start from.

Thanks,
Mario



More information about the webkit-gtk mailing list