[webkit-gtk] WebKitDOMHTMLMediaElement.cpp - 'HTMLMediaElement' is not a member of 'WebCore'

[Vellemans, Noel]

Hi,

I've been working on CROSS-Compiling WebKit-GTK (1.8.1) for an
ARM-device.

Almost everything is building fine (except for some minor details).
I've managed to get it compiled (by commenting some stuff out) but I
guess the best-solution is to solve the problem correctly.

I'm must say I'm not familiar with the WEBKIT code at all so I do not
have any clue what the real reason of these minor-problems is.

But I guess it has something to do with #ifdefs that are not in the
correct place.

And off course depending on the options you select at configure time it
might be the case that is compiling (or not compiling).

my configure options are : --with-gtk=2.0 --enable-geolocation=no

Building with these configure options fails on the following files
(these are files I needed to modify )

	/DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp
	/DerivedSources/webkit/WebKitDOMTimeRanges.cpp
	/DerivedSources/webkit/WebKitDOMTimeRanges.cpp
 

DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp: In function 'void
webkit_dom_html_media_element_set_property(GObject*, guint, const
GValue*, GParamSpec*)':
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:149:5: error:
'HTMLMediaElement' is not a member of 'WebCore'
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:149:32: error:
'coreSelf' was not declared in this scope
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:149:43: error:
'core' is not a member of 'WebKit'
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp: In function 'void
webkit_dom_html_media_element_get_property(GObject*, guint, GValue*,
GParamSpec*)':
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:234:5: error:
'HTMLMediaElement' is not a member of 'WebCore'
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:234:32: error:
'coreSelf' was not declared in this scope
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:234:43: error:
'core' is not a member of 'WebKit'
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:238:16: error:
'MediaError' is not a member of 'WebCore'
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:238:16: error:
'MediaError' is not a member of 'WebCore'
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:238:35: error:
template argument 1 is invalid
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:238:41: error:
invalid type in declaration before '=' token
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:239:51: error:
request for member 'get' in 'ptr', which is of non-class type 'int'
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:265:56: error: no
matching function for call to 'kit(WebCore::TimeRanges*)'



PS: As test run I did try to compile 1.9.2 and I was ending up into the
same errors in (WebKitDOMHTMLMediaElement.cpp ... Etc)




These are the "HACKS" I did to get it compiled. 
I know it is not be the correct solution, but I just wanted to report
them, this way it can be solved into one of the next releases.

diff --git a/DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp
b/DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp
index ab4672b..9fb956d 100644
--- a/DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp
+++ b/DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp
@@ -144,6 +144,7 @@ static void
webkit_dom_html_media_element_finalize(GObject* object)
 
 static void webkit_dom_html_media_element_set_property(GObject* object,
guint prop_id, const GValue* value, GParamSpec* pspec)  {
+#if (0) /* NVL */
     WebCore::JSMainThreadNullState state;
     WebKitDOMHTMLMediaElement* self =
WEBKIT_DOM_HTML_MEDIA_ELEMENT(object);
     WebCore::HTMLMediaElement* coreSelf = WebKit::core(self); @@
-224,11 +225,16 @@ static void
webkit_dom_html_media_element_set_property(GObject* object, guint pr
         G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);
         break;
     }
+#else
+        G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec); 
+#endif
+    
 }
 
 
 static void webkit_dom_html_media_element_get_property(GObject* object,
guint prop_id, GValue* value, GParamSpec* pspec)  {
+#if (0) /* NVL */
     WebCore::JSMainThreadNullState state;
     WebKitDOMHTMLMediaElement* self =
WEBKIT_DOM_HTML_MEDIA_ELEMENT(object);
     WebCore::HTMLMediaElement* coreSelf = WebKit::core(self); @@ -395,6
+401,10 @@ static void
webkit_dom_html_media_element_get_property(GObject* object, guint pr
         G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);
         break;
     }
+#else
+        G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec); 
+#endif
+    
 }
 
 
diff --git a/DerivedSources/webkit/WebKitDOMMediaError.cpp
b/DerivedSources/webkit/WebKitDOMMediaError.cpp
index a3cd01e..eb4ba69 100644
--- a/DerivedSources/webkit/WebKitDOMMediaError.cpp
+++ b/DerivedSources/webkit/WebKitDOMMediaError.cpp
@@ -115,6 +115,8 @@ static void
webkit_dom_media_error_set_property(GObject* object, guint prop_id,
 
 static void webkit_dom_media_error_get_property(GObject* object, guint
prop_id, GValue* value, GParamSpec* pspec)  {
+#if (0) /* NVL */
+
     WebCore::JSMainThreadNullState state;
     WebKitDOMMediaError* self = WEBKIT_DOM_MEDIA_ERROR(object);
     WebCore::MediaError* coreSelf = WebKit::core(self); @@ -128,6
+130,9 @@ static void webkit_dom_media_error_get_property(GObject*
object, guint prop_id,
         G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);
         break;
     }
+#else
+        G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);
+#endif    
 }
 
 
diff --git a/DerivedSources/webkit/WebKitDOMTimeRanges.cpp
b/DerivedSources/webkit/WebKitDOMTimeRanges.cpp
index 812cb55..929d793 100644
--- a/DerivedSources/webkit/WebKitDOMTimeRanges.cpp
+++ b/DerivedSources/webkit/WebKitDOMTimeRanges.cpp
@@ -115,6 +115,7 @@ static void
webkit_dom_time_ranges_set_property(GObject* object, guint prop_id,
 
 static void webkit_dom_time_ranges_get_property(GObject* object, guint
prop_id, GValue* value, GParamSpec* pspec)  {
+#if (0) /* NVL */
     WebCore::JSMainThreadNullState state;
     WebKitDOMTimeRanges* self = WEBKIT_DOM_TIME_RANGES(object);
     WebCore::TimeRanges* coreSelf = WebKit::core(self); @@ -128,6
+129,10 @@ static void webkit_dom_time_ranges_get_property(GObject*
object, guint prop_id,
         G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);
         break;
     }
+#else
+        G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec); 
+#endif
+    
 }