[webkit-gtk] WebKit2 zoom API

Gustavo Noronha Silva gns at gnome.org
Thu Jan 5 04:56:52 PST 2012


On Thu, 2011-12-29 at 10:02 +0100, Carlos Garcia Campos wrote:
> El jue, 29-12-2011 a las 00:31 -0800, Martin Robinson escribió:
> > I would prefer an approach that doesn't expose text-only zoom at all,
> 
> We could add a boolean parameter text_only to set_zoom_level, but I
> think it's better to use a setting because this is decision you usually
> take once and then forget about it.

I dislike the boolean parameter, since it artificially limits what we
can support. I'm in favor of only exposing one (page) zoom as a starting
point, but leaving the door open to if/when we decide supporting both at
the same time (which WebCore already does), we can just add APIs to
handle text zoom.

This is one of the very few cases where we deviated from WebKitGTK+
API-wise, btw, because of a client requirement:

http://gitorious.org/webkit-clutter/webkit-clutter/blobs/master/Source/WebKit/gobject/webkit/webkitwebframe.cpp#line400

Cheers,
-- 
Gustavo Noronha Silva <gns at gnome.org>
GNOME Project



More information about the webkit-gtk mailing list