[webkit-gtk] Implement runOpenPanel in WebKit2GTK+

Mario Sanchez Prada msanchez at igalia.com
Tue Feb 14 09:36:31 PST 2012

On Tue, 2012-02-14 at 08:37 -0800, Martin Robinson wrote:
> On Tue, Feb 14, 2012 at 1:14 AM, Mario Sanchez Prada
> <msanchez at igalia.com> wrote:
> > I had the same doubt yesterday, but Carlos convinced me with the
> > rationale we explained above. However, if we agree consistency is
> > important I think I would vote for a GSList, since it's probably more
> > GNOME-ish than a simple gchar**. Not an strong opinion ,though
> I think NULL terminated gchar** and GSList are both used in diferent
> places around GNOME, but using a GSList* everywhere certainly seems
> more consistent. :)

Sure. I just meant that GSList is a GNOME thing (as it comes with GLib)
and so that's why _I_ see it as more GNOME-ish. But it's true that GNOME
is full of places where gchar** is used, no trying to say the opposite.

Anyway, I agree with the consistency related concerns. I will change the
patch when I finish working on the unit test I'm writing right now.


More information about the webkit-gtk mailing list