[webkit-gtk] Implement runOpenPanel in WebKit2GTK+

Martin Robinson mrobinson at webkit.org
Mon Feb 13 10:17:39 PST 2012

On Mon, Feb 13, 2012 at 10:06 AM, Mario Sanchez Prada
<msanchez at igalia.com> wrote:

> As you can see I added an _accepted_mime_types() function besides the
> one suggested by Carlos (_get_file_filter()), because I thought under
> some scenarios it could be interesting to have easy access to the list
> of accepted mime types (as in an array of char*), and extracting that
> list from a GtkFileFilter instance is not trivial at all.

I think that's a good idea. Part of the reason for implementing this
signal is to allow embedders to create their own custom file choosers.
This seems to be a requirement for Sugar.

I notice that these methods often return NULL terminated arrays of
gchar*, but one method accepts a GSList*. Would it make sense to use
NULL terminated arrays or GLists everywhere or is there a compelling
reason why a GList is better in only some places?


More information about the webkit-gtk mailing list