[webkit-gtk] WebKit2 zoom API (II)

[Carlos Garcia Campos]

El vie, 03-02-2012 a las 12:29 -0200, Gustavo Noronha Silva escribió:
> > I also don't remember any use case mentioned in the other thread other
> > than people saying some client had requested it. Perhaps my memory is
> > failing me, but if there are valid use cases it would be useful to
> > hear them.
> 
> That would be me. I really don't have any good reasons to give except
> that some designers asked for it, indeed, so I guess we shouldn't worry
> too much and if it turns out that some people need it they can modify
> the behaviour for their specific project/device/whatever, or hopefully
> the C API will not be thrown away =)

Maybe they really wanted the behaviour I'm proposing? being able to use
text or page zoom directly from the API but using one resets the other?
I've seen that in an app using webkit1, they always called
set_full_content_zoom before set_zoom_level in both text and page zoom
methods.

> > Unfortunately I think that still would count as an API break. Changing
> > how the API behaves is an API break, even if your application still
> > compiles. So it's not as safe as you make it sound, IMHO. Considering
> > that I'm not really sure that it's worth it to change the current API,
> > if I'm understanding things correctly.
> 
> I agree. Changing the behaviour after the fact would not do good for our
> API stability promise =).

Of course, as I said, I meant before the stable release, so there's no
API stability promise. I'm just trying to unblock this :-)

>  If we aren't going to support setting both
> zooms independently I see little value in having different functions for
> that, I think that the setting and a single pair of zoom functions like
> we have currently is a much cleaner API for what we want to support.

Ok, in that cases current patches are still valid, reviews are
welcome :-P

[GTK] Add zoom-text-only setting to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=75249 

[GTK] Use text or page zoom factor in WebKitWebView depending on
zoom-text-only 
https://bugs.webkit.org/show_bug.cgi?id=75252 

[GTK] Implement zoom in/out in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=75253

> Cheers,
> 

-- 
Carlos Garcia Campos
http://pgp.rediris.es:11371/pks/lookup?op=get&search=0xF3D322D0EC4582C3
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.webkit.org/pipermail/webkit-gtk/attachments/20120206/50e8924c/attachment.bin>