[webkit-gtk] WebKitGtk-1.9.6 with MSYS/MinGW

[Martin Schlemmer]

Hi,

Attached is the patches I used to get WebKit1 to build and run with MSYS/MinGW. I know the format is not as required, but I would appreciate some feedback about correctness and possibility of inclusion before logging bugs.

Also, it might be useful for other people, as some of this also applies when building 1.8.2 with MinGW.

One issue for example is if I should use OS_WIN32 or TARGET_WIN32 for the makefile bits ...

- webkit-1.9.6-fix-ICU-call.patch

I do not use ICU, so replace the call to ubrk_close() with delete().
It seems this might be a type-o anyhow, as there is a ICU implementation, and the iterator was allocated with new().

- webkit-1.9.6-missing-glib-depends.patch

LLIntOffsetsExtractor fails to build due to missing Glib cflags/libs.

- webkit-1.9.6-win32-GI-fixes.patch

On Win32 having the annotation for the generated DOM code in the headers do not work, so move the annotations to the source files. TBH, I am a bit unsure why this is the case, as I assume it works fine on Linux - might still be some corner case issues with G-I on Win32.
Also, we have to add the 'lib' prefix and version suffix of the needed DLLs as arguments of --library, else the G-I fails to locate the DLL when trying to use the generated Typelib.

- webkit-1.9.6-win32-casts.patch

Most of the bits in this patch are from openSUSE factory's 1.8.1 patch, except for the 1.9.x bits.
Basically fix errors due to not explicitly casting from/to UChar and WCHAR.

- webkit-1.9.6-win32-disable-broken.patch

Many of the WebKit1 test and DumpRenderTree do not build on Win32, so disable them for now.
This should probably rather be fixed by fixing the actual problems.

- webkit-1.9.6-win32-missing-header.patch

DIBPixelData.h is missing from the dist tarball causing build on Win32 to fail.
Add it back to WebCore/GNUmakefile.list.am.

- webkit-1.9.6-win32-missing-symbols.patch

Due to what seems to be a type-o, the test that defines WEBCORE_IS_LINKED_IN_SAME_BINARY checks for BUILDING_WebKit instead of BUILDING_WEBKIT.
This causes WEBCORE_TESTING to be defined as '__declspec(dllimport)' instead of dllexport, and ends in failure to link libwebkit due to missing __imp_* symbols from FrameDestructionObserver.

- webkit-1.9.6-wk2-tests.patch

Disable building of WebKit2 tests when building WebKit1.



Regards,
Martin



Vrywaringsklousule / Disclaimer:  http://www.nwu.ac.za/it/gov-man/disclaimer.html 

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: webkit-1.9.6-fix-ICU-call.patch
URL: <http://lists.webkit.org/pipermail/webkit-gtk/attachments/20120810/9802fba4/attachment-0008.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: webkit-1.9.6-missing-glib-depends.patch
URL: <http://lists.webkit.org/pipermail/webkit-gtk/attachments/20120810/9802fba4/attachment-0009.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: webkit-1.9.6-win32-casts.patch
URL: <http://lists.webkit.org/pipermail/webkit-gtk/attachments/20120810/9802fba4/attachment-0010.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: webkit-1.9.6-win32-disable-broken.patch
URL: <http://lists.webkit.org/pipermail/webkit-gtk/attachments/20120810/9802fba4/attachment-0011.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: webkit-1.9.6-win32-GI-fixes.patch
URL: <http://lists.webkit.org/pipermail/webkit-gtk/attachments/20120810/9802fba4/attachment-0012.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: webkit-1.9.6-win32-missing-header.patch
URL: <http://lists.webkit.org/pipermail/webkit-gtk/attachments/20120810/9802fba4/attachment-0013.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: webkit-1.9.6-win32-missing-symbols.patch
URL: <http://lists.webkit.org/pipermail/webkit-gtk/attachments/20120810/9802fba4/attachment-0014.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: webkit-1.9.6-wk2-tests.patch
URL: <http://lists.webkit.org/pipermail/webkit-gtk/attachments/20120810/9802fba4/attachment-0015.ksh>