[webkit-gtk] [PATCH] Fix build problem on win32

[Josip]

Jan Michael Alonzo wrote:
> On Wed, Oct 21, 2009 at 3:38 AM, Phil Longstaff <plongstaff at rogers.com 
> <mailto:plongstaff at rogers.com>> wrote:
> 
>     I've attached a patch for WebKit/gtk/webkit/webkitdownload.cpp which
>     fixes a build problem on win32. The symbol "ERROR" is already
>     #defined, so to fix this, I changed "ERROR" to "SIGNAL_ERROR" in the
>     enum.
> 
> 
> 
> Hi Phil
> 
> Where is ERROR defined in win32? I suggest you file a bug in 
> bugs.webkit.org <http://bugs.webkit.org> so we can discuss the patch. I 
> assume it would break compatibility with previous releases so would be 
> nice to discuss this with other WebKitGtk devs.
> 
> Regards,
> Jan
> 

Maybe:
wingdi.h:313:#define ERROR 0


without changes build fail like:

   CXX    WebKit/gtk/webkit/libwebkit_1_0_la-webkitdownload.lo
In file included from 
/home/jole/mingw32/include/glib-2.0/glib/gi18n-lib.h:25,
                  from 
../webkit-1.1.15.3/WebKit/gtk/webkit/webkitdownload.cpp:24:
/home/jole/mingw32/include/libintl.h:91:25: warning: "__APPLE_CC__" is 
not defined
/home/jole/mingw32/include/libintl.h:113:24: warning: "__APPLE_CC__" is 
not defined
In file included from /home/jole/mingw32/include/libintl.h:313,
                  from 
/home/jole/mingw32/include/glib-2.0/glib/gi18n-lib.h:25,
                  from 
../webkit-1.1.15.3/WebKit/gtk/webkit/webkitdownload.cpp:24:
/home/jole/mingw32/include/stdio.h:213:5: warning: "__MINGW_FEATURES__" 
is not defined
../webkit-1.1.15.3/WebKit/gtk/webkit/webkitdownload.cpp:83: error: 
expected identifier before numeric constant
../webkit-1.1.15.3/WebKit/gtk/webkit/webkitdownload.cpp:83: error: 
expected '}' before numeric constant
../webkit-1.1.15.3/WebKit/gtk/webkit/webkitdownload.cpp:83: error: 
expected unqualified-id before numeric constant
../webkit-1.1.15.3/WebKit/gtk/webkit/webkitdownload.cpp:85: error: 
expected declaration before '}' token


-- 
Josip