[webkit-efl] Removal of non coordinated graphics code path from WK2 EFL

[kalyan kondapally]

+1

br,
Kalyan

On Thu, Feb 7, 2013 at 11:21 AM, Pozdnyakov, Mikhail <
mikhail.pozdnyakov at intel.com> wrote:

> Hi Kalyan,
>
> I believe the fallback code you mentioned is the part of the code path we
> are currently using (coordinated graphics code path)
> and hence should be kept.
> Preprocessor guards should go away.
>
> BR,
> Mikhail
>
> ________________________________________
> From: kalyan kondapally [kondapallykalyan at gmail.com]
> Sent: Wednesday, February 06, 2013 6:55 PM
> To: Thiago Marcos P. Santos
> Cc: Pozdnyakov, Mikhail; webkit-efl at lists.webkit.org
> Subject: Re: [webkit-efl] Removal of non coordinated graphics code path
> from WK2 EFL
>
> HI Mikhail,
>
> I like the proposal.
>
> A quick look in our code in WebKit2 folder shows that we  seem to
> interchangeably use COORDINATED_GRAPHICS and ACCELERATED_COMPOSITING. I
> guess this could be cleaned up.
>
> I saw few places where we have ACCELERATED_COMPOSITING guards with a
> fallback to software  like in EwkView::transformToScreen
>
> So, is the idea here to get rid of all these things ??
>
> Br,
> Kalyan
>
> On Wed, Feb 6, 2013 at 6:03 PM, Thiago Marcos P. Santos <
> tmpsantos at gmail.com<mailto:tmpsantos at gmail.com>> wrote:
> On Wed, Feb 6, 2013 at 5:18 PM, Pozdnyakov, Mikhail
> <mikhail.pozdnyakov at intel.com<mailto:mikhail.pozdnyakov at intel.com>> wrote:
> > Hi folks!
> >
> > I would like to know your opinion about removal of  non coordinated
> graphics code path from WK2 EFL
> > as it seems nobody is using it and keeping eye on it.
> >
> > This removal would make our code look much better without unused code
> branches and ugly
> > #if USE(ACCELERATED_COMPOSITING) , #if USE(TILED_BACKING_STORE), #if
> USE(COORDINATED_GRAPHICS)
>
> Sounds great to me. Less code == lighter maintenance burden.
> _______________________________________________
> webkit-efl mailing list
> webkit-efl at lists.webkit.org<mailto:webkit-efl at lists.webkit.org>
> https://lists.webkit.org/mailman/listinfo/webkit-efl
>
> ---------------------------------------------------------------------
> Intel Finland Oy
> Registered Address: PL 281, 00181 Helsinki
> Business Identity Code: 0357606 - 4
> Domiciled in Helsinki
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-efl/attachments/20130207/9f085035/attachment.html>