[webkit-efl] Removal of non coordinated graphics code path from WK2 EFL

[Gyuyoung Kim]

+1. There are many #ifdef macros in our code. We need to clean unneeded
#ifdef up for code readability as well as debugging. There are build breaks
when we disable some features, it has bad effects on debugging as well.

By the way, do you mean that below macros will be clean up ?

#if USE(ACCELERATED_COMPOSITING) , #if USE(TILED_BACKING_STORE), #if
USE(COORDINATED_GRAPHICS)

Cheers,
Gyuyoung

On Thu, Feb 7, 2013 at 5:49 AM, Christophe Dumez - SISA <
ch.dumez at sisa.samsung.com> wrote:

> Hi,
>
> It sounds good to me. We have so many #ifdefs currently that it decreases
> code readability.
>
> Kr,
> Christophe DUMEZ.
> ________________________________________
> From: webkit-efl-bounces at lists.webkit.org [
> webkit-efl-bounces at lists.webkit.org] on behalf of Pozdnyakov, Mikhail [
> mikhail.pozdnyakov at intel.com]
> Sent: Wednesday, February 06, 2013 17:18
> To: webkit-efl at lists.webkit.org
> Subject: [webkit-efl] Removal of non coordinated graphics code path from
> WK2    EFL
>
> Hi folks!
>
> I would like to know your opinion about removal of  non coordinated
> graphics code path from WK2 EFL
> as it seems nobody is using it and keeping eye on it.
>
> This removal would make our code look much better without unused code
> branches and ugly
> #if USE(ACCELERATED_COMPOSITING) , #if USE(TILED_BACKING_STORE), #if
> USE(COORDINATED_GRAPHICS)
>
> BR,
> Mikhail
> ---------------------------------------------------------------------
> Intel Finland Oy
> Registered Address: PL 281, 00181 Helsinki
> Business Identity Code: 0357606 - 4
> Domiciled in Helsinki
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
>
> _______________________________________________
> webkit-efl mailing list
> webkit-efl at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-efl
> _______________________________________________
> webkit-efl mailing list
> webkit-efl at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-efl
>



-- 
Gyuyoung Kim
SW Engineer, WebKit EFL
Email : gyuyoung.kim at webkit.org
Phone : +82 10 9530 0209
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-efl/attachments/20130207/8671008c/attachment.html>