[webkit-efl] Why don't we use Eina_Bool in unit test when testing public APIs ?
gyuyoung at gmail.com
Mon Sep 24 07:40:17 PDT 2012
Yes, I also think there is no strong rule for this. I think we're able to
decide this. Nevertheless, I still think Eina_Bool is reasonable from the
API test point.
In addition, it looks GTK port also use gboolean for their unit test.
Anyway, if objection is more than agreement by tomorrow, let's decide to
use standard boolean in unit test.
On Mon, Sep 24, 2012 at 11:25 PM, Raphael Kubo da Costa
<rakuco at webkit.org>wrote:
> Gyuyoung Kim <gyuyoung at gmail.com> writes:
> > I'd like to listen EFL folks opinion. If there is no objection, I will
> > this to EFL coding style guidance.
> I don't personally have a strong opinion on this, but tend to favor the
> approach of avoiding using Eina_Bool whenever possible.
> > However, in my humble opinion, it would be good to use Eina_Bool in unit
> > test when we test public APIs. Because EFL application will use Eina_Bool
> > instead of standard boolean.
> That doesn't look like a very strong reason to me; the tests are not
> part of the public API, so there should be no harm in using standard
> bool types there.
> Intel Finland Oy
> Registered Address: PL 281, 00181 Helsinki
> Business Identity Code: 0357606 - 4
> Domiciled in Helsinki
> webkit-efl mailing list
> webkit-efl at lists.webkit.org
SW Engineer, WebKit EFL
Email : gyuyoung.kim at webkit.org
Phone : +82 10 9530 0209
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the webkit-efl