[webkit-efl] Removing ewk_{init, shutdown}'s duplicated works with RunLoopEfl.cpp

[Dumez, Christophe]

Kangil, I don't understand your point. As Eunmi said, it makes more sense
to do the Ewk initialization in ewk_context.

Doing the Ewk initialization in ewk_view may be problematic because the
client can create a ewk_context before creating a ewk_view.
However, it is impossible to construct a ewk_view without a ewk_context
being constructed first. The ewk_view constructor will start by creating a
ewk_context if it is not provided with one.

Kr,

On Mon, Sep 24, 2012 at 10:20 AM, Kangil Han <kangil.han at samsung.com> wrote:

>  I vote to ‘by contructing a view’!****
>
> ** **
>
> *From:* Dumez, Christophe [mailto:christophe.dumez at intel.com]
> *Sent:* Monday, September 24, 2012 4:07 PM
> *To:* eunmi15.lee at samsung.com
> *Cc:* 한강일; webkit-efl at lists.webkit.org
> *Subject:* Re: Re: [webkit-efl] Removing ewk_{init, shutdown}'s
> duplicated works with RunLoopEfl.cpp****
>
> ** **
>
> ** **
>
> On Mon, Sep 24, 2012 at 9:12 AM, EunMi Lee <eunmi15.lee at samsung.com>
> wrote:****
>
> Dear Chris and webkit-efl folks,
>
> I've got your point and we have no reason to rely on RunLoop to do the
> initialization.
> We just need "location" to do initialization for EFL.
> I don't matter to use ewk_{init,shutdown} or RunLoop, but I don't want to
> force applications to call ewk_{init, shutdown}.
> In the WK1, applications should use ewk_{init, shutdown} API but in the
> WK2 we can do that inside webkit becasue we have ewk_context which is
> careted before creating ewk_view.
>
> In conclusion, my opinions are as follows,
> - Use ewk_{init, shutdown} to do initialization. (because there is no
> reason to rely on RunLoop and we already have ewk_{init, shutdown})
> - Do not open ewk_{init, shutdown} as an API and just call in the
> ewk_context. (in order to not force applications to call them)
>
> How do you think?****
>
>
> I don't have any strong objection against moving the Ewk initialization
> code to ewk_context. It is a bit less error prone and hopefully, the client
> will not call any ewk function before a context initialized (either
> explicitly or by constructing a view).
>
> Kr,
> --
> Christophe Dumez
> Linux Software Engineer, PhD
> Intel Finland Oy - Open Source Technology Center****
>



-- 
Christophe Dumez
Linux Software Engineer, PhD
Intel Finland Oy - Open Source Technology Center
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-efl/attachments/20120924/70d90cca/attachment.html>