[webkit-efl] Removing ewk_{init, shutdown}'s duplicated works with RunLoopEfl.cpp

[EunMi Lee]

Dear Chris and webkit-efl folks,

I've got your point and we have no reason to rely on RunLoop to do the initialization.
We just need "location" to do initialization for EFL.
I don't matter to use ewk_{init,shutdown} or RunLoop, but I don't want to force applications to call ewk_{init, shutdown}.
In the WK1, applications should use ewk_{init, shutdown} API but in the WK2 we can do that inside webkit becasue we have ewk_context which is careted before creating ewk_view.

In conclusion, my opinions are as follows,
- Use ewk_{init, shutdown} to do initialization. (because there is no reason to rely on RunLoop and we already have ewk_{init, shutdown})
- Do not open ewk_{init, shutdown} as an API and just call in the ewk_context. (in order to not force applications to call them)

How do you think?

BR,
Eunmi Lee
------- Original Message -------
Sender : Dumez, Christophe<christophe.dumez at intel.com>
Date : 2012-09-21 13:54 (GMT+09:00)
Title : Re: [webkit-efl] Removing ewk_{init, shutdown}'s duplicated works with RunLoopEfl.cpp

Hi,

Why don't we go the other way around and remove the initialization code from RunLoopEfl? We already have dedicated ewk_init/shutdown functions, I don't see why we would rely on RunLoop to do the initialization for us.

Kr,
Chris.


On Fri, Sep 21, 2012 at 5:28 AM, Kangil Han <kangil.han at samsung.com> wrote:

Hi Eunmi,

I also agree with your opinion.

This would be a little bit new rule to programmers who are used to declare
initialize/finalize pattern.
However, w/o this pattern looks more clean and creative to me.

Thanks!

- Kangil Han

-----Original Message-----
From: webkit-efl-bounces at lists.webkit.org
[mailto:webkit-efl-bounces at lists.webkit.org] On Behalf Of EunMi Lee
Sent: Thursday, September 20, 2012 9:48 PM
To: webkit-efl at lists.webkit.org
Subject: [webkit-efl] Removing ewk_{init, shutdown}'s duplicated works with
RunLoopEfl.cpp

Dear webkit-efl folks,

I'm writing to discuss about ewk_{init, shutdown} that are doing duplicated
works with RunLoopEfl.cpp.
We initialize and shutdown the ecore, ecore_evas, ecore_file and edje in the
RunLoopEfl's constructor and destructor.
so, I think we can remove duplicated works from the ewk_{init, shutdown}.
The ewk_{init, shutdown} also have codes to intialize g_type and glib, and
we can move them to the RunLoopEfl.

In the WebKit2/EFL, we have WebContext which is created before creating
ewk_view and RunLoop is created when we create first WebContext.
That means we have a location to initialize and shutdown the efl libraries
that are used in the ewk - RunLoop.
so, we don't have to add ewk_{init, shutdown} API like WebKit1/EFL.
Additionally, I don't want to force applications to call ewk_{init,
shutdown} before and after using ewk.
We have no choice but to use ewk_{init, shutdown} APIs in the WebKit1/EFL,
but we can use RunLoopEfl in the WebKit2/EFL.

I've created new bug for this work, but I want to listen your opinions
before making patch.
https://bugs.webkit.org/show_bug.cgi?id=97173

BR,
Eunmi Lee
_______________________________________________
webkit-efl mailing list
webkit-efl at lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-efl

_______________________________________________
webkit-efl mailing list
webkit-efl at lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-efl




-- 
Christophe Dumez
Linux Software Engineer, PhD
Intel Finland Oy - Open Source Technology Center