[webkit-efl] Naming rules for setting APIs

[Gyuyoung Kim]

>> For EFL we don't really have plenty of different companies heavily
>> invested in it, nor another technology requiring it, thus the change
>> should be quite simple.

It looks Samsung, Intel and Profusion are interested in WebKit EFL port
now. Frankly, I'm not sure if profusion is still interested in.
Anyway, I also think we're able to change this simply.

>> And can upstreaming some more patches change that?

It is not our main job to upstream patches for WK1. But, our developer may
be able to submit patches for WK1 personally.

BTW, It looks other division of my company considers to use existing WK1
port still. So, I can't say if we drop to maintain WK1 yet.
I wonder whether you think that we can change API naming with WK1.

Cheers,
Gyuyoung.

On Wed, Oct 10, 2012 at 10:05 PM, Kenneth Rohde Christiansen <
kenneth.christiansen at gmail.com> wrote:

> For Qt it stays there because there are companies depending on
> QWidget's and so it will stay as a separate module in Qt5 to help the
> transition to the new technologies. It is not possible to add the
> exact same API to a QWidget based version of WebKit2, nor does it make
> sense to add a QWidget based version when one functional one already
> exists. Anyway, WebKit1 in Qt received like 0 changes in Source/WebKit
> beyond making sure it still builds.
>
> For EFL we don't really have plenty of different companies heavily
> invested in it, nor another technology requiring it, thus the change
> should be quite simple.
>
> So, in what cases is WebKit1 now more stable than our WebKit2 port?
> And can upstreaming some more patches change that?
>
> Kenneth
>
> On Wed, Oct 10, 2012 at 2:59 PM, Gyuyoung Kim <gyuyoung at gmail.com> wrote:
> >>> 1) should we change WK1 API (ewk_view.h) as it doesn't follow this
> rule?
> >
> > There are some talk before about maintaining WK1. Frankly, I'm not sure
> if
> > we need to maintain WK1. However, IMO, we need to take care of the WK1
> until
> > we remove it in trunk.
> > At least, I think we have to keep WK1 until WK2 is stable or used for
> > commercial product. It looks other ports are maintaining WK1 as well.
> > Therefore, it would be good if you change
> > WK1 according to this rule, IMO.
> >
> > I hope we won't modify API after this change. Almost person don't like to
> > change API frequently. Any other opinion ?
> >
> > Gyuyoung.
> >
> > On Wed, Oct 10, 2012 at 9:16 PM, Grzegorz Czajkowski
> > <g.czajkowski at samsung.com> wrote:
> >>
> >> Hi,
> >>
> >> IMHO Kubo's suggestion is the strongest. If we approve this convention
> >> what
> >> will happen for the current API, for both wk1 and wk2? As I result:
> >> 1) should we change WK1 API (ewk_view.h) as it doesn't follow this rule?
> >> 2) for WK2 we can land patch Jinwoo's patch
> >> (https://bugs.webkit.org/show_bug.cgi?id=98793)
> >> 3) spelling API should be adjusted - ewk_text_checker_settings.h. I will
> >> take of it.
> >>
> >> Regards,
> >> Grzegorz
> >>
> >> -----Original Message-----
> >> From: webkit-efl-bounces at lists.webkit.org
> >> [mailto:webkit-efl-bounces at lists.webkit.org] On Behalf Of Raphael Kubo
> da
> >> Costa
> >> Sent: 10 October 2012 13:43
> >> To: webkit-efl at lists.webkit.org
> >> Subject: Re: [webkit-efl] Naming rules for setting APIs
> >>
> >> "Michal G." <guziemic.spam at gmail.com> writes:
> >>
> >> > Hi,
> >> >
> >> > If I can add something to discussion, from API user perspective I
> >> > prefer such naming convention
> >> >
> >> > ewk_settings_enable_frame_flattening_set
> >> >
> >> > then
> >> > ewk_settings_frame_flattening_enabled_set
> >>
> >> It makes sense if you come from a, let's say, sane library background
> >> :-)
> >>
> >> For some reason, the EFL themselves use this Yoda-like convention for
> >> their
> >> calls, so we should probably follow that as well.
> >>
> >> --
> >> Intel Finland Oy
> >> Registered Address: PL 281, 00181 Helsinki Business Identity Code:
> 0357606
> >> -
> >> 4 Domiciled in Helsinki
> >>
> >> _______________________________________________
> >> webkit-efl mailing list
> >> webkit-efl at lists.webkit.org
> >> http://lists.webkit.org/mailman/listinfo/webkit-efl
> >>
> >>
> >> _______________________________________________
> >> webkit-efl mailing list
> >> webkit-efl at lists.webkit.org
> >> http://lists.webkit.org/mailman/listinfo/webkit-efl
> >
> >
> >
> >
> > --
> > Gyuyoung Kim
> > SW Engineer, WebKit EFL
> > Email : gyuyoung.kim at webkit.org
> > Phone : +82 10 9530 0209
> >
> >
> > _______________________________________________
> > webkit-efl mailing list
> > webkit-efl at lists.webkit.org
> > http://lists.webkit.org/mailman/listinfo/webkit-efl
> >
>
>
>
> --
> Kenneth Rohde Christiansen
> Senior Engineer, WebKit, Qt, EFL
> Phone  +45 4093 0598 / E-mail kenneth at webkit.org
>
> ﹆﹆﹆
>



-- 
Gyuyoung Kim
SW Engineer, WebKit EFL
Email : gyuyoung.kim at webkit.org
Phone : +82 10 9530 0209
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-efl/attachments/20121011/29cb3d7c/attachment.html>