[webkit-efl] Porting MiniBrowser to Elementary

Kangil Han kangil.han at samsung.com
Wed Oct 10 00:25:07 PDT 2012


Hi Kenneth~

I don't understand fully what you meant. :-)

Did you mean web module in elementary library?
AFAIK, WK2-EFL doesn't have elm webview.

Kind regards,
Kangil

-----Original Message-----
From: webkit-efl-bounces at lists.webkit.org [mailto:webkit-efl-bounces at lists.webkit.org] On Behalf Of Kenneth Rohde Christiansen
Sent: Wednesday, October 10, 2012 4:10 PM
To: Gyuyoung Kim
Cc: antognolli at profusion.mobi; webkit-efl at lists.webkit.org; demarchi at webkit.org; Leandro Pereira
Subject: Re: [webkit-efl] Porting MiniBrowser to Elementary

Why isn't the elm webview in WebKit as a module that will only compile
when elementary is installed?

Would that make sense?

Kenneth

On Wed, Oct 10, 2012 at 7:29 AM, Gyuyoung Kim <gyuyoung at gmail.com> wrote:
> Hi,
>
> Yes, it looks that. But, I'd like to listen opinion from profusion guys who
> maintained elm_web in elementary in order to verify this usage. Because
> there was objection to use elementary before.
> If there is no objection or no reply, I agree to land this basically.
>
> Kubo, do you agree with Christophe ?
>
> In addition, I'm not sure if we need to keep existing MiniBrowsesr without
> elementary. If we keep two browsers, there may be troublesome work.
>
> Gyuyoung.
>
>
> On Wed, Oct 10, 2012 at 2:14 PM, Kangil Han <kangil.han at samsung.com> wrote:
>>
>> > Rather, I will agree with you if you would make test browser that will
>> have more powerful functionalities with elementary.
>>
>> s/test browser/a new test browser
>>
>> -----Original Message-----
>> From: Kangil Han [mailto:kangil.han at samsung.com]
>> Sent: Wednesday, October 10, 2012 2:10 PM
>> To: 'Christophe Dumez'; 'Gyuyoung Kim'
>> Cc: 'antognolli at profusion.mobi'; 'webkit-efl at lists.webkit.org';
>> 'demarchi at webkit.org'; 'Leandro Pereira'
>> Subject: RE: [webkit-efl] Porting MiniBrowser to Elementary
>>
>> > Using Elementary and WebKit2-EFL for writing a (test) browser seems very
>> "standard" to me.
>>
>> I don't have objection on this. Why not? We can use convenient widget from
>> this.
>> But, the problem is if we add elementary dependency on MiniBrowser, there
>> is
>> no reference program in efl-wk2 for user who doesn't have elementary
>> package.
>>
>> Rather, I will agree with you if you would make test browser that will
>> have
>> more powerful functionalities with elementary.
>>
>> -----Original Message-----
>> From: webkit-efl-bounces at lists.webkit.org
>> [mailto:webkit-efl-bounces at lists.webkit.org] On Behalf Of Christophe Dumez
>> Sent: Wednesday, October 10, 2012 1:53 PM
>> To: Gyuyoung Kim
>> Cc: antognolli at profusion.mobi; webkit-efl at lists.webkit.org;
>> demarchi at webkit.org; Leandro Pereira
>> Subject: Re: [webkit-efl] Porting MiniBrowser to Elementary
>>
>> Hi,
>>
>> There is no circular dependency here:
>> - WebKit2-EFL does not depend on Elementary
>> - Elementary depends on WebKit2-EFL
>> - MiniBrowser depends on both WebKit2-EFL and Elementary
>>
>> Using Elementary and WebKit2-EFL for writing a (test) browser seems very
>> "standard" to me.
>>
>> Kr,
>> --
>> Christophe Dumez
>> Linux Software Engineer, PhD
>> Intel Finland Oy - Open Source Technology Center
>>
>>
>>
>>
>> On Oct 10, 2012, at 5:14 AM, Gyuyoung Kim <gyuyoung at gmail.com> wrote:
>>
>> > Hi,
>> >
>> > We couldn't use elementary in EFL port because WebKit will be added(or
>> > is
>> already added) as elementary sub widget. So, we couldn't use elementary
>> before because circular dependency may occur,
>> >  - https://bugs.webkit.org/show_bug.cgi?id=63966#c14
>> >  - http://docs.enlightenment.org/auto/elementary/group__Web.html
>> >
>> > I agree to use elementary in order to support winset for MiniBrowser /
>> EWebLauncher basically. However, IMO, we need to verify about this
>> dependency issue.
>> >
>> > Demarchi, Rafael and Leandro, How do you think about this usage? Do you
>> guys think this usage is fine ?
>> >
>> > Gyuyoung.
>> >
>> > On Wed, Oct 10, 2012 at 9:34 AM, Kangil Han <kangil.han at samsung.com>
>> wrote:
>> > Hi Chris,
>> >
>> >
>> >
>> > I have a concern on below change.
>> >
>> >
>> >
>> > AFAIK, elementary, especially webview, has dependency on WebKit library.
>> >
>> > So, below change will definitely incur package cross dependency.
>> >
>> >
>> >
>> > I would prefer that you have deep discussion with EFL people on this.
>> >
>> >
>> >
>> > Kind regards,
>> >
>> > Kangil
>> >
>> >
>> >
>> > From: webkit-efl-bounces at lists.webkit.org
>> [mailto:webkit-efl-bounces at lists.webkit.org] On Behalf Of Dumez,
>> Christophe
>> > Sent: Wednesday, October 10, 2012 1:43 AM
>> > To: webkit-efl at lists.webkit.org
>> > Subject: Re: [webkit-efl] Porting MiniBrowser to Elementary
>> >
>> >
>> >
>> > Hi,
>> >
>> > I uploaded the patch to:
>> > https://bugs.webkit.org/show_bug.cgi?id=98748
>> >
>> > Kr,
>> >
>> > On Tue, Oct 9, 2012 at 7:30 PM, Dumez, Christophe
>> <christophe.dumez at intel.com> wrote:
>> >
>> > Hi,
>> >
>> > I'm writing to notify WebKit2 EFL developers that I am porting
>> > MiniBrowser
>> to Elementary [1] and my patch is almost ready for review.
>> >
>> > MiniBrowser is an application and Elementary brings a lot of
>> > functionality
>> (widgets, layouts, dialogs, ...) that is extremely useful to applications.
>> > The idea is to bring Elementary as an optional dependency and build
>> MiniBrowser only if Elementary library is found.
>> >
>> > My initial patch will not add any new controls and will simply port the
>> existing code to Elementary. This will make the code simpler though the
>> use
>> of layouts and an Elementary Entry widget for the URL bar.
>> > As a side effect, the URL bar will finally supports copy / paste.
>> >
>> > In the near future, Elementary will help bring more functionality such
>> > as:
>> > - Back / Refresh / Home buttons
>> > - Alert / Prompt / Confirmation windows
>> > - Tabs
>> > - ...
>> >
>> > Please tell me if you have any feedback regarding this change.
>> >
>> > [1] http://docs.enlightenment.org/auto/elementary/index.html
>> >
>> > Kr,
>> > --
>> > Christophe Dumez
>> > Linux Software Engineer, PhD
>> > Intel Finland Oy - Open Source Technology Center
>> >
>> >
>> >
>> >
>> > --
>> > Christophe Dumez
>> > Linux Software Engineer, PhD
>> > Intel Finland Oy - Open Source Technology Center
>> >
>> >
>> > _______________________________________________
>> > webkit-efl mailing list
>> > webkit-efl at lists.webkit.org
>> > http://lists.webkit.org/mailman/listinfo/webkit-efl
>> >
>> >
>> >
>> >
>> > --
>> > Gyuyoung Kim
>> > SW Engineer, WebKit EFL
>> > Email : gyuyoung.kim at webkit.org
>> > Phone : +82 10 9530 0209
>> >
>>
>> _______________________________________________
>> webkit-efl mailing list
>> webkit-efl at lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo/webkit-efl
>>
>> _______________________________________________
>> webkit-efl mailing list
>> webkit-efl at lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo/webkit-efl
>
>
>
>
> --
> Gyuyoung Kim
> SW Engineer, WebKit EFL
> Email : gyuyoung.kim at webkit.org
> Phone : +82 10 9530 0209
>
>
> _______________________________________________
> webkit-efl mailing list
> webkit-efl at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo/webkit-efl
>



-- 
Kenneth Rohde Christiansen
Senior Engineer, WebKit, Qt, EFL
Phone  +45 4093 0598 / E-mail kenneth at webkit.org

﹆﹆﹆
_______________________________________________
webkit-efl mailing list
webkit-efl at lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-efl



More information about the webkit-efl mailing list