[webkit-efl] API Unit Tests

Thiago Marcos P. Santos tmpsantos at gmail.com
Wed Jul 18 09:10:24 PDT 2012


On Fri, Jul 13, 2012 at 1:24 AM, Thiago Marcos P. Santos <
tmpsantos at gmail.com> wrote:

> On Tue, Jul 3, 2012 at 7:56 PM, Thiago Marcos P. Santos <
> tmpsantos at gmail.com> wrote:
>
>> Hi WebKit EFL,
>>
>> Thanks to the great work done by Krzysztof at the bug 68509, we have now
>> an API Unit Test Framework for EWK.
>>
>> You can run the tests individually or all tests at once by calling the
>> runner script:
>>
>> $ ./Tools/Scripts/run-efl-tests [--debug|--release]
>>
>> The runner was integrated as a step of the build bots running tests. The
>> only thing missing now is test coverage, and I hope the EFL community can
>> work together at the meta bug tracking the missing tests [1]. I strongly
>> recommend if you are working on a test, to add as dependency to this bug to
>> give visibility to all the developers involved on the task.
>>
>> Another suggestion would be that we do not accept any
>> addition/modification to the APIs if there is no test backing the change.
>> IMO this is aligned to the WebKit best practices and can only bring
>> benefits to the port.
>>
>> [1] https://bugs.webkit.org/show_bug.cgi?id=90451
>>
>> Cheers!
>>
>
> And the unit test framework for WebKit 2 API has just landed! Let's make
> unit tests also a requirement for any new API's and changes.
>
> https://bugs.webkit.org/show_bug.cgi?id=90606
>
> Cheers,
>

Hi,

We have now WebKit2 C API and EFL API tests running on the bots [1] and
instructions for adding/running new EFL WebKit2 API tests [2].

Can we make it official that we need unit tests as acceptance criteria for
any changes/additions to EFL WebKit2 API and the WebKit2 C API?

In any case, please remember to run the tests before submitting patches. In
case of failure, the bots will turn red.

[1]
http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug/builds/2967/steps/API%20tests/logs/stdio

[2] http://trac.webkit.org/wiki/EFLWebKitTests

Cheers,
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-efl/attachments/20120718/2a01c578/attachment.html>


More information about the webkit-efl mailing list