[webkit-efl] Announcement of Coding Style Change in WebKit EFL port

Tomasz Morawski t.morawski at samsung.com
Mon Jan 9 05:39:41 PST 2012


Hi,
I see your point of view now I will make a huge patch instead of few
smaller and open a bug for that.

Best Regards,
Tomasz

> Hello Tomasz,
> 
> In order to change coding style, we permitted to land a huge patch. But, 
> if this is not simple work, let's file a master bug for this issue.
> 
> - gyuyoung.
> 
> On Mon, Jan 9, 2012 at 5:13 PM, Tomasz Morawski <t.morawski at samsung.com 
> <mailto:t.morawski at samsung.com>> wrote:
> 
>     I think it will better when whole community will change our source
>     according to new/delete operator use not by single person. Maybe it
>     will be better to create a master bug for this task? Due to that
>     remove malloc/calloc/realloc calls and replace it them by smart
>     pointers/new/delete it is not simple task to do this in single
>     patch. There will be need to make some refactorization etc.
> 
>         Hello Tomasz,
> 
> 
>         Will you replace malloc/calloc/realloc with new / delete ? If
>         you want
>         to do this, please file a bug.
> 
> 
>         Cheers,
> 
>         Gyuyoung
> 
>         ------- *Original Message* -------
> 
>         *Sender* : Tomasz Morawski<t.morawski at samsung.__com
>         <mailto:t.morawski at samsung.com>> Software
>         Engineer/Poland R&D Center-Linux (MSD)/삼성전자
> 
>         *Date* : 2012-01-04 17:55 (GMT+09:00)
> 
>         *Title* : Re: [webkit-efl] Announcement of Coding Style Change
>         in WebKit
> 
>         EFL port
> 
>         W dniu 03.01.2012 13:27, Raphael Kubo da Costa pisze:
>          > Tomasz Morawskiwrites:
>          >
>          >> W dniu 03.01.2012 12:49, Raphael Kubo da Costa pisze:
>          >>> Tomasz Morawskiwrites:
>          >>>
>          >>>> What about using new/delete operator for memory
>         allocation/free
>          >>>> everywhere inside internal implementation? For example:
>          >>>>
>          >>>> tile = static_cast(malloc(sizeof(Ewk___Tile)));
>          >>>>
>          >>>> I think it could be simpler and better to just write:
>          >>>>
>          >>>> tile = new EwkTile;
>          >>>
>          >>> That'd be really good. Plus using smart pointers wherever
>         possible :)
>          >> So, since there is general agreement for that, could we add
>         this to
>          >> EFL coding style?
>          >
>          > Sure. Could you add that to the Trac page?
>          >
>         It is done.
>         _________________________________________________
>         webkit-efl mailing list
>         webkit-efl at lists.webkit.org <mailto:webkit-efl at lists.webkit.org>
>         http://lists.webkit.org/__mailman/listinfo.cgi/webkit-__efl
>         <http://lists.webkit.org/mailman/listinfo.cgi/webkit-efl>
> 
> 
>     _________________________________________________
>     webkit-efl mailing list
>     webkit-efl at lists.webkit.org <mailto:webkit-efl at lists.webkit.org>
>     http://lists.webkit.org/__mailman/listinfo.cgi/webkit-__efl
>     <http://lists.webkit.org/mailman/listinfo.cgi/webkit-efl>
> 
> 



More information about the webkit-efl mailing list