[webkit-efl] Announcement of Coding Style Change in WebKit EFL port

Tomasz Morawski t.morawski at samsung.com
Mon Jan 2 03:25:12 PST 2012


> As you may know, I have changed the coding style of EFL port via Bug 
> 68209. This is to eliminate unnecessary difficulties
> 
> that reviewers have experienced when they review EFL bugs, due to EFL 
> specific coding style.

Hi,
I have one proposition more to discuss. Could we write into coding style
how memory allocation/free should be done? Current situation is not
clear. I have noticed two ways of memory allocation inside our WebKit
EFL port. One is for WebCore's objects where c++ operators new/delete is
used and c way for ewk's objects.

What about using new/delete operator for memory allocation/free
everywhere inside internal implementation? For example:

tile = static_cast<Ewk_Tile*>(malloc(sizeof(Ewk_Tile)));

I think it could be simpler and better to just write:

tile = new EwkTile;

Moreover, since we have changed all *.c files to *.cpp files. They are
compiled by c++ compiler now and all structures declared inside cpp
files are c++ structures.  So, it is more natural to use new/delete
operator for them now.

Best Regards,
Tomasz Morawski


More information about the webkit-efl mailing list