No subject
Wed Aug 1 07:28:53 PDT 2012
<br>
We have a great test framework: let's use it and make WebKit-EFL better=
.<br>
<br>
Kr,<br>
--<br>
Christophe Dumez<br>
Linux Software Engineer, PhD<br>
Intel Finland Oy - Open Source Technology Center<br>
<div class=3D"HOEnZb"><div class=3D"h5"><br>
<br>
<br>
<br>
On Aug 19, 2012, at 8:28 PM, "Thiago Marcos P. Santos" <<a hre=
f=3D"mailto:tmpsantos at gmail.com">tmpsantos at gmail.com</a>> wrote:<br>
<br>
> On Wed, Jul 18, 2012 at 7:10 PM, Thiago Marcos P. Santos<br>
> <<a href=3D"mailto:tmpsantos at gmail.com">tmpsantos at gmail.com</a>>=
wrote:<br>
>> On Fri, Jul 13, 2012 at 1:24 AM, Thiago Marcos P. Santos<br>
>> <<a href=3D"mailto:tmpsantos at gmail.com">tmpsantos at gmail.com</a>=
> wrote:<br>
>>><br>
>>> On Tue, Jul 3, 2012 at 7:56 PM, Thiago Marcos P. Santos<br>
>>> <<a href=3D"mailto:tmpsantos at gmail.com">tmpsantos at gmail.com=
</a>> wrote:<br>
>>>><br>
>>>> Hi WebKit EFL,<br>
>>>><br>
>>>> Thanks to the great work done by Krzysztof at the bug 6850=
9, we have now<br>
>>>> an API Unit Test Framework for EWK.<br>
>>>><br>
>>>> You can run the tests individually or all tests at once by=
calling the<br>
>>>> runner script:<br>
>>>><br>
>>>> $ ./Tools/Scripts/run-efl-tests [--debug|--release]<br>
>>>><br>
>>>> The runner was integrated as a step of the build bots runn=
ing tests. The<br>
>>>> only thing missing now is test coverage, and I hope the EF=
L community can<br>
>>>> work together at the meta bug tracking the missing tests [=
1]. I strongly<br>
>>>> recommend if you are working on a test, to add as dependen=
cy to this bug to<br>
>>>> give visibility to all the developers involved on the task=
.<br>
>>>><br>
>>>> Another suggestion would be that we do not accept any<br>
>>>> addition/modification to the APIs if there is no test back=
ing the change.<br>
>>>> IMO this is aligned to the WebKit best practices and can o=
nly bring benefits<br>
>>>> to the port.<br>
>>>><br>
>>>> [1] <a href=3D"https://bugs.webkit.org/show_bug.cgi?id=3D9=
0451" target=3D"_blank">https://bugs.webkit.org/show_bug.cgi?id=3D90451</a>=
<br>
>>>><br>
>>>> Cheers!<br>
>>><br>
>>><br>
>>> And the unit test framework for WebKit 2 API has just landed! =
Let's make<br>
>>> unit tests also a requirement for any new API's and change=
s.<br>
>>><br>
>>> <a href=3D"https://bugs.webkit.org/show_bug.cgi?id=3D90606" ta=
rget=3D"_blank">https://bugs.webkit.org/show_bug.cgi?id=3D90606</a><br>
>>><br>
>>> Cheers,<br>
>><br>
>><br>
>> Hi,<br>
>><br>
>> We have now WebKit2 C API and EFL API tests running on the bots [1=
] and<br>
>> instructions for adding/running new EFL WebKit2 API tests [2].<br>
>><br>
>> Can we make it official that we need unit tests as acceptance crit=
eria for<br>
>> any changes/additions to EFL WebKit2 API and the WebKit2 C API?<br=
>
>><br>
>> In any case, please remember to run the tests before submitting pa=
tches. In<br>
>> case of failure, the bots will turn red.<br>
>><br>
>> [1]<br>
>> <a href=3D"http://build.webkit.org/builders/EFL%20Linux%2064-bit%2=
0Debug/builds/2967/steps/API%20tests/logs/stdio" target=3D"_blank">http://b=
uild.webkit.org/builders/EFL%20Linux%2064-bit%20Debug/builds/2967/steps/API=
%20tests/logs/stdio</a><br>
>><br>
>> [2] <a href=3D"http://trac.webkit.org/wiki/EFLWebKitTests" target=
=3D"_blank">http://trac.webkit.org/wiki/EFLWebKitTests</a><br>
>><br>
>> Cheers,<br>
><br>
> Hi EWK!<br>
><br>
> Recently, when/how/where we should write API unit tests became the<br>
> central point of the comments reviewing bug 91832.<br>
><br>
> Once again, I would like to suggest to this list some best practices<b=
r>
> for the EFL port. This will avoid misunderstandings in the future:<br>
><br>
> - Every new EFL feature [1] should have unit tests verifying this feat=
ure.<br>
> - The patch adding the feature should also contain the unit tests,<br>
> minimizing the time window of having untested code in the trunk. This<=
br>
> is the preferred approach.<br>
> - Alternatively, a test can be written in a separated bug, but the<br>
> feature can only land after the test gets r+. We have enough technical=
<br>
> debts [2].<br>
><br>
> [1] Features are not just new API, but it also includes things like<br=
>
> convenience wrappers: <a href=3D"https://bugs.webkit.org/show_bug.cgi?=
id=3D94104" target=3D"_blank">https://bugs.webkit.org/show_bug.cgi?id=3D941=
04</a><br>
> [2] <a href=3D"https://bugs.webkit.org/show_bug.cgi?id=3D90451" target=
=3D"_blank">https://bugs.webkit.org/show_bug.cgi?id=3D90451</a><br>
><br>
> I would like to add these lines to the WebKitEFL wiki and make it<br>
> official. Any objections?<br>
><br>
> Cheers,<br>
> _______________________________________________<br>
> webkit-efl mailing list<br>
> <a href=3D"mailto:webkit-efl at lists.webkit.org">webkit-efl at lists.webkit=
.org</a><br>
> <a href=3D"http://lists.webkit.org/mailman/listinfo/webkit-efl" target=
=3D"_blank">http://lists.webkit.org/mailman/listinfo/webkit-efl</a><br>
<br>
_______________________________________________<br>
webkit-efl mailing list<br>
<a href=3D"mailto:webkit-efl at lists.webkit.org">webkit-efl at lists.webkit.org<=
/a><br>
<a href=3D"http://lists.webkit.org/mailman/listinfo/webkit-efl" target=3D"_=
blank">http://lists.webkit.org/mailman/listinfo/webkit-efl</a><br>
</div></div></blockquote></div><br><br clear=3D"all"><div><br></div>-- <br>=
- Gyuyoung<br>
</div>
--bcaec5523b3c04be8404c7a7dbb6--
More information about the webkit-efl
mailing list