[webkit-efl] Change C-casting with C++ casting
Gyuyoung Kim
gyuyoung.kim at samsung.com
Wed Sep 21 19:31:51 PDT 2011
Hello Lucas,
> Before looking at the patch... I think most of the casts will be
> converted to static_cast<>, but some times we will need const_cast<>
> and reinterpret_cast<>. Did you take this into consideration?
Of course, I considered it when I made a patch. I already used const_cast<>
in some functions instead of static_cast<>. I will submit this patch as
soon as
I complete this.
Thank you,
Gyuyoung Kim.
> -----Original Message-----
> From: Lucas De Marchi [mailto:lucas.demarchi at profusion.mobi]
> Sent: Thursday, September 22, 2011 11:14 AM
> To: Gyuyoung Kim
> Cc: demarchi at webkit.org; webkit-efl at lists.webkit.org
> Subject: Re: Change C-casting with C++ casting
>
> Hi Gyuyoung
>
> On Wed, Sep 21, 2011 at 10:50 PM, Gyuyoung Kim <gyuyoung.kim at samsung.com>
> wrote:
> > Hello Lucas,
> >
> > Thank you for your patch on Bug 68231. I think patch owner is going to
> > submit new patch based on
> > latest WebKit again.
> >
> > BTW, I think our next item is to replace C-casting with C++ casting
> in .cpp
> > files.
>
> Good.
>
> > (https://bugs.webkit.org/show_bug.cgi?id=68321)
> > I wonder if your script can change them automatically. If your script
> can do
> > it,
>
> No, it can't.
>
> > I think it is better to use it. But, it can't do that, I'd like to get a
> > review for attached
> > patch.
>
> Ok, I'll review it later tomorrow or after tomorrow
>
> Before looking at the patch... I think most of the casts will be
> converted to static_cast<>, but some times we will need const_cast<>
> and reinterpret_cast<>. Did you take this into consideration?
>
>
>
> Regards,
> Lucas De Marchi
More information about the webkit-efl
mailing list