[webkit-efl] About removing ewk_xxx_forward | backward_possible()

[Gyuyoung Kim]

Hello Leandro,

I file a bug for this issue.

Bug 69919 - [EFL] Remove ewk_frame APIs related to backward | forward.
https://bugs.webkit.org/show_bug.cgi?id=69919 


Cheers,
Gyuyoung.

> -----Original Message-----
> From: Gyuyoung Kim [mailto:gyuyoung.kim at samsung.com]
> Sent: Tuesday, October 11, 2011 1:38 PM
> To: 'Leandro Pereira'
> Cc: 'webkit-efl at lists.webkit.org'
> Subject: RE: [webkit-efl] About removing ewk_xxx_forward |
> backward_possible()
> 
> Hello Leandro,
> 
> Thank you for your reply. Of course, ewk_frame_back_possible is more
clear.
> But, I thought it is better to remove
> unneeded APIs for us. Ok, I won't suggest to remove the APIs.
> 
> BTW, I'm not sure if we need to have navigation APIs in ewk_frame.(e.g.
> ewk_frame_back |
> forward | navigate | back_possible | forward_possible |
navigate_possible).
> 
> Because, I don't know when application needs to navigate(back, forward)
> its page for each frame.
> It seems to me it is enough to use focused frame or main frame in
> ewk_view's APIs.
> 
> 148  Eina_Bool ewk_view_navigate(Evas_Object* o, int steps)
> 149  {
> 150      EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
> 151 -    return ewk_frame_navigate(sd->main_frame, steps);
> 152 +    EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE);
> 153 +    WebCore::Frame* focusedFrame = priv->page->focusController()-
> >focusedOrMainFrame();
> 154 +    WebCore::Page* page = focusedFrame->page();
> 155 +    if (!page->canGoBackOrForward(steps))
> 156 +        return EINA_FALSE;
> 157 +    page->goBackOrForward(steps);
> 158 +    return EINA_TRUE;
> 159  }
> 
> In addition, in my knowledge, child frames are included in a page. In
> other words,  we eventually navigate in a page
> despite we use ewk_frame APIs with each frame object.
> 
> I attach a prototype to this email. How do you think about it?
> 
> Cheers,
> Gyuyoung.
> 
> > -----Original Message-----
> > From: webkit-efl-bounces at lists.webkit.org [mailto:webkit-efl-
> > bounces at lists.webkit.org] On Behalf Of Leandro Pereira
> > Sent: Monday, October 10, 2011 9:18 PM
> > To: webkit-efl at lists.webkit.org
> > Subject: Re: [webkit-efl] About removing ewk_xxx_forward |
> > backward_possible()
> >
> > Gyuyoung
> >
> > On 10/09/2011 10:31 PM, Gyuyoung Kim wrote:
> > > The APIs are
> > > ewk_frame_back_possible(), ewk_frame_forward_possible(). I think the
> > APIs
> > > can be
> > > enough to replace by ewk_frame_navigate_possible().
> >
> >
> > I think they should remain. In the embedded, I think that code like:
> >
> >    if (ewk_frame_back_possible(f))
> >       do_stuff_that_can_only_happen_if_going_back_is_possible();
> >
> > Is more obvious than:
> >
> >    if (ewk_frame_navigate_possible(f, -1))
> >       do_stuff_that_can_only_happen_if_going_back_is_possible();
> >
> > Cheers,
> >      Leandro
> > _______________________________________________
> > webkit-efl mailing list
> > webkit-efl at lists.webkit.org
> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-efl