[webkit-efl] I'd like to refactor zoom related APIs.

Gyuyoung Kim gyuyoung.kim at samsung.com
Tue Oct 4 22:28:59 PDT 2011


> So, How do you think about ewk_{frame|view}_page_zoom_set instead of
> ewk_{frame|view}_zoom_set ?

It seems to me _page_zoom_set is more clear than _zoom_set.

Cheers,
Gyuyoung.

> -----Original Message-----
> From: Ryuan Choi [mailto:ryuan.choi at samsung.com]
> Sent: Wednesday, October 05, 2011 1:56 PM
> To: 김규영
> Cc: webkit-efl at lists.webkit.org
> Subject: Re: RE: [webkit-efl] I'd like to refactor zoom related APIs.
> 
> > I think scale_set can be replaced zoom_set. But, I'm not sure if
> scale_set
> > is more clear than zoom_set for users.
> 
> scale_set doesn't replace zoom_set, but ewk_view_zoom_set lost
> functionality of center zoom.
> This patch provide three different zoom feature, scale_set and zoom_set
> and text_zoom_set.
> 
> But, as we discussed in private channel, scale_set and zoom_set is still
> confused.
> So, How do you think about ewk_{frame|view}_page_zoom_set instead of
> ewk_{frame|view}_zoom_set ?
> 
> > In addition, it looks gtk and qt port still use zoom instead scale term.
> 
> IIRC, gtk doesn't support scalePage feature yet. you can find it from
> WebKit2.
> 
> Best Regards,
> Ryuan Choi



More information about the webkit-efl mailing list