<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div class=""><br class=""></div><div><blockquote type="cite" class=""><div class="">On Dec 19, 2018, at 9:17 PM, Maciej Stachowiak <<a href="mailto:mjs@apple.com" class="">mjs@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br class="Apple-interchange-newline"><br class=""><blockquote type="cite" class=""><div class="">On Dec 19, 2018, at 8:06 PM, Ryosuke Niwa <<a href="mailto:rniwa@webkit.org" class="">rniwa@webkit.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><div dir="ltr" class="">On Wed, Dec 19, 2018 at 1:13 PM Simon Fraser <<a href="mailto:simon.fraser@apple.com" class="">simon.fraser@apple.com</a>> wrote:<br class=""></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;">> On Dec 19, 2018, at 12:33 PM, Michael Catanzaro <<a href="mailto:mcatanzaro@igalia.com" target="_blank" class="">mcatanzaro@igalia.com</a>> wrote:<br class="">><span class="Apple-converted-space"> </span><br class="">> On Tue, Dec 18, 2018 at 9:31 PM, Darin Adler <<a href="mailto:darin@apple.com" target="_blank" class="">darin@apple.com</a>> wrote:<br class="">>> I’ve gotten used to the name AtomicString over the years, but I wouldn’t strongly object to changing it if other programmers are often confused by it’s similarity to the term “atomic operations”.<br class="">><span class="Apple-converted-space"> </span><br class="">> Well there were two other developers in the thread Ryosuke linked to who made the exact same mistake as me, so I do think the current name is problematic. A change wouldn't need to be drastic, though. I think suggestions from the old thread like "StringAtom" or "AtomString" would be unproblematic. The problem is the specific word "atomic" carries an expectation that the object be safe to access concurrently across threads without locks; I think that expectation doesn't exist if not for the "ic" at the end.<br class="">><span class="Apple-converted-space"> </span><br class="">> FWIW I've only ever heard the "interned string" terminology prior to now.<br class=""><br class="">SingletonString?<br class="">UniquedString?</blockquote></div></div></div></blockquote><blockquote type="cite" class=""><div class=""><div dir="ltr" class="" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><div class="gmail_quote"><div class=""><br class=""></div><div class="">I do like UniquedString. That conveys what AtomicString really is. SingletonString isn't so great since AtomicString table is still per thread.</div></div></div></div></blockquote><div class=""><br class=""></div><div class="">So hard to pronounce though! Why not UniqueString? It’s not quite as explicit but close enough. </div></div></div></blockquote><div><br class=""></div><div>Wouldn’t it be confusing to use <b class="">Unique</b>String type for a string that is <b class="">*common*</b> in order to save memory?</div><div><br class=""></div><div>Personally, I like the AtomString proposal as it is close to the naming we are used to and addresses the issue raised (atomic has a different meaning with threading).</div><div>Also, I had never heard of interned strings before.</div></div></body></html>