<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On May 12, 2017, at 7:49 PM, <a href="mailto:ap@webkit.org" class="">ap@webkit.org</a> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">12 мая 2017 г., в 19:38, Brian Burg <<a href="mailto:bburg@apple.com" class="">bburg@apple.com</a>> написал(а):</div><br class="Apple-interchange-newline"><div class=""><div class="Singleton" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div class=""><blockquote type="cite" class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;"><div class=""><div class="" style="font-family: Helvetica; font-size: 14px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div class="">I think that I explained it very clearly, but let me try again.</div><div class=""><br class=""></div><div class="">When there is a test failure that I need to communicate to others, I say something "please open <<a href="https://trac.webkit.org/export/216812/webkit/trunk/LayoutTests/fast/images/border.html" class="">https://trac.webkit.org/export/216812/webkit/trunk/LayoutTests/fast/images/destroyed-image-load-event.html</a>> in Safari to reproduce". That's very easy to do, and makes it very easy for others to work on the issue.</div><div class="">If your test requires complex setup, like WPT does, then I may not have the time to write up complicated steps to reproduce, or the person who gets the bug may not have the time to follow them. Those people don't have a WebKit checkout, so scripts won't help. This makes the test less effective, as problems that it finds are less likely to be addressed.</div></div></div></blockquote><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br class=""></div><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class="">If the person works on WebKit, then it seems unreasonable that they would do work without a checkout.</div></div></div></div></div></blockquote><div class=""><br class=""></div><div class="">It is correct that people who work on WebKit usually have a checkout. So I was taking about people who don't work on WebKit.</div><br class=""><blockquote type="cite" class=""><div class=""><div class="Singleton" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div class=""><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">If they don’t work on WebKit, then you could run wptserve on a machine somewhere and link to that copy. We have several servers that exist solely to host test content, it doesn’t seem like a big deal to make one of them update regularly and relaunch wptserve to pick up test harness changes.</div></div></div></div></blockquote><br class=""></div><div class="">Yes, there is a number of things one could do. Those things would work in some cases but not in others - I mentioned linking to a stable version that won't change, which is something that trac gives us for free, and it would be non-trivial to implement otherwise.</div><div class=""><br class=""></div><div class="">In practice, the best approach would be to reduce the test to a minimum that doesn't use complex harnesses before ending it over. Everyone likes minimal test cases.</div></div></div></blockquote></div><br class=""><div class="">I think WPT is becoming enough of a broad community norm that it's not unreasonable to point to a WPT server. It does seem regrettable that tests become dependent on being run through the server even when in principle they could run as local files. From what I gather, there are a lot of tests where only the paths to the test harness end up requiring the server. Doing the fixup on import seems bad to me, since it seems safer and cleaner for our WPT checkout to match WPT. But we could follow the practice of using relative URLs for self-created tests, and perhaps not even run them under the server when they don't need it.</div><div class=""><br class=""></div><div class="">For upstream, perhaps we could advocate with WPT to use relative paths to load the harness (and perhaps make sure that tests that absolutely require the server fail in a way that clearly indicates this for the tests that truly do need networking or some other facility of the WPT server).</div><div class=""><br class=""></div><div class="">Regards,</div><div class="">Maciej</div><div class=""><br class=""></div></body></html>