<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div class=""><br class=""></div>A few more coats of paint for the bike shed:<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On May 9, 2017, at 10:45 PM, Ryosuke Niwa <<a href="mailto:rniwa@webkit.org" class="">rniwa@webkit.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">On Tue, May 9, 2017 at 10:23 PM, Maciej Stachowiak <</span><a href="mailto:mjs@apple.com" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">mjs@apple.com</a><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">> wrote:</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class="apple-mail-abbreviatedContentWrapper" style="background-color: rgb(255, 255, 255); -webkit-user-select: none; font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><a class="apple-mail-expandLink" href="x-redundant-cluster-toggle://0" style="text-decoration: none; color: inherit;"></a><div class="apple-mail-topPreviewContent" style="overflow: hidden;"><a class="apple-mail-expandLink" href="x-redundant-cluster-toggle://0" style="text-decoration: none; color: inherit;"></a><blockquote type="cite" class=""><a class="apple-mail-expandLink" href="x-redundant-cluster-toggle://0" style="text-decoration: none; color: inherit;"></a><blockquote type="cite" class=""><a class="apple-mail-expandLink" href="x-redundant-cluster-toggle://0" style="text-decoration: none; color: inherit;">On May 9, 2017, at 9:07 PM, Michael Catanzaro <</a><a href="mailto:mcatanzaro@igalia.com" class="">mcatanzaro@igalia.com</a>> wrote:<br class="">On Tue, May 9, 2017 at 11:01 PM, Maciej Stachowiak <<a href="mailto:mjs@apple.com" class="">mjs@apple.com</a>> wrote:<br class=""><blockquote type="cite" class="">How about just Tests?<br class="">Or alternately, RegressionTests. But I like just plain Tests.<br class=""></blockquote>Then we should move ManualTests<br class=""></blockquote>I'd be in favor of burying this somewhere deeper. As it is, people are still adding tests here, which is kind of a disaster. These tests are very rarely run, so a manual test is often barely better than no test at all. We should also put a file in this directory strongly discouraging the addition of new manual tests IMO.<br class=""><blockquote type="cite" class="">, PerformanceTests,<br class=""></blockquote>Could be renamed Benchmarks.<br class=""></blockquote></div><div class="apple-mail-seeMoreText"></div><div class="apple-mail-bottomPreviewContent" style="overflow: hidden;"></div></div><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""><br class=""><br class=""><blockquote type="cite" class="">On May 9, 2017, at 9:07 PM, Michael Catanzaro <<a href="mailto:mcatanzaro@igalia.com" class="">mcatanzaro@igalia.com</a>> wrote:<br class=""></blockquote><br class=""><blockquote type="cite" class="">, PerformanceTests,<br class=""></blockquote><br class="">Could be renamed Benchmarks.<br class=""></blockquote><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">I'm not sure benchmarks would be a good description given that</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">directory also contains perf tests that are written to test specific</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">feature like line layout and DOM bindings.</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""></div></blockquote><div><br class=""></div><div>Those are still benchmarks (albeit microbenchmarks). But I think it would be OK to still call it "PerformanceTests", since unqualified "Tests" connotes functional tests. But "benchmark" and "performance test" are basically synonyms.</div><br class=""><blockquote type="cite" class=""><div class=""><br class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">I find it much nicer to have a separate test directory under which the</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">source code structure is mirrored such as UnitTests/WTFTests/,</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">UnitTests/WebCoreTests/, etc...</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""></div></blockquote><div><br class=""></div><div>Having UnitTests and APITests directories at top level might be better than having them under Tools/TestWebKitAPI/Tests.</div><div><br class=""></div><br class=""><blockquote type="cite" class=""><div class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">If we did add any special directories to Tests with different semantics, they could just be special directories that are peers to the others, much like the http/ directory.<br class=""><br class="">What are now called LayoutTests have the distinction (along with PerformanceTests) of being tests that can cover things up and down the stack. Most other tests could be assigned to one of the subdirectories of Source.<br class=""></blockquote><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">This is why I think IntegrationTests or FunctionalTests most</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">accurately describe these tests.</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""></div></blockquote><div><br class=""></div><div>IntegrationTests doesn't distinguish them from performance tests, or API tests. And most test integration only incidentally. FunctionalTests doesn't distinguish them from any of the other kinds of tests besides performance tests.</div><div><br class=""></div><div>I think just plain Tests is better than calling out a characteristic that isn't actually unique. It's by far the most common type of test we have, so it's ok for it to be the unmarked category.</div><div><br class=""></div><div>I also think LayoutTests is ok; it's not totally accurate but it's a historical name that most people understand at this point.</div><div><br class=""></div><div>I think the only names that are both accurate and unique are likely to be bad for autocomplete (WebTests, WebContentTests, etc).</div><div><br class=""></div></div>Regards,<div class="">Maciej</div><div class=""><br class=""></div></body></html>