<div dir="ltr"><div>Thanks Geoffrey, Alex, Yoav for the debugging pointer. I am debugging the issue further using this information and will most likely need some more help in immediate future as well.</div><div><br></div><div>Unfortunately, I don't have a stand-alone test case which can be tested with qtwebkit. I am trying to load a page using PhantomJS and it's crashing. The typical URLs which cause it to crash are <a href="http://engadget.com">http://engadget.com</a> and <a href="http://cnn.com">http://cnn.com</a> - both of these load without any issue on x86 platform though, so the issue seems to be specific to ppc64le.</div><div><br></div><div>Thanks,</div><div>Atul.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Feb 6, 2017 at 5:56 PM, Yoav Weiss <span dir="ltr"><<a href="mailto:yoav@yoav.ws" target="_blank">yoav@yoav.ws</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Atul,<div><br></div><div>I second Alex's suggestion (perhaps followed by HTMLLinkElement::process() and other places in that file that refer to `hrefAttr`).</div><div>If you have a test case online, I could try to take a look and maybe provide more guidance.</div><div><br></div><div>Cheers :)</div><span class="HOEnZb"><font color="#888888"><div>Yoav</div></font></span></div><div class="HOEnZb"><div class="h5"><br><div class="gmail_quote"><div dir="ltr">On Fri, Feb 3, 2017 at 9:19 PM Alex Christensen <<a href="mailto:achristensen@apple.com" target="_blank">achristensen@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid"><div class="m_7294105287365987gmail_msg" style="-ms-word-wrap: break-word;"><div class="m_7294105287365987gmail_msg">I would start looking at HTMLLinkElement::<wbr>parseAttribute.</div>LinkHeader.cpp contains parsers for link headers, which are related. Yoav knows more about those. Those parsers ought to be united more.<div class="m_7294105287365987gmail_msg"><br class="m_7294105287365987gmail_msg"><div class="m_7294105287365987gmail_msg"><blockquote class="m_7294105287365987gmail_msg" type="cite"></blockquote></div></div></div><div class="m_7294105287365987gmail_msg" style="-ms-word-wrap: break-word;"><div class="m_7294105287365987gmail_msg"><div class="m_7294105287365987gmail_msg"><blockquote class="m_7294105287365987gmail_msg" type="cite"><div class="m_7294105287365987gmail_msg">On Feb 3, 2017, at 1:17 AM, Atul Sowani <<a class="m_7294105287365987gmail_msg" href="mailto:sowani@gmail.com" target="_blank">sowani@gmail.com</a>> wrote:</div><br class="m_7294105287365987m_1710200479036124009Apple-interchange-newline m_7294105287365987gmail_msg"></blockquote></div></div></div><div class="m_7294105287365987gmail_msg" style="-ms-word-wrap: break-word;"><div class="m_7294105287365987gmail_msg"><div class="m_7294105287365987gmail_msg"><blockquote class="m_7294105287365987gmail_msg" type="cite"><div class="m_7294105287365987gmail_msg"><div class="m_7294105287365987gmail_msg" dir="ltr"><div class="m_7294105287365987gmail_msg">At present I am focusing on CSSParser::findURI() particularly and CSSParser::realLex() other related functionality in CSSParser.cpp - hope I am on right track. ;-)</div><div class="m_7294105287365987gmail_msg"><br class="m_7294105287365987gmail_msg"></div><div class="m_7294105287365987gmail_msg">Please let me know if I should be looking at some other functionality as well to resolve this issue.</div><div class="m_7294105287365987gmail_msg"><br class="m_7294105287365987gmail_msg"></div><div class="m_7294105287365987gmail_msg">Thanks!</div><div class="m_7294105287365987gmail_msg">Atul.</div></div><div class="gmail_extra m_7294105287365987gmail_msg"><br class="m_7294105287365987gmail_msg"><div class="gmail_quote m_7294105287365987gmail_msg">On Fri, Feb 3, 2017 at 2:33 PM, Atul Sowani <span class="m_7294105287365987gmail_msg" dir="ltr"><<a class="m_7294105287365987gmail_msg" href="mailto:sowani@gmail.com" target="_blank">sowani@gmail.com</a>></span> wrote:<br class="m_7294105287365987gmail_msg"><blockquote class="gmail_quote m_7294105287365987gmail_msg" style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid"><div class="m_7294105287365987gmail_msg" dir="ltr"><div class="m_7294105287365987gmail_msg">Hi,</div><div class="m_7294105287365987gmail_msg"><br class="m_7294105287365987gmail_msg"></div><div class="m_7294105287365987gmail_msg">I came across an issue in qtwebkit CSS parser while working on a PhantomJS crash. The issue seems to be with parsing of <link rel="..." href="..."> type elements in an HTML page. What I observed is that the parser is trying to interpret the value for href given inside double-quotes. The value contains a "-" (e.g. "<a class="m_7294105287365987gmail_msg" href="http://some.domain.com/some-page-etc-etc" target="_blank">http://some.domain.com/some-<wbr>page-etc-etc</a>"). The "-" sign is being interpreted as minus and then things go wrong. In another case I found that "\g" embedded in the value (e.g. "<a class="m_7294105287365987gmail_msg" href="http://some.domain.com/some-page/global/something" target="_blank">http://some.domain.com/some-<wbr>page/global/something</a>") is also creating issues. In essence, the parser is trying to interpret the value, which I believe, it should not.</div><div class="m_7294105287365987gmail_msg"><br class="m_7294105287365987gmail_msg"></div><div class="m_7294105287365987gmail_msg">I am willing to dive further into it to debug and fix the issue, but looking at the complexity and size of WebCore, I think I would benefit a lot to expedite a fix, if I could get some tips about which code area/functionality I should specifically focus in the WebCore. Looking forward to some help in this regard.</div><div class="m_7294105287365987gmail_msg"><br class="m_7294105287365987gmail_msg"></div><div class="m_7294105287365987gmail_msg">Thanks,</div><div class="m_7294105287365987gmail_msg">Atul.</div><div class="m_7294105287365987gmail_msg"><br class="m_7294105287365987gmail_msg"></div></div>
</blockquote></div><br class="m_7294105287365987gmail_msg"></div>
______________________________<wbr>_________________<br class="m_7294105287365987gmail_msg">webkit-dev mailing list<br class="m_7294105287365987gmail_msg"><a class="m_7294105287365987gmail_msg" href="mailto:webkit-dev@lists.webkit.org" target="_blank">webkit-dev@lists.webkit.org</a><br class="m_7294105287365987gmail_msg"><a class="m_7294105287365987gmail_msg" href="https://lists.webkit.org/mailman/listinfo/webkit-dev" target="_blank">https://lists.webkit.org/<wbr>mailman/listinfo/webkit-dev</a><br class="m_7294105287365987gmail_msg"></div></blockquote></div></div></div></blockquote></div>
</div></div></blockquote></div><br></div>