<div dir="ltr">Hi Atul,<div><br></div><div>I second Alex's suggestion (perhaps followed by HTMLLinkElement::process() and other places in that file that refer to `hrefAttr`).</div><div>If you have a test case online, I could try to take a look and maybe provide more guidance.</div><div><br></div><div>Cheers :)</div><div>Yoav</div></div><br><div class="gmail_quote"><div dir="ltr">On Fri, Feb 3, 2017 at 9:19 PM Alex Christensen <<a href="mailto:achristensen@apple.com">achristensen@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class="gmail_msg"><div class="gmail_msg">I would start looking at HTMLLinkElement::parseAttribute.</div>LinkHeader.cpp contains parsers for link headers, which are related. Yoav knows more about those. Those parsers ought to be united more.<div class="gmail_msg"><br class="gmail_msg"><div class="gmail_msg"><blockquote type="cite" class="gmail_msg"></blockquote></div></div></div><div style="word-wrap:break-word" class="gmail_msg"><div class="gmail_msg"><div class="gmail_msg"><blockquote type="cite" class="gmail_msg"><div class="gmail_msg">On Feb 3, 2017, at 1:17 AM, Atul Sowani <<a href="mailto:sowani@gmail.com" class="gmail_msg" target="_blank">sowani@gmail.com</a>> wrote:</div><br class="m_1710200479036124009Apple-interchange-newline gmail_msg"></blockquote></div></div></div><div style="word-wrap:break-word" class="gmail_msg"><div class="gmail_msg"><div class="gmail_msg"><blockquote type="cite" class="gmail_msg"><div class="gmail_msg"><div dir="ltr" class="gmail_msg"><div class="gmail_msg">At present I am focusing on CSSParser::findURI() particularly and CSSParser::realLex() other related functionality in CSSParser.cpp - hope I am on right track. ;-)</div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">Please let me know if I should be looking at some other functionality as well to resolve this issue.</div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">Thanks!</div><div class="gmail_msg">Atul.</div></div><div class="gmail_extra gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg">On Fri, Feb 3, 2017 at 2:33 PM, Atul Sowani <span dir="ltr" class="gmail_msg"><<a href="mailto:sowani@gmail.com" class="gmail_msg" target="_blank">sowani@gmail.com</a>></span> wrote:<br class="gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg"><div class="gmail_msg">Hi,</div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">I came across an issue in qtwebkit CSS parser while working on a PhantomJS crash. The issue seems to be with parsing of <link rel="..." href="..."> type elements in an HTML page. What I observed is that the parser is trying to interpret the value for href given inside double-quotes. The value contains a "-" (e.g. "<a href="http://some.domain.com/some-page-etc-etc" class="gmail_msg" target="_blank">http://some.domain.com/some-page-etc-etc</a>"). The "-" sign is being interpreted as minus and then things go wrong. In another case I found that "\g" embedded in the value (e.g. "<a href="http://some.domain.com/some-page/global/something" class="gmail_msg" target="_blank">http://some.domain.com/some-page/global/something</a>") is also creating issues. In essence, the parser is trying to interpret the value, which I believe, it should not.</div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">I am willing to dive further into it to debug and fix the issue, but looking at the complexity and size of WebCore, I think I would benefit a lot to expedite a fix, if I could get some tips about which code area/functionality I should specifically focus in the WebCore. Looking forward to some help in this regard.</div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">Thanks,</div><div class="gmail_msg">Atul.</div><div class="gmail_msg"><br class="gmail_msg"></div></div>
</blockquote></div><br class="gmail_msg"></div>
_______________________________________________<br class="gmail_msg">webkit-dev mailing list<br class="gmail_msg"><a href="mailto:webkit-dev@lists.webkit.org" class="gmail_msg" target="_blank">webkit-dev@lists.webkit.org</a><br class="gmail_msg"><a href="https://lists.webkit.org/mailman/listinfo/webkit-dev" class="gmail_msg" target="_blank">https://lists.webkit.org/mailman/listinfo/webkit-dev</a><br class="gmail_msg"></div></blockquote></div></div></div></blockquote></div>