<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>I think that this is great!</div><div id="AppleMailSignature"><br></div><div id="AppleMailSignature">I agree with the policy that we should use JSValue everywhere that it would give us the same codegen/ABI (args in registers, return in registers, etc). <br><br>-Filip</div><div><br>On Jan 3, 2017, at 14:33, Mark Lam <<a href="mailto:mark.lam@apple.com">mark.lam@apple.com</a>> wrote:<br><br></div><blockquote type="cite"><div><meta http-equiv="Content-Type" content="text/html charset=utf-8"><div class="">Over the holiday period, I looked into the possibility of giving EncodedJSValue a default constructor (because I didn’t like having to return encodedJSValue() instead of { } in lots of places), and learned why we had EncodedJSValue in the first place (i.e. for C linkage). This led me to discover (in my reading of the code) that we don’t really need to use EncodedJSValue for most of our host functions (those of type NativeFunction, GetValueFunc, and PutValueFunc). </div><div class=""><br class=""></div><div class="">I propose that we switch to using JSValue directly where we can. This has the benefit of:</div><div class="">1. better type safety with the use of JSValue (EncodedJSValue is a int64_t typedef).</div><div class="">2. more readable code (less marshaling back and forth with JSValue::encode()/decode()).</div><div class=""><br class=""></div><div class="">The patch for this change can be found here:</div><a href="https://bugs.webkit.org/show_bug.cgi?id=166658" class="">https://bugs.webkit.org/show_bug.cgi?id=166658</a><div class=""><br class=""></div><div class="">Perf is neutral. Any opinions?</div><div class=""><br class=""></div><div class="">Thanks.</div><div class=""><br class=""></div><div class="">Mark</div></div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>webkit-dev mailing list</span><br><span><a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a></span><br><span><a href="https://lists.webkit.org/mailman/listinfo/webkit-dev">https://lists.webkit.org/mailman/listinfo/webkit-dev</a></span><br></div></blockquote></body></html>