<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Jan 3, 2017 at 2:54 PM, Geoffrey Garen <span dir="ltr"><<a href="mailto:ggaren@apple.com" target="_blank">ggaren@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word">EncodedJSValue was always just a work-around to convince the compiler to put a JSValue in registers (instead of on the stack, with different compilers disagreeing about where on the stack).<div><br></div><div>I agree with removing EncodedJSValue if possible.</div><div><br></div><div>Did something change to make this possible? For example, are you sure that Windows and 32bit are OK with this change?</div></div></blockquote><div><br></div><div>Recent MSVC seems happy, 32- and 64-bit: <a href="https://godbolt.org/g/XVaDyz">https://godbolt.org/g/XVaDyz</a></div><div>Unless you had another example in mind?</div><div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word"><div><div>I don’t understand why C linkage would affect things: Either the compiler puts structs in registers or it doesn’t.</div><div><br></div><div>Geoff</div><div><div class="gmail-h5"><div><br><div><blockquote type="cite"><div>On Jan 3, 2017, at 2:44 PM, Filip Pizlo <<a href="mailto:fpizlo@apple.com" target="_blank">fpizlo@apple.com</a>> wrote:</div><br class="gmail-m_7093509938051326269Apple-interchange-newline"><div><div dir="auto"><div>I think that this is great!</div><div><br></div><div>I agree with the policy that we should use JSValue everywhere that it would give us the same codegen/ABI (args in registers, return in registers, etc). <br><br>-Filip</div><div><br>On Jan 3, 2017, at 14:33, Mark Lam <<a href="mailto:mark.lam@apple.com" target="_blank">mark.lam@apple.com</a>> wrote:<br><br></div><blockquote type="cite"><div><div>Over the holiday period, I looked into the possibility of giving EncodedJSValue a default constructor (because I didn’t like having to return encodedJSValue() instead of { } in lots of places), and learned why we had EncodedJSValue in the first place (i.e. for C linkage). This led me to discover (in my reading of the code) that we don’t really need to use EncodedJSValue for most of our host functions (those of type NativeFunction, GetValueFunc, and PutValueFunc). </div><div><br></div><div>I propose that we switch to using JSValue directly where we can. This has the benefit of:</div><div>1. better type safety with the use of JSValue (EncodedJSValue is a int64_t typedef).</div><div>2. more readable code (less marshaling back and forth with JSValue::encode()/decode()).</div><div><br></div><div>The patch for this change can be found here:</div><a href="https://bugs.webkit.org/show_bug.cgi?id=166658" target="_blank">https://bugs.webkit.org/show_<wbr>bug.cgi?id=166658</a><div><br></div><div>Perf is neutral. Any opinions?</div><div><br></div><div>Thanks.</div><div><br></div><div>Mark</div></div></blockquote><blockquote type="cite"><div><span>______________________________<wbr>_________________</span><br><span>webkit-dev mailing list</span><br><span><a href="mailto:webkit-dev@lists.webkit.org" target="_blank">webkit-dev@lists.webkit.org</a></span><br><span><a href="https://lists.webkit.org/mailman/listinfo/webkit-dev" target="_blank">https://lists.webkit.org/<wbr>mailman/listinfo/webkit-dev</a></span><br></div></blockquote></div>______________________________<wbr>_________________<br>webkit-dev mailing list<br><a href="mailto:webkit-dev@lists.webkit.org" target="_blank">webkit-dev@lists.webkit.org</a><br><a href="https://lists.webkit.org/mailman/listinfo/webkit-dev" target="_blank">https://lists.webkit.org/<wbr>mailman/listinfo/webkit-dev</a><br></div></blockquote></div><br></div></div></div></div></div><br>______________________________<wbr>_________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>
<a href="https://lists.webkit.org/mailman/listinfo/webkit-dev" rel="noreferrer" target="_blank">https://lists.webkit.org/<wbr>mailman/listinfo/webkit-dev</a><br>
<br></blockquote></div><br></div></div>