<div dir="ltr">I've now taken a separate <a href="https://bugs.webkit.org/show_bug.cgi?id=158902">approach</a>, which doesn't require changing the default in order for the IndexedDB tests to run successfully.</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jul 7, 2016 at 11:33 AM, Yoav Weiss <span dir="ltr"><<a href="mailto:yoav@yoav.ws" target="_blank">yoav@yoav.ws</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>After encountering flakiness as a result of runtime flags leaking between tests, I wrote a <a href="https://bugs.webkit.org/show_bug.cgi?id=158902" target="_blank">patch</a> that resets all feature flags to their default values between tests.<br></div><div><br></div><div>The problem I encountered was that IndexedDB was turned off by default in RuntimeEnabledFeatures, but was (and still is) manually turned on by WebView (on both mac and win) and by WebKit2. That meant that reseting it to the default value between tests caused a lot of tests to fail (as they were relying on it being on). At the same time, I'm not sure that flipping the default to true won't have an undesired impact on other ports which may have the feature turned off.</div><div><br></div><div>So, I'd love some advice on that front. Do the other ports have that feature disabled as I suspect? If so, would it be a problem to turn it on for those ports?</div><div><br></div><div>Thanks,</div><div>Yoav</div></div>
</blockquote></div><br></div>