<div dir="ltr"><div><div><div><div>Hi Rego,<br><br></div>Thank you for pointing issues out when removing gaps painting. The issues probably heads up<br></div>when gaps painting is disabled. In newline issue case, I'm able to refer to the chrome's fix. Let me check it.<br>In second issue case, although it looks there is no critical issue with new layout methods yet<br>I think I need to check it further. But the issues won't appear on port which uses gaps painting.<br></div></div><div><br><div><div><div><div><div class="gmail_extra">gyuyoung.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 3, 2016 at 10:58 PM, Manuel Rego Casasnovas <span dir="ltr"><<a href="mailto:rego@igalia.com" target="_blank">rego@igalia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi,<br>
<span class=""><br>
On 03/05/16 15:24, Gyuyoung Kim wrote:<br>
> I upload a patch to add a preference API in order to enable/disable the<br>
> selection gap painting feature.<br>
<br>
</span>BTW, this has been removed from Chrome too past year:<br>
<a href="https://groups.google.com/a/chromium.org/d/msg/blink-dev/6Iu5oIbAGbI/PsJlNvJPhfMJ" rel="noreferrer" target="_blank">https://groups.google.com/a/chromium.org/d/msg/blink-dev/6Iu5oIbAGbI/PsJlNvJPhfMJ</a><br>
<br>
Note that in the discussion they pointed to an issue that happens when<br>
you remove gaps paining, you don't know if you've selected a newlines or<br>
not: <a href="https://bugs.chromium.org/p/chromium/issues/detail?id=474759" rel="noreferrer" target="_blank">https://bugs.chromium.org/p/chromium/issues/detail?id=474759</a><br>
<span class=""><br>
> Add WKPreference for SelectionPaintingWithoutSelectionGaps<br>
> <a href="https://bugs.webkit.org/show_bug.cgi?id=156900" rel="noreferrer" target="_blank">https://bugs.webkit.org/show_bug.cgi?id=156900</a><br>
<br>
</span>As pointed out by Darin on the bug, an issue with selection gaps is what<br>
happens with the new layout methods like Flexbox and specially Grid<br>
Layout, where the visual order and the DOM order can be completely<br>
different.<br>
<br>
My 2 cents,<br>
Rego<br>
_______________________________________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>
<a href="https://lists.webkit.org/mailman/listinfo/webkit-dev" rel="noreferrer" target="_blank">https://lists.webkit.org/mailman/listinfo/webkit-dev</a><br>
</blockquote></div><br></div></div></div></div></div></div></div>