<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle20
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D">Hi,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">I’ve still been tracking memory leaks in our application, and I think I have a good test scenario to share.
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">In our application we found that a lot of memory would be held onto when visiting this particular site:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><a href="http://answers.ea.com">http://answers.ea.com</a></span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">In a loop we visit this site, and a simple html page that consists of a list of test urls found on the local hard drive.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Our in built memory tools suggest a leak is coming largely from CSSParser::parseFontFaceSrc(), though admittedly I’ve changed my top suspects from time to time. I think this item is showing as a large leak
due to the inclusion of the font in the css on the answers.ea.com page, but perhaps there are more smaller items being leaked which is just less obvious (the font is large).<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">I’ve reproduce the scenario in the WinCairo test application, based on
</span>188436<span style="color:#1F497D">. I built in a quick and hacky soak mechanism to conduct the test, perhaps there are better tools I’m not aware of. I’ve attached the source changes to this mail:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Source/WebKit/win/WebKitMessageLoop.cpp<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Tools/WinLauncher/Common.cpp<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">I can see the memory of the WinLauncher process grow over time, here is an example of the memory usage as seen from the windows task manager over time:<o:p></o:p></span></p>
<p class="MsoNormal"><b><span style="color:#1F497D">Duration Memory (reported by windows)<o:p></o:p></span></b></p>
<p class="MsoNormal"><span style="color:#1F497D">0m 155MB<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">13m 178MB<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">23m 199MB<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">36m 219MB
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">53m 247MB<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">1h4m 259MB<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">1h23m 277MB<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">After about an 1h30m, WinLauncher crashes, at the end of the mail is the basic debug data that was available.
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">I’m not sure if the crash is related to the memory leak I’m experiencing, or if it’s an unrelated issue. Since we’re a few months older from tip I’m wondering if anyone has any recent insights to share on this
memory leak scenario? I haven’t identified anything in the change logs, but perhaps there is there something already addressing this? Does the same issue occur at tip?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Any feedback is appreciated,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Thanks<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Chris Vienneau<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">+ this 0x00000000784be130 {m_fontMetrics={m_unitsPerEm=1000 m_ascent=0.000000000 m_descent=0.000000000 ...} ...} WebCore::Font *<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> ascent 0.000000000 float<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> dc Variable is optimized away and not available.
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">+ extents {x_bearing=0.00000000000000000 y_bearing=2.840573810841e-316#DEN width=1.197610077640e-309#DEN ...} cairo_text_extents_t<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> metricsMultiplier 0.031250000000000000 const double<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> faceName Variable is optimized away and not available.
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> descent 52852716.0 float<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> xHeight Variable is optimized away and not available.
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">+ textMetrics {tmHeight=0 tmAscent=0 tmDescent=1691286912 ...} tagTEXTMETRICW<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> lineGap 63069964.0 float<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> scaledFont 0x000000006477fc00 {...} _cairo_scaled_font *<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> faceLength 0 int<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">> WebKit.dll!WebCore::Font::platformInit() Line 82 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::Font::Font(const WebCore::FontPlatformData & platformData, bool isCustomFont, bool isLoading, bool isTextOrientationFallback) Line 80 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::CachedFont::createFont(const WebCore::FontDescription & fontDescription, const WTF::AtomicString & __formal, bool syntheticBold, bool syntheticItalic, bool __formal) Line 126
C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::CSSFontFaceSource::font(const WebCore::FontDescription & fontDescription, bool syntheticBold, bool syntheticItalic, WebCore::CSSFontSelector * fontSelector) Line 138 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::CSSFontFace::font(const WebCore::FontDescription & fontDescription, bool syntheticBold, bool syntheticItalic) Line 127 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::CSSSegmentedFontFace::fontRanges(const WebCore::FontDescription & fontDescription) Line 130 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::CSSFontSelector::fontRangesForFamily(const WebCore::FontDescription & fontDescription, const WTF::AtomicString & familyName) Line 474 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::realizeNextFallback(const WebCore::FontDescription & description, unsigned int & index, WebCore::FontSelector * fontSelector) Line 90 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::FontCascadeFonts::realizeFallbackRangesAt(const WebCore::FontDescription & description, unsigned int index) Line 114 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::FontCascadeFonts::determinePitch(const WebCore::FontDescription & description) Line 64 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::BreakingContext::handleText(WTF::Vector<WebCore::WordMeasurement,64,WTF::CrashOnOverflow,16> & wordMeasurements, bool & hyphenated, unsigned int & consecutiveHyphenatedLines)
Line 731 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::LineBreaker::nextLineBreak(WebCore::BidiResolver<WebCore::InlineIterator,WebCore::BidiRun> & resolver, WebCore::LineInfo & lineInfo, WebCore::RenderTextInfo & renderTextInfo,
WebCore::FloatingObject * lastFloatFromPreviousLine, unsigned int consecutiveHyphenatedLines, WTF::Vector<WebCore::WordMeasurement,64,WTF::CrashOnOverflow,16> & wordMeasurements) Line 110 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange(WebCore::LineLayoutState & layoutState, WebCore::BidiResolver<WebCore::InlineIterator,WebCore::BidiRun> & resolver, const WebCore::InlineIterator
& cleanLineStart, const WebCore::BidiStatus & cleanLineBidiStatus, unsigned int consecutiveHyphenatedLines) Line 1260 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutRunsAndFloats(WebCore::LineLayoutState & layoutState, bool hasInlineChild) Line 1214 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutLineBoxes(bool relayoutChildren, WebCore::LayoutUnit & repaintLogicalTop, WebCore::LayoutUnit & repaintLogicalBottom) Line 1624 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlock(bool relayoutChildren, WebCore::LayoutUnit pageLogicalHeight) Line 484 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlock::layout() Line 930 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox & child, WebCore::RenderBlockFlow::MarginInfo & marginInfo, WebCore::LayoutUnit & previousFloatLogicalBottom, WebCore::LayoutUnit
& maxFloatLogicalBottom) Line 712 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlockChildren(bool relayoutChildren, WebCore::LayoutUnit & maxFloatLogicalBottom) Line 632 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlock(bool relayoutChildren, WebCore::LayoutUnit pageLogicalHeight) Line 485 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlock::layout() Line 930 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox & child, WebCore::RenderBlockFlow::MarginInfo & marginInfo, WebCore::LayoutUnit & previousFloatLogicalBottom, WebCore::LayoutUnit
& maxFloatLogicalBottom) Line 712 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlockChildren(bool relayoutChildren, WebCore::LayoutUnit & maxFloatLogicalBottom) Line 632 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlock(bool relayoutChildren, WebCore::LayoutUnit pageLogicalHeight) Line 485 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlock::layout() Line 930 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox & child, WebCore::RenderBlockFlow::MarginInfo & marginInfo, WebCore::LayoutUnit & previousFloatLogicalBottom, WebCore::LayoutUnit
& maxFloatLogicalBottom) Line 712 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlockChildren(bool relayoutChildren, WebCore::LayoutUnit & maxFloatLogicalBottom) Line 632 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlock(bool relayoutChildren, WebCore::LayoutUnit pageLogicalHeight) Line 485 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlock::layout() Line 930 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox & child, WebCore::RenderBlockFlow::MarginInfo & marginInfo, WebCore::LayoutUnit & previousFloatLogicalBottom, WebCore::LayoutUnit
& maxFloatLogicalBottom) Line 712 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlockChildren(bool relayoutChildren, WebCore::LayoutUnit & maxFloatLogicalBottom) Line 632 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlock(bool relayoutChildren, WebCore::LayoutUnit pageLogicalHeight) Line 485 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlock::layout() Line 930 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox & child, WebCore::RenderBlockFlow::MarginInfo & marginInfo, WebCore::LayoutUnit & previousFloatLogicalBottom, WebCore::LayoutUnit
& maxFloatLogicalBottom) Line 712 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlockChildren(bool relayoutChildren, WebCore::LayoutUnit & maxFloatLogicalBottom) Line 632 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlock(bool relayoutChildren, WebCore::LayoutUnit pageLogicalHeight) Line 485 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlock::layout() Line 930 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::insertFloatingObject(WebCore::RenderBox & floatBox) Line 2247 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlockChildren(bool relayoutChildren, WebCore::LayoutUnit & maxFloatLogicalBottom) Line 627 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlock(bool relayoutChildren, WebCore::LayoutUnit pageLogicalHeight) Line 485 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlock::layout() Line 930 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox & child, WebCore::RenderBlockFlow::MarginInfo & marginInfo, WebCore::LayoutUnit & previousFloatLogicalBottom, WebCore::LayoutUnit
& maxFloatLogicalBottom) Line 712 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlockChildren(bool relayoutChildren, WebCore::LayoutUnit & maxFloatLogicalBottom) Line 632 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlock(bool relayoutChildren, WebCore::LayoutUnit pageLogicalHeight) Line 485 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlock::layout() Line 930 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox & child, WebCore::RenderBlockFlow::MarginInfo & marginInfo, WebCore::LayoutUnit & previousFloatLogicalBottom, WebCore::LayoutUnit
& maxFloatLogicalBottom) Line 712 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlockChildren(bool relayoutChildren, WebCore::LayoutUnit & maxFloatLogicalBottom) Line 632 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlock(bool relayoutChildren, WebCore::LayoutUnit pageLogicalHeight) Line 485 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlock::layout() Line 930 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox & child, WebCore::RenderBlockFlow::MarginInfo & marginInfo, WebCore::LayoutUnit & previousFloatLogicalBottom, WebCore::LayoutUnit
& maxFloatLogicalBottom) Line 712 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlockChildren(bool relayoutChildren, WebCore::LayoutUnit & maxFloatLogicalBottom) Line 632 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlock(bool relayoutChildren, WebCore::LayoutUnit pageLogicalHeight) Line 485 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlock::layout() Line 930 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox & child, WebCore::RenderBlockFlow::MarginInfo & marginInfo, WebCore::LayoutUnit & previousFloatLogicalBottom, WebCore::LayoutUnit
& maxFloatLogicalBottom) Line 712 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlockChildren(bool relayoutChildren, WebCore::LayoutUnit & maxFloatLogicalBottom) Line 632 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlock(bool relayoutChildren, WebCore::LayoutUnit pageLogicalHeight) Line 485 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlock::layout() Line 930 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox & child, WebCore::RenderBlockFlow::MarginInfo & marginInfo, WebCore::LayoutUnit & previousFloatLogicalBottom, WebCore::LayoutUnit
& maxFloatLogicalBottom) Line 712 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlockChildren(bool relayoutChildren, WebCore::LayoutUnit & maxFloatLogicalBottom) Line 632 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlock(bool relayoutChildren, WebCore::LayoutUnit pageLogicalHeight) Line 485 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlock::layout() Line 930 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox & child, WebCore::RenderBlockFlow::MarginInfo & marginInfo, WebCore::LayoutUnit & previousFloatLogicalBottom, WebCore::LayoutUnit
& maxFloatLogicalBottom) Line 712 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlockChildren(bool relayoutChildren, WebCore::LayoutUnit & maxFloatLogicalBottom) Line 632 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlock(bool relayoutChildren, WebCore::LayoutUnit pageLogicalHeight) Line 485 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlock::layout() Line 930 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox & child, WebCore::RenderBlockFlow::MarginInfo & marginInfo, WebCore::LayoutUnit & previousFloatLogicalBottom, WebCore::LayoutUnit
& maxFloatLogicalBottom) Line 712 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlockChildren(bool relayoutChildren, WebCore::LayoutUnit & maxFloatLogicalBottom) Line 632 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlock(bool relayoutChildren, WebCore::LayoutUnit pageLogicalHeight) Line 485 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlock::layout() Line 930 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox & child, WebCore::RenderBlockFlow::MarginInfo & marginInfo, WebCore::LayoutUnit & previousFloatLogicalBottom, WebCore::LayoutUnit
& maxFloatLogicalBottom) Line 712 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlockChildren(bool relayoutChildren, WebCore::LayoutUnit & maxFloatLogicalBottom) Line 632 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlock(bool relayoutChildren, WebCore::LayoutUnit pageLogicalHeight) Line 485 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlock::layout() Line 930 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox & child, WebCore::RenderBlockFlow::MarginInfo & marginInfo, WebCore::LayoutUnit & previousFloatLogicalBottom, WebCore::LayoutUnit
& maxFloatLogicalBottom) Line 712 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlockChildren(bool relayoutChildren, WebCore::LayoutUnit & maxFloatLogicalBottom) Line 632 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlock(bool relayoutChildren, WebCore::LayoutUnit pageLogicalHeight) Line 485 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlock::layout() Line 930 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox & child, WebCore::RenderBlockFlow::MarginInfo & marginInfo, WebCore::LayoutUnit & previousFloatLogicalBottom, WebCore::LayoutUnit
& maxFloatLogicalBottom) Line 712 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlockChildren(bool relayoutChildren, WebCore::LayoutUnit & maxFloatLogicalBottom) Line 632 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlock(bool relayoutChildren, WebCore::LayoutUnit pageLogicalHeight) Line 485 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlock::layout() Line 930 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox & child, WebCore::RenderBlockFlow::MarginInfo & marginInfo, WebCore::LayoutUnit & previousFloatLogicalBottom, WebCore::LayoutUnit
& maxFloatLogicalBottom) Line 712 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlockChildren(bool relayoutChildren, WebCore::LayoutUnit & maxFloatLogicalBottom) Line 632 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlockFlow::layoutBlock(bool relayoutChildren, WebCore::LayoutUnit pageLogicalHeight) Line 485 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderBlock::layout() Line 930 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderView::layoutContent(const WebCore::LayoutState & state) Line 256 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::RenderView::layout() Line 382 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::FrameView::layout(bool allowSubtree) Line 1429 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::Document::updateLayout() Line 1889 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::Document::updateLayoutIgnorePendingStylesheets(WebCore::Document::RunPostLayoutTasks runPostLayoutTasks) Line 1922 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::Element::getBoundingClientRect() Line 1071 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> WebKit.dll!WebCore::jsElementPrototypeFunctionGetBoundingClientRect(JSC::ExecState * exec) Line 5165 C++<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> [External Code] <o:p>
</o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> JavaScriptCore.dll!llint_entry() Line 8217 Unknown<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> [External Code] <o:p>
</o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> JavaScriptCore.dll!llint_entry() Line 8217 Unknown<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> Vienneau, Christopher <br>
<b>Sent:</b> Friday, November 20, 2015 5:20 PM<br>
<b>To:</b> 'WebKit Development' <webkit-dev@lists.webkit.org><br>
<b>Subject:</b> RE: Memory leak tracking in WebKit<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">To add some more information to this, the allocation that seems to have the largest delta amount of allocations between test iterations is:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">\wtf\local\wtf\hashtable.h(1248): WTF::HashTable<WTF::RefPtr<WTF::UniquedStringImpl>,WTF::KeyValuePair<WTF::RefPtr<WTF::UniquedStringImpl>,JSC::VariableEnvironmentEntry>,WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::RefPtr<WTF::UniquedStringImpl>,JSC::VariableEnvironmentEntry>
>,JSC::IdentifierRepHash,WTF::HashMap<WTF::RefPtr<WTF::UniquedStringImpl>,JSC::VariableEnvironmentEntry,JSC::IdentifierRepHash,WTF::HashTraits<WTF::RefPtr<WTF::UniquedStringImpl> >,JSC::VariableEnvironmentEntryHashTraits>::KeyValuePairTraits,WTF::HashTraits<WTF::RefPtr<WTF::UniquedStringImpl>
> >::HashTable<WTF::RefPtr<WTF::UniquedStringImpl>,WTF::KeyValuePair<WTF::RefPtr<WTF::UniquedStringImpl>,JSC::VariableEnvironmentEntry>,WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::RefPtr<WTF::UniquedStringImpl>,JSC::VariableEnvironmentEntry> >,JSC::IdentifierRepHash,WTF::HashMap<WTF::RefPtr<WTF::UniquedStringImpl>,JSC::VariableEnvironmentEntry,JSC::IdentifierRepHash,WTF::HashTraits<WTF::RefPtr<WTF::UniquedStringImpl>
>,JSC::VariableEnvironmentEntryHashTraits>::KeyValuePairTraits,WTF::HashTraits<WTF::RefPtr<WTF::UniquedStringImpl> > > + 153<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">\javascriptcore\local\javascriptcore\parser\parser.cpp(1347): JSC::Parser<JSC::Lexer<unsigned char> >::parseTryStatement<JSC::ASTBuilder> + 1984<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">\javascriptcore\local\javascriptcore\parser\parser.cpp(1480): JSC::Parser<JSC::Lexer<unsigned char> >::parseStatement<JSC::ASTBuilder> + 671<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">\javascriptcore\local\javascriptcore\parser\parser.cpp(497): JSC::Parser<JSC::Lexer<unsigned char> >::parseStatementListItem<JSC::ASTBuilder> + 100<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">\javascriptcore\local\javascriptcore\parser\parser.cpp(379): JSC::Parser<JSC::Lexer<unsigned char> >::parseSourceElements<JSC::ASTBuilder> + 745<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">\javascriptcore\local\javascriptcore\parser\parser.cpp(1406): JSC::Parser<JSC::Lexer<unsigned char> >::parseBlockStatement<JSC::ASTBuilder> + 741<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">\javascriptcore\local\javascriptcore\parser\parser.cpp(1433): JSC::Parser<JSC::Lexer<unsigned char> >::parseStatement<JSC::ASTBuilder> + 179<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">\javascriptcore\local\javascriptcore\parser\parser.cpp(497): JSC::Parser<JSC::Lexer<unsigned char> >::parseStatementListItem<JSC::ASTBuilder> + 100<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">\javascriptcore\local\javascriptcore\parser\parser.cpp(379): JSC::Parser<JSC::Lexer<unsigned char> >::parseSourceElements<JSC::ASTBuilder> + 171<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">\javascriptcore\local\javascriptcore\parser\parser.cpp(277): JSC::Parser<JSC::Lexer<unsigned char> >::parseInner + 654<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">To me this likely indicates this is what is leaking, does this bring up any ideas for anyone?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Chris<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> Vienneau, Christopher <br>
<b>Sent:</b> Thursday, November 19, 2015 10:25 PM<br>
<b>To:</b> WebKit Development <<a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a>><br>
<b>Subject:</b> Memory leak tracking in WebKit<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Hi,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I’m currently trying to track a leak in our port of WebKit. If left to soak in an automated test, looping over 100 websites, visiting each for 10 seconds, for an evening, I’m finding that memory usage goes up to well over a gigabyte (eventually
crashing). I know that a lot of things could remain cached but I’m calling code very similar to MemoryPressureHandler::releaseMemory(Critical::Yes, Synchronous::Yes) before checking the memory counters built into our application. Manually trying to reproduce
the leak, I find that many pages don’t seem to exhibit any identifiable increase in memory when; starting from a simple page, clearing the cache, visiting the test page, returning to the simple page and finally clearing the cache. I have identified some pages
which seem to be causing a problem such as cnn.com, when visiting this page it appears I can expect to lose 100-500k.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Our current code is based off of 188436:<o:p></o:p></p>
<p class="MsoNormal">-Are there any known memory leaks that I should pick up a fix for? (I searched but nothing seemed relevant to the current code I have).<o:p></o:p></p>
<p class="MsoNormal">-Are there any tools or techniques that can be recommended for identifying a leak? I’ve been improving our debug features of our memory system, but I’ve been unable to solidly identify where the memory is going.<o:p></o:p></p>
<p class="MsoNormal">-I have the WinCairo sample built at the same revision, are there any memory tools that can be used with it to identify if the leak exists there too?
<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks for any suggestions<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Chris Vienneau<o:p></o:p></p>
</div>
</body>
</html>