<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">I believe that any way to specify fuzziness should not treat the following cases the same:<div class=""><br class=""></div><div class="">- 1 pixel being 100% wrong</div><div class="">- All pixels being 1% wrong</div><div class=""><br class=""></div><div class="">There are certain cases where one of those should cause a failure, but the other shouldn't.</div><div class=""><br class=""></div><div class="">--Myles<br class=""><div><blockquote type="cite" class=""><div class="">On Nov 18, 2015, at 10:44 PM, Alexey Proskuryakov <<a href="mailto:ap@webkit.org" class="">ap@webkit.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">18 нояб. 2015 г., в 11:50, Simon Fraser <<a href="mailto:simon.fraser@apple.com" class="">simon.fraser@apple.com</a>> написал(а):</div><br class="Apple-interchange-newline"><div class=""><div class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">There are some well-understood reasons why a test might not exactly match its reference. One is that the test uses compositing layers to do clipping, but the reference just clips with drawing, and these are not expected to give a pixel-perfect match.</div><div class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br class=""></div><div class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">I proposed a way to allow a test to specify a custom tolerance in <a href="https://bugs.webkit.org/show_bug.cgi?id=149828" class="">https://bugs.webkit.org/show_bug.cgi?id=149828</a>. If we had this, it would allow me to fix <a href="https://bugs.webkit.org/show_bug.cgi?id=142258" class="">142258</a> and <a href="https://bugs.webkit.org/show_bug.cgi?id=146523" class="">146523</a>.</div></div></blockquote><br class=""></div><div class="">Bug 142258 also serves as an example for why we shouldn't do this. Both known reasons for it are actual bugs that needed to be discovered, and need to be fixed.</div><div class=""><br class=""></div><div class="">What are the causes for flakiness in bug 146523?</div><br class=""><div class="">
<div class="">- Alexey</div>
</div>
<br class=""></div>_______________________________________________<br class="">webkit-dev mailing list<br class=""><a href="mailto:webkit-dev@lists.webkit.org" class="">webkit-dev@lists.webkit.org</a><br class="">https://lists.webkit.org/mailman/listinfo/webkit-dev<br class=""></div></blockquote></div><br class=""></div></body></html>