<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Helvetica;
panose-1:2 11 6 4 2 2 2 2 2 4;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
@font-face
{font-family:Verdana;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.apple-converted-space
{mso-style-name:apple-converted-space;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">Just FYI I filed a bug for the crash I encounter here:<o:p></o:p></p>
<p class="MsoNormal"><a href="https://bugs.webkit.org/show_bug.cgi?id=147123"><b><span style="font-size:11.5pt;font-family:"Verdana",sans-serif;color:#663366">Bug 147123</span></b></a><span class="apple-converted-space"><b><span style="font-size:11.5pt;font-family:"Verdana",sans-serif;color:black;background:#D0D0D0"> </span></b></span><b><span style="font-size:11.5pt;font-family:"Verdana",sans-serif;color:black;background:#D0D0D0">-</span></b><span class="apple-converted-space"><b><span style="font-size:11.5pt;font-family:"Verdana",sans-serif;color:black"> </span></b></span><b><span style="font-size:11.5pt;font-family:"Verdana",sans-serif;color:black">JavaScriptCore
LLInt crash with VS2015RC</span></b><o:p></o:p></p>
<p class="MsoNormal"><a href="https://bugs.webkit.org/show_bug.cgi?id=147123">https://bugs.webkit.org/show_bug.cgi?id=147123</a><span style="color:#1F497D">
</span><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Alex Christensen [mailto:achristensen@apple.com]
<br>
<b>Sent:</b> Wednesday, July 15, 2015 10:55 AM<br>
<b>To:</b> Vienneau, Christopher<br>
<b>Cc:</b> Brent Fulgham; Webkit Development List<br>
<b>Subject:</b> Re: [webkit-dev] Compilation issue with VS2015RC<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I only did one 64-bit build with VS2015RC and I did not run into this crash. Please file another bug. It’s definitely worth looking into.<o:p></o:p></p>
<div>
<p class="MsoNormal">My change to CSSPrimitiveValue.h in <a href="https://bugs.webkit.org/show_bug.cgi?id=146579">https://bugs.webkit.org/show_bug.cgi?id=146579</a> is a hack that should not be committed, but it’s sure nice to be able to link successfully while
doing experimental work.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal">On Jul 14, 2015, at 5:20 PM, Vienneau, Christopher <<a href="mailto:cvienneau@ea.com">cvienneau@ea.com</a>> wrote:<o:p></o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Using the changes in the patch you provided, I made progress but I have some observations to report:</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">I didn’t find the changes in ConsoleClient.cpp to be necessary, actually with my version of webkit they didn’t build as is,
I removed them. I think that the change to CSSPrimitiveValue.h is actually the part I was missing to fix the linking error.</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">When attempting to run with my test application I’m finding that most websites,<span class="apple-converted-space"> </span><a href="http://facebook.com/"><span style="color:purple">facebook.com</span></a><span class="apple-converted-space"> </span>for
example, are crashing in LowLevelInterpreterWin.asm code identified by<span class="apple-converted-space"> </span></span><span style="font-size:9.5pt;font-family:Consolas;background:white">LowLevelInterpreter.asm:476</span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">:</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="line-height:10.5pt"><span style="font-size:9.5pt;font-family:Consolas;background:white"> _offlineasm_doCall__177_loadConstantOrVariable__done:</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="line-height:10.5pt"><span style="font-size:9.5pt;font-family:Consolas;background:white"> cmp rbx, rcx ; ..\..\JavaScriptCore\local\JavaScriptCore\llint/LowLevelInterpreter64.asm:1798</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="line-height:10.5pt"><span style="font-size:9.5pt;font-family:Consolas;background:white"> jne _offlineasm_doCall__opCallSlow</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="line-height:10.5pt"><span style="font-size:9.5pt;font-family:Consolas;background:white"> movsxd rbx, dword ptr [32 + r8 + rsi * 8] ; ..\..\JavaScriptCore\local\JavaScriptCore\llint\LowLevelInterpreter.asm:114</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="line-height:10.5pt"><span style="font-size:9.5pt;font-family:Consolas;background:white"> sal ebx, 3 ; ..\..\JavaScriptCore\local\JavaScriptCore\llint/LowLevelInterpreter64.asm:1800</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="line-height:10.5pt"><span style="font-size:9.5pt;font-family:Consolas;background:white"> neg rbx ; ..\..\JavaScriptCore\local\JavaScriptCore\llint/LowLevelInterpreter64.asm:1801</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="line-height:10.5pt"><span style="font-size:9.5pt;font-family:Consolas;background:white"> add rbx, rbp ; ..\..\JavaScriptCore\local\JavaScriptCore\llint/LowLevelInterpreter64.asm:1802</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="line-height:10.5pt"><span style="font-size:9.5pt;font-family:Consolas;background:white"> mov qword ptr [24 + rbx], rcx ; ..\..\JavaScriptCore\local\JavaScriptCore\llint/LowLevelInterpreter64.asm:1803</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="line-height:10.5pt"><span style="font-size:9.5pt;font-family:Consolas;background:white"> movsxd rcx, dword ptr [24 + r8 + rsi * 8] ; ..\..\JavaScriptCore\local\JavaScriptCore\llint\LowLevelInterpreter.asm:114</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="line-height:10.5pt"><span style="font-size:9.5pt;font-family:Consolas;background:white"> mov dword ptr [36 + rbp], esi ; ..\..\JavaScriptCore\local\JavaScriptCore\llint/LowLevelInterpreter64.asm:1805</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="line-height:10.5pt"><span style="font-size:9.5pt;font-family:Consolas;background:white"> mov dword ptr [32 + rbx], ecx ; ..\..\JavaScriptCore\local\JavaScriptCore\llint/LowLevelInterpreter64.asm:1806</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="line-height:10.5pt"><span style="font-size:9.5pt;font-family:Consolas;background:white"> add rbx, 16 ; ..\..\JavaScriptCore\local\JavaScriptCore\llint/LowLevelInterpreter64.asm:1807</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="line-height:10.5pt"><span style="font-size:9.5pt;font-family:Consolas;background:white"> mov rsp, rbx ; ..\..\JavaScriptCore\local\JavaScriptCore\llint\LowLevelInterpreter.asm:472</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="line-height:10.5pt"><span style="font-size:9.5pt;font-family:Consolas;background:white"> <span class="apple-converted-space"> </span></span><span style="font-size:9.5pt;font-family:Consolas;background:red">call qword ptr [32 +
rdx] ; ..\..\JavaScriptCore\local\JavaScriptCore\llint\LowLevelInterpreter.asm:476</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="line-height:10.5pt"><span style="font-size:9.5pt;font-family:Consolas;background:white"> mov rcx, qword ptr [16 + rbp] ; ..\..\JavaScriptCore\local\JavaScriptCore\llint\LowLevelInterpreter.asm:461</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="line-height:10.5pt"><span style="font-size:9.5pt;font-family:Consolas;background:white"> mov edi, dword ptr [56 + rcx] ; ..\..\JavaScriptCore\local\JavaScriptCore\llint\LowLevelInterpreter.asm:449</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="line-height:10.5pt"><span style="font-size:9.5pt;font-family:Consolas;background:white"> sal rdi, 3 ; ..\..\JavaScriptCore\local\JavaScriptCore\llint\LowLevelInterpreter.asm:450</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="line-height:10.5pt"><span style="font-size:9.5pt;font-family:Consolas;background:white"> add rdi, 64 ; ..\..\JavaScriptCore\local\JavaScriptCore\llint\LowLevelInterpreter.asm:451</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="line-height:10.5pt"><span style="font-size:9.5pt;font-family:Consolas;background:white"> mov rsp, rbp ; ..\..\JavaScriptCore\local\JavaScriptCore\llint\LowLevelInterpreter.asm:456</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="line-height:10.5pt"><span style="font-size:9.5pt;font-family:Consolas;background:white"> sub rsp, rdi</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="line-height:10.5pt"><span style="font-size:9.5pt;font-family:Consolas;background:white"> mov esi, dword ptr [36 + rbp] ; ..\..\JavaScriptCore\local\JavaScriptCore\llint/LowLevelInterpreter64.asm:45</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="line-height:10.5pt"><span style="font-size:9.5pt;font-family:Consolas;background:white"> mov r8, qword ptr [16 + rbp] ; ..\..\JavaScriptCore\local\JavaScriptCore\llint/LowLevelInterpreter64.asm:46</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="line-height:10.5pt"><span style="font-size:9.5pt;font-family:Consolas;background:white"> mov r8, qword ptr [104 + r8] ; ..\..\JavaScriptCore\local\JavaScriptCore\llint/LowLevelInterpreter64.asm:47</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="line-height:10.5pt"><span style="font-size:9.5pt;font-family:Consolas;background:white"> movsxd rdx, dword ptr [8 + r8 + rsi * 8] ; ..\..\JavaScriptCore\local\JavaScriptCore\llint\LowLevelInterpreter.asm:114</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="line-height:10.5pt"><span style="font-size:9.5pt;font-family:Consolas;background:white"> mov qword ptr [0 + rbp + rdx * 8], rax ; ..\..\JavaScriptCore\local\JavaScriptCore\llint/LowLevelInterpreter64.asm:49</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="line-height:10.5pt"><span style="font-size:9.5pt;font-family:Consolas;background:white"> mov rcx, qword ptr [64 + r8 + rsi * 8] ; ..\..\JavaScriptCore\local\JavaScriptCore\llint\LowLevelInterpreter.asm:118</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="line-height:10.5pt"><span style="font-size:9.5pt;font-family:Consolas;background:white"> mov qword ptr [16 + rcx], rax ; ..\..\JavaScriptCore\local\JavaScriptCore\llint/LowLevelInterpreter64.asm:491</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="line-height:10.5pt"><span style="font-size:9.5pt;font-family:Consolas;background:white"> add rsi, 9 ; ..\..\JavaScriptCore\local\JavaScriptCore\llint/LowLevelInterpreter64.asm:31</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="line-height:10.5pt"><span style="font-size:9.5pt;font-family:Consolas;background:white"> jmp qword ptr [0 + r8 + rsi * 8] ; ..\..\JavaScriptCore\local\JavaScriptCore\llint/LowLevelInterpreter64.asm:27</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">I tried regenerating the asm files but still have the issue. I expect that some updates need to be done to the asm generator
for vs2015. Have you found this issue too? Or have any suggestion on how to correct the crash?</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Chris</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
</div>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span class="apple-converted-space"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> </span></span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Vienneau,
Christopher<span class="apple-converted-space"> </span><br>
<b>Sent:</b><span class="apple-converted-space"> </span>Friday, July 10, 2015 4:36 PM<br>
<b>To:</b><span class="apple-converted-space"> </span>'Brent Fulgham'<br>
<b>Cc:</b><span class="apple-converted-space"> </span>Webkit Development List<br>
<b>Subject:</b><span class="apple-converted-space"> </span>RE: [webkit-dev] Compilation issue with VS2015RC</span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"> <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">A brief look at your patch shows similar changes that I have done, I’ll investigate the additional changes which seem to relate
to the linker error. I’ll keep my eye on this bug now.</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Many Thanks</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
</div>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span class="apple-converted-space"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> </span></span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Brent
Fulgham [<a href="mailto:bfulgham@apple.com"><span style="color:purple">mailto:bfulgham@apple.com</span></a>]<span class="apple-converted-space"> </span><br>
<b>Sent:</b><span class="apple-converted-space"> </span>Friday, July 10, 2015 4:30 PM<br>
<b>To:</b><span class="apple-converted-space"> </span>Vienneau, Christopher<br>
<b>Cc:</b><span class="apple-converted-space"> </span>Webkit Development List<br>
<b>Subject:</b><span class="apple-converted-space"> </span>Re: [webkit-dev] Compilation issue with VS2015RC</span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"> <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt">Hi Chris,<o:p></o:p></p>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"> <o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt">We noticed the same thing. Please see <<a href="https://bugs.webkit.org/show_bug.cgi?id=146579"><span style="color:purple">https://bugs.webkit.org/show_bug.cgi?id=146579</span></a>>, where we are discussing
how to move forward.<o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"> <o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt">Thanks!<o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"> <o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt">-Brent<o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"> <o:p></o:p></p>
</div>
<div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt">On Jul 10, 2015, at 4:05 PM, Vienneau, Christopher <<a href="mailto:cvienneau@ea.com"><span style="color:purple">cvienneau@ea.com</span></a>> wrote:<o:p></o:p></p>
</div>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"> <o:p></o:p></p>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Hello,</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> </span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Recently we’ve been attempting to move our code base to build with VS2015 RC since this provides us with some support that we’ll be needing
in the future for our products. The changes for compilation with the new compiler haven’t been too bad, and I have everything building with the exception of one line:</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> </span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">FILE: JSCSSValueCustom.cpp</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Line95:</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">67 JSValue toJS(ExecState*, JSDOMGlobalObject* globalObject, CSSValue* value)</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">68 {</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">69 if (!value)</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">70 return jsNull();</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">71 <span class="apple-converted-space"> </span></span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">72 // Scripts should only ever see cloned CSSValues, never the internal ones.</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">73 ASSERT(value->isCSSOMSafe());</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">74 <span class="apple-converted-space"> </span></span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">75 // If we're here under erroneous circumstances, prefer returning null over a potentially insecure value.</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">76 if (!value->isCSSOMSafe())</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">77 return jsNull();</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">78 <span class="apple-converted-space"> </span></span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">79 JSObject* wrapper = getCachedWrapper(globalObject->world(), value);</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">80 <span class="apple-converted-space"> </span></span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">81 if (wrapper)</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">82 return wrapper;</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">83 <span class="apple-converted-space"> </span></span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">84 if (value->isWebKitCSSTransformValue())</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">85 wrapper = CREATE_DOM_WRAPPER(globalObject, WebKitCSSTransformValue, value);</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">86 else if (value->isWebKitCSSFilterValue())</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">87 wrapper = CREATE_DOM_WRAPPER(globalObject, WebKitCSSFilterValue, value);</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">88 else if (value->isValueList())</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">89 wrapper = CREATE_DOM_WRAPPER(globalObject, CSSValueList, value);</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">90 else if (value->isSVGPaint())</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">91 wrapper = CREATE_DOM_WRAPPER(globalObject, SVGPaint, value);</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">92 else if (value->isSVGColor())</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">93 wrapper = CREATE_DOM_WRAPPER(globalObject, SVGColor, value);</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">94 else if (value->isPrimitiveValue())</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;background:yellow">95 wrapper = CREATE_DOM_WRAPPER(globalObject, CSSPrimitiveValue, value);</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">96 else</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">97 wrapper = CREATE_DOM_WRAPPER(globalObject, CSSValue, value);</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">98 <span class="apple-converted-space"> </span></span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">99 return wrapper;</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">100 }</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> </span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">It produces the linker error:</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#843C0C">JSBindingsAllInOne.obj : error LNK2019: unresolved external symbol "public: __thiscall WebCore::CSSPrimitiveValue::operator<class
WTF::Ref<class WebCore::CSSPrimitiveValue> > class WTF::Ref<class WebCore::CSSPrimitiveValue>(void)const " (??$?BV?$Ref@VCSSPrimitiveValue@WebCore@@@WTF@@@CSSPrimitiveValue@WebCore@@QBE?AV?$Ref@VCSSPrimitiveValue@WebCore@@@WTF@@XZ) referenced in function "class
WebCore::JSDOMWrapper * __cdecl WebCore::createWrapper<class WebCore::JSCSSPrimitiveValue,class WebCore::CSSPrimitiveValue>(class WebCore::JSDOMGlobalObject *,class WebCore::CSSPrimitiveValue *)" (??$createWrapper@VJSCSSPrimitiveValue@WebCore@@VCSSPrimitiveValue@2@@WebCore@@YAPAVJSDOMWrapper@0@PAVJSDOMGlobalObject@0@PAVCSSPrimitiveValue@0@@Z)</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> </span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">As you can see there are many other similar code lines in the area, none of which cause a problem. Despite my many attempts I can’t seem
to satisfy the linker by providing it the definition it needs.</span><o:p></o:p></p>
</div>
</div>
<div style="margin-left:.5in">
<div>
<p class="MsoNormal" style="text-indent:-.25in;mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:Symbol">·</span><span style="font-size:7.0pt"> <span class="apple-converted-space"> </span></span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">I’ve
attempted manually adding the copy constructor definition (I believe that is what it is describing):</span><o:p></o:p></p>
</div>
</div>
<div style="margin-left:1.0in">
<div>
<p class="MsoNormal" style="text-indent:-.25in;mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Courier New"">o</span><span style="font-size:7.0pt"> <span class="apple-converted-space"> </span></span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">CSSPrimitiveValue::CSSPrimitiveValue(ClassType
classType, const CSSPrimitiveValue& cloneFrom)</span><o:p></o:p></p>
</div>
</div>
<div style="margin-left:1.0in">
<div>
<p class="MsoNormal" style="text-indent:-.25in;mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Courier New"">o</span><span style="font-size:7.0pt"> <span class="apple-converted-space"> </span></span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">CSSPrimitiveValue::CSSPrimitiveValue(const
CSSPrimitiveValue& cloneFrom)</span><o:p></o:p></p>
</div>
</div>
<div style="margin-left:.5in">
<div>
<p class="MsoNormal" style="text-indent:-.25in;mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:Symbol">·</span><span style="font-size:7.0pt"> <span class="apple-converted-space"> </span></span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">I’ve
tried removing the usage of the “AllInOne” file, thinking that it may be causing some issue.</span><o:p></o:p></p>
</div>
</div>
<div style="margin-left:.5in">
<div>
<p class="MsoNormal" style="text-indent:-.25in;mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:Symbol">·</span><span style="font-size:7.0pt"> <span class="apple-converted-space"> </span></span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">I’ve
attempted to debug the code when the offending line is commented out, hoping to see better how the other lines function. Though I’m not sure what path would cause it to execute, I haven’t hit it in my limited testing.</span><o:p></o:p></p>
</div>
</div>
<div style="margin-left:.5in">
<div>
<p class="MsoNormal" style="text-indent:-.25in;mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:Symbol">·</span><span style="font-size:7.0pt"> <span class="apple-converted-space"> </span></span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">One
of my colleagues reached out the MS on the issue, but it behaves as expect on their end (small sample code does not find a bug in the compiler). <a href="https://social.msdn.microsoft.com/Forums/en-US/6b9787f3-62bd-473a-8aa1-5f6cd85ed87b/breaking-change-in-visual-studio-2015-rc?forum=vcgeneral"><span style="color:#954F72">https://social.msdn.microsoft.com/Forums/en-US/6b9787f3-62bd-473a-8aa1-5f6cd85ed87b/breaking-change-in-visual-studio-2015-rc?forum=vcgeneral</span></a></span><o:p></o:p></p>
</div>
</div>
<div style="margin-left:.5in">
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> </span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> </span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Any suggestions would be much appreciated</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> </span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Thanks</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> </span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Chris</span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> </span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> </span><o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> </span><o:p></o:p></p>
</div>
</div>
<div>
<p class="MsoNormal" style="line-height:10.5pt"><span style="font-size:9.0pt;font-family:"Helvetica",sans-serif">_______________________________________________<br>
webkit-dev mailing list<br>
</span><a href="mailto:webkit-dev@lists.webkit.org"><span style="font-size:9.0pt;font-family:"Helvetica",sans-serif;color:#954F72">webkit-dev@lists.webkit.org</span></a><span style="font-size:9.0pt;font-family:"Helvetica",sans-serif"><br>
</span><a href="https://lists.webkit.org/mailman/listinfo/webkit-dev"><span style="font-size:9.0pt;font-family:"Helvetica",sans-serif;color:#954F72">https://lists.webkit.org/mailman/listinfo/webkit-dev</span></a><o:p></o:p></p>
</div>
</div>
</blockquote>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"> <o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><span style="font-size:9.0pt;font-family:"Helvetica",sans-serif">_______________________________________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>
<a href="https://lists.webkit.org/mailman/listinfo/webkit-dev">https://lists.webkit.org/mailman/listinfo/webkit-dev</a></span><o:p></o:p></p>
</div>
</blockquote>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</body>
</html>