<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Helvetica;
panose-1:2 11 6 4 2 2 2 2 2 4;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.apple-converted-space
{mso-style-name:apple-converted-space;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">A brief look at your patch shows similar changes that I have done, I’ll investigate the additional changes which seem to relate to the linker error. I’ll keep
my eye on this bug now.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Many Thanks<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Brent Fulgham [mailto:bfulgham@apple.com]
<br>
<b>Sent:</b> Friday, July 10, 2015 4:30 PM<br>
<b>To:</b> Vienneau, Christopher<br>
<b>Cc:</b> Webkit Development List<br>
<b>Subject:</b> Re: [webkit-dev] Compilation issue with VS2015RC<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Hi Chris,<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">We noticed the same thing. Please see <<a href="https://bugs.webkit.org/show_bug.cgi?id=146579">https://bugs.webkit.org/show_bug.cgi?id=146579</a>>, where we are discussing how to move forward.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Thanks!<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">-Brent<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal">On Jul 10, 2015, at 4:05 PM, Vienneau, Christopher <<a href="mailto:cvienneau@ea.com">cvienneau@ea.com</a>> wrote:<o:p></o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Hello,<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Recently we’ve been attempting to move our code base to build with VS2015 RC since this provides us with some support that we’ll be needing
in the future for our products. The changes for compilation with the new compiler haven’t been too bad, and I have everything building with the exception of one line:<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">FILE: JSCSSValueCustom.cpp<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Line95:<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">67 JSValue toJS(ExecState*, JSDOMGlobalObject* globalObject, CSSValue* value)<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">68 {<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">69 if (!value)<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">70 return jsNull();<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">71 <span class="apple-converted-space"> </span><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">72 // Scripts should only ever see cloned CSSValues, never the internal ones.<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">73 ASSERT(value->isCSSOMSafe());<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">74 <span class="apple-converted-space"> </span><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">75 // If we're here under erroneous circumstances, prefer returning null over a potentially insecure value.<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">76 if (!value->isCSSOMSafe())<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">77 return jsNull();<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">78 <span class="apple-converted-space"> </span><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">79 JSObject* wrapper = getCachedWrapper(globalObject->world(), value);<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">80 <span class="apple-converted-space"> </span><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">81 if (wrapper)<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">82 return wrapper;<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">83 <span class="apple-converted-space"> </span><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">84 if (value->isWebKitCSSTransformValue())<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">85 wrapper = CREATE_DOM_WRAPPER(globalObject, WebKitCSSTransformValue, value);<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">86 else if (value->isWebKitCSSFilterValue())<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">87 wrapper = CREATE_DOM_WRAPPER(globalObject, WebKitCSSFilterValue, value);<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">88 else if (value->isValueList())<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">89 wrapper = CREATE_DOM_WRAPPER(globalObject, CSSValueList, value);<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">90 else if (value->isSVGPaint())<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">91 wrapper = CREATE_DOM_WRAPPER(globalObject, SVGPaint, value);<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">92 else if (value->isSVGColor())<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">93 wrapper = CREATE_DOM_WRAPPER(globalObject, SVGColor, value);<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">94 else if (value->isPrimitiveValue())<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;background:yellow">95 wrapper = CREATE_DOM_WRAPPER(globalObject, CSSPrimitiveValue, value);</span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">96 else<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">97 wrapper = CREATE_DOM_WRAPPER(globalObject, CSSValue, value);<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">98 <span class="apple-converted-space"> </span><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">99 return wrapper;<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">100 }<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">It produces the linker error:<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#843C0C">JSBindingsAllInOne.obj : error LNK2019: unresolved external symbol "public: __thiscall WebCore::CSSPrimitiveValue::operator<class
WTF::Ref<class WebCore::CSSPrimitiveValue> > class WTF::Ref<class WebCore::CSSPrimitiveValue>(void)const " (??$?BV?$Ref@VCSSPrimitiveValue@WebCore@@@WTF@@@CSSPrimitiveValue@WebCore@@QBE?AV?$Ref@VCSSPrimitiveValue@WebCore@@@WTF@@XZ) referenced in function "class
WebCore::JSDOMWrapper * __cdecl WebCore::createWrapper<class WebCore::JSCSSPrimitiveValue,class WebCore::CSSPrimitiveValue>(class WebCore::JSDOMGlobalObject *,class WebCore::CSSPrimitiveValue *)" (??$createWrapper@VJSCSSPrimitiveValue@WebCore@@VCSSPrimitiveValue@2@@WebCore@@YAPAVJSDOMWrapper@0@PAVJSDOMGlobalObject@0@PAVCSSPrimitiveValue@0@@Z)</span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">As you can see there are many other similar code lines in the area, none of which cause a problem. Despite my many attempts I can’t seem
to satisfy the linker by providing it the definition it needs.<o:p></o:p></span></p>
</div>
<div style="margin-left:.5in">
<p class="MsoNormal" style="text-indent:-.25in;mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:Symbol">·</span><span style="font-size:7.0pt"> <span class="apple-converted-space"> </span></span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">I’ve
attempted manually adding the copy constructor definition (I believe that is what it is describing):<o:p></o:p></span></p>
</div>
<div style="margin-left:1.0in">
<p class="MsoNormal" style="text-indent:-.25in;mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Courier New"">o</span><span style="font-size:7.0pt"> <span class="apple-converted-space"> </span></span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">CSSPrimitiveValue::CSSPrimitiveValue(ClassType
classType, const CSSPrimitiveValue& cloneFrom)<o:p></o:p></span></p>
</div>
<div style="margin-left:1.0in">
<p class="MsoNormal" style="text-indent:-.25in;mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Courier New"">o</span><span style="font-size:7.0pt"> <span class="apple-converted-space"> </span></span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">CSSPrimitiveValue::CSSPrimitiveValue(const
CSSPrimitiveValue& cloneFrom)<o:p></o:p></span></p>
</div>
<div style="margin-left:.5in">
<p class="MsoNormal" style="text-indent:-.25in;mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:Symbol">·</span><span style="font-size:7.0pt"> <span class="apple-converted-space"> </span></span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">I’ve
tried removing the usage of the “AllInOne” file, thinking that it may be causing some issue.<o:p></o:p></span></p>
</div>
<div style="margin-left:.5in">
<p class="MsoNormal" style="text-indent:-.25in;mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:Symbol">·</span><span style="font-size:7.0pt"> <span class="apple-converted-space"> </span></span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">I’ve
attempted to debug the code when the offending line is commented out, hoping to see better how the other lines function. Though I’m not sure what path would cause it to execute, I haven’t hit it in my limited testing.<o:p></o:p></span></p>
</div>
<div style="margin-left:.5in">
<p class="MsoNormal" style="text-indent:-.25in;mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:Symbol">·</span><span style="font-size:7.0pt"> <span class="apple-converted-space"> </span></span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">One
of my colleagues reached out the MS on the issue, but it behaves as expect on their end (small sample code does not find a bug in the compiler). <a href="https://social.msdn.microsoft.com/Forums/en-US/6b9787f3-62bd-473a-8aa1-5f6cd85ed87b/breaking-change-in-visual-studio-2015-rc?forum=vcgeneral"><span style="color:#954F72">https://social.msdn.microsoft.com/Forums/en-US/6b9787f3-62bd-473a-8aa1-5f6cd85ed87b/breaking-change-in-visual-studio-2015-rc?forum=vcgeneral</span></a><o:p></o:p></span></p>
</div>
<div style="margin-left:.5in">
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Any suggestions would be much appreciated<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Thanks<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Chris<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> <o:p></o:p></span></p>
</div>
<p class="MsoNormal"><span style="font-size:9.0pt;font-family:"Helvetica",sans-serif">_______________________________________________<br>
webkit-dev mailing list<br>
</span><a href="mailto:webkit-dev@lists.webkit.org"><span style="font-size:9.0pt;font-family:"Helvetica",sans-serif;color:#954F72">webkit-dev@lists.webkit.org</span></a><span style="font-size:9.0pt;font-family:"Helvetica",sans-serif"><br>
</span><a href="https://lists.webkit.org/mailman/listinfo/webkit-dev"><span style="font-size:9.0pt;font-family:"Helvetica",sans-serif;color:#954F72">https://lists.webkit.org/mailman/listinfo/webkit-dev</span></a><o:p></o:p></p>
</div>
</blockquote>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</body>
</html>