<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jul 8, 2015 at 4:07 AM, Maciej Stachowiak <span dir="ltr"><<a href="mailto:mjs@apple.com" target="_blank">mjs@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div><span class=""><blockquote type="cite"><div>On Jul 7, 2015, at 3:36 AM, Yusuke SUZUKI <<a href="mailto:utatane.tea@gmail.com" target="_blank">utatane.tea@gmail.com</a>> wrote:</div><br><div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Jul 7, 2015 at 8:54 AM, Geoffrey Garen <span dir="ltr"><<a href="mailto:ggaren@apple.com" target="_blank">ggaren@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">I’m suggesting a default runloop for non-web content.<div><br></div><div>I haven’t read through the details of integrating with the web content definition of micro task.</div><div><br></div><div>Geoff</div></div></blockquote><div><br></div><div>OK. Reinventing runloop each time is costly.</div><div>On the other hand, sometimes, users would like to use the other runloop such as libuv.</div><div>So what do you think about providing the both.</div><div><br></div><div>1. Provide default runloop in JSC</div><div>2. Provide the way to register callback for enqueueJob. If it's provided, (1) is disabled for this VM.</div><div><br></div><div>(1) would become the following (quick proposal)</div><div><br></div><div>void JSContextRunMicrotasks(JSContextRef, unsigned someFlags);</div><div>bool JSContextIsMicrotasksEmpty(JSContextRef);</div><div><br></div><div>In this case, if we would like to close the VM,</div><div><br></div><div>bool executed = false;</div><div>do {</div><div> executed = false;</div><div> for each context belongging to the given VM {</div><div> if (JSContxtIsMicrotasksEmpty(context)) {</div><div> executed = true;</div><div> JSContextRunMicrotasks(context, ...);</div><div> }</div><div> }</div><div>} while (executed);</div><div>Close(VM);</div></div></div></div></div></blockquote><div><br></div></span><div>I think that Goeff's suggest would be that microtasks would normally run without the client having to make any special calls at all to account for them. Possibly this may imply a requirement of running a CFRunLoop on the relevant thread.</div><div><br></div><div>I also think your API doesn't account for nesting very well - it requires the client app to know the VM nesting level. It would be better if that was tracked and micro tasks could run on exiting the outermost VM and/or </div><div><div class="h5"><br></div></div></div></div></blockquote><div><br></div><div>I see, thanks :D</div><div><br></div><div>Counting the nesting level and when the nesting level becomes 0 and at the epilogue of the JSC APIs, draining queued microtasks.</div><div><br></div><div>I guess VM's apiLock (locked by JSLockHolder) already counts the VM depth and manages API's scope. Leveraging this could solve the requirements I think. (Of coursing, kicking some processing in the C++ destructor is not good. When leveraging this mechanizm, we need to consider the way anyway.)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div><div class="h5"><blockquote type="cite"><div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div>(2) would become the original proposal.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div><div><br><div><blockquote type="cite"><div>On Jul 6, 2015, at 4:44 PM, Maciej Stachowiak <<a href="mailto:mjs@apple.com" target="_blank">mjs@apple.com</a>> wrote:</div><br><div><div style="word-wrap:break-word"><div><br></div><div>Should JS be defining an event loop abstraction that WebCore then uses? That would be weird, because the required behavior of the even loop in web content is chock full of issues that are not at all related to JavaScript. JSC doesn't even know enough to run microtasks at all the right times (from reading the spec it seems that way, at least) for the Web case. Or are you saying it would have a fallback runloop for non-Web contents?</div><div><br></div><div>Regards,</div><div>Maciej</div><div><br></div><div><blockquote type="cite"><div>On Jul 6, 2015, at 3:24 PM, Geoffrey Garen <<a href="mailto:ggaren@apple.com" target="_blank">ggaren@apple.com</a>> wrote:</div><br><div><div style="word-wrap:break-word">I think it would be better for JavaScriptCore to handle micro tasks natively.<div><br></div><div>It’s not so great for each client to need to reinvent the microtask runloop abstraction.<br><div><br></div><div>Geoff</div><div><br><div><blockquote type="cite"><div>On Jul 6, 2015, at 10:05 AM, Yusuke SUZUKI <<a href="mailto:utatane.tea@gmail.com" target="_blank">utatane.tea@gmail.com</a>> wrote:</div><br><div><div dir="ltr">Hi WebKittens,
<div><br></div><div>I've landed the update of the ES6 Promise implementation.</div><div>Through this work, I've experimentally added the internal private function, @enqueueJob(JS function, JS array for arguments).</div><div>This is corresponding to the ES6 spec EnqueueJob[1].</div><div><br></div><div>This EnqueueJob handler is now tightly integrated with WebCore's microtask infrastructure. So in JSC framework side, we cannot use this function.</div><div>As a result, current JSC framework disables Promise because there's no event loop abstraction.</div><div><br></div><div>So I propose the API configuring euqueueJob handler into JSC VM (That corresponds to the Realm in ECMA spec).</div><div><br></div><div>Like,</div><div><br></div><div>void JSContextGroupSetEnqueueJobCallback(JSContextGroupRef, JSEnqueueJobCallback, void* callbackData);</div><div><br></div><div>What do you think about this?</div><div><br></div><div>[1]: <a href="http://ecma-international.org/ecma-262/6.0/#sec-enqueuejob" target="_blank">http://ecma-international.org/ecma-262/6.0/#sec-enqueuejob</a></div><div><br></div><div>Best Regards,</div><div>Yusuke Suzuki</div></div>
_______________________________________________<br>webkit-dev mailing list<br><a href="mailto:webkit-dev@lists.webkit.org" target="_blank">webkit-dev@lists.webkit.org</a><br><a href="https://lists.webkit.org/mailman/listinfo/webkit-dev" target="_blank">https://lists.webkit.org/mailman/listinfo/webkit-dev</a><br></div></blockquote></div><br></div></div></div>_______________________________________________<br>webkit-dev mailing list<br><a href="mailto:webkit-dev@lists.webkit.org" target="_blank">webkit-dev@lists.webkit.org</a><br><a href="https://lists.webkit.org/mailman/listinfo/webkit-dev" target="_blank">https://lists.webkit.org/mailman/listinfo/webkit-dev</a><br></div></blockquote></div><br></div></div></blockquote></div><br></div></div></div></div></blockquote></div><br></div></div>
</div></blockquote></div></div></div><br></div></blockquote></div><br></div></div>